starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #236] [MERGED] Default zip ver to 20 (deflate/encyption), fixes #164 #918

New Issue
Open
opened 2026-01-29 22:18:12 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:18:12 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/236
Author: @damieng
Created: 5/20/2017
Status: ✅ Merged
Merged: 5/22/2017
Merged by: @adamhathcock

Base: master ← Head: zip-min-version-of-20

📝 Commits (1)

  • 575f10f Default zip ver to 20 (deflate/encyption), fixes #164

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/SharpCompress/Writers/Zip/ZipCentralDirectoryEntry.cs (+1 -1)

📄 Description

Sets the default level of '20' for zip files in the ZipCentralDirectoryBlock to match '20' used in Zip Local File Headers at https://github.com/adamhathcock/sharpcompress/blob/master/src/SharpCompress/Writers/Zip/ZipWriter.cs#L162

This makes Microsoft's compression.io library used by NuGet happy (and possibly some other tools)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/236 **Author:** [@damieng](https://github.com/damieng) **Created:** 5/20/2017 **Status:** ✅ Merged **Merged:** 5/22/2017 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `zip-min-version-of-20` --- ### 📝 Commits (1) - [`575f10f`](https://github.com/adamhathcock/sharpcompress/commit/575f10f766756161157a2e1bcf3246371c1fe6f5) Default zip ver to 20 (deflate/encyption), fixes #164 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Writers/Zip/ZipCentralDirectoryEntry.cs` (+1 -1) </details> ### 📄 Description Sets the default level of '20' for zip files in the ZipCentralDirectoryBlock to match '20' used in Zip Local File Headers at https://github.com/adamhathcock/sharpcompress/blob/master/src/SharpCompress/Writers/Zip/ZipWriter.cs#L162 This makes Microsoft's compression.io library used by NuGet happy (and possibly some other tools) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:18:12 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#918
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?