starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #274] [MERGED] Made ArchiveEncoding a non-static class that is used with options. #939

New Issue
Open
opened 2026-01-29 22:18:17 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:18:17 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/274
Author: @adamhathcock
Created: 7/10/2017
Status: ✅ Merged
Merged: 7/17/2017
Merged by: @adamhathcock

Base: master ← Head: issue-268

📝 Commits (3)

  • 8d17b1e Made ArchiveEncoding a non-static class that is used with options.
  • 3b042b2 Revert some formatting.
  • 86b3c55 Optional string decoder delegate (#278)

📊 Changes

40 files changed (+282 additions, -242 deletions)

View changed files

📝 src/SharpCompress/Archives/GZip/GZipArchive.cs (+1 -1)
📝 src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs (+1 -1)
📝 src/SharpCompress/Archives/Tar/TarArchive.cs (+3 -3)
📝 src/SharpCompress/Archives/Zip/ZipArchive.cs (+4 -4)
📝 src/SharpCompress/Common/ArchiveEncoding.cs (+43 -6)
📝 src/SharpCompress/Common/FilePart.cs (+7 -0)
📝 src/SharpCompress/Common/GZip/GZipEntry.cs (+2 -2)
📝 src/SharpCompress/Common/GZip/GZipFilePart.cs (+12 -13)
📝 src/SharpCompress/Common/OptionsBase.cs (+2 -3)
📝 src/SharpCompress/Common/Rar/Headers/FileHeader.cs (+2 -8)
📝 src/SharpCompress/Common/Rar/Headers/RarHeader.cs (+4 -2)
📝 src/SharpCompress/Common/Rar/Headers/RarHeaderFactory.cs (+1 -3)
📝 src/SharpCompress/Common/Rar/RarFilePart.cs (+1 -0)
📝 src/SharpCompress/Common/SevenZip/SevenZipFilePart.cs (+14 -13)
📝 src/SharpCompress/Common/Tar/Headers/TarHeader.cs (+12 -7)
📝 src/SharpCompress/Common/Tar/TarEntry.cs (+2 -2)
📝 src/SharpCompress/Common/Tar/TarFilePart.cs (+6 -5)
📝 src/SharpCompress/Common/Tar/TarHeaderFactory.cs (+2 -5)
📝 src/SharpCompress/Common/Zip/Headers/DirectoryEntryHeader.cs (+4 -4)
📝 src/SharpCompress/Common/Zip/Headers/LocalEntryHeader.cs (+3 -3)

...and 20 more files

📄 Description

Fixes https://github.com/adamhathcock/sharpcompress/issues/268

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/274 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 7/10/2017 **Status:** ✅ Merged **Merged:** 7/17/2017 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `issue-268` --- ### 📝 Commits (3) - [`8d17b1e`](https://github.com/adamhathcock/sharpcompress/commit/8d17b1e38436475b56c1cba1ad221064e5927e9f) Made ArchiveEncoding a non-static class that is used with options. - [`3b042b2`](https://github.com/adamhathcock/sharpcompress/commit/3b042b26cb25045b931563585983f645aff1a9e7) Revert some formatting. - [`86b3c55`](https://github.com/adamhathcock/sharpcompress/commit/86b3c5547213f089cece7054d68618e26f188be0) Optional string decoder delegate (#278) ### 📊 Changes **40 files changed** (+282 additions, -242 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/GZip/GZipArchive.cs` (+1 -1) 📝 `src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs` (+1 -1) 📝 `src/SharpCompress/Archives/Tar/TarArchive.cs` (+3 -3) 📝 `src/SharpCompress/Archives/Zip/ZipArchive.cs` (+4 -4) 📝 `src/SharpCompress/Common/ArchiveEncoding.cs` (+43 -6) 📝 `src/SharpCompress/Common/FilePart.cs` (+7 -0) 📝 `src/SharpCompress/Common/GZip/GZipEntry.cs` (+2 -2) 📝 `src/SharpCompress/Common/GZip/GZipFilePart.cs` (+12 -13) 📝 `src/SharpCompress/Common/OptionsBase.cs` (+2 -3) 📝 `src/SharpCompress/Common/Rar/Headers/FileHeader.cs` (+2 -8) 📝 `src/SharpCompress/Common/Rar/Headers/RarHeader.cs` (+4 -2) 📝 `src/SharpCompress/Common/Rar/Headers/RarHeaderFactory.cs` (+1 -3) 📝 `src/SharpCompress/Common/Rar/RarFilePart.cs` (+1 -0) 📝 `src/SharpCompress/Common/SevenZip/SevenZipFilePart.cs` (+14 -13) 📝 `src/SharpCompress/Common/Tar/Headers/TarHeader.cs` (+12 -7) 📝 `src/SharpCompress/Common/Tar/TarEntry.cs` (+2 -2) 📝 `src/SharpCompress/Common/Tar/TarFilePart.cs` (+6 -5) 📝 `src/SharpCompress/Common/Tar/TarHeaderFactory.cs` (+2 -5) 📝 `src/SharpCompress/Common/Zip/Headers/DirectoryEntryHeader.cs` (+4 -4) 📝 `src/SharpCompress/Common/Zip/Headers/LocalEntryHeader.cs` (+3 -3) _...and 20 more files_ </details> ### 📄 Description Fixes https://github.com/adamhathcock/sharpcompress/issues/268 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:18:17 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#939
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?