starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #272] [MERGED] Don't skip ZipReader data twice. #940

New Issue
Open
opened 2026-01-29 22:18:17 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:18:17 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/272
Author: @adamhathcock
Created: 7/8/2017
Status: ✅ Merged
Merged: 7/17/2017
Merged by: @adamhathcock

Base: master ← Head: issue-269

📝 Commits (3)

  • c0b8289 Don't skip ZipReader data twice.
  • 198e74a Add archive for a new test
  • dab0509 Merge branch 'master' into issue-269

📊 Changes

5 files changed (+29 additions, -2 deletions)

View changed files

📝 src/SharpCompress/Common/FilePart.cs (+1 -0)
📝 src/SharpCompress/Common/Zip/StreamingZipFilePart.cs (+2 -1)
📝 src/SharpCompress/Readers/AbstractReader.cs (+3 -1)
📝 tests/SharpCompress.Test/Zip/ZipReaderTests.cs (+23 -0)
➕ tests/TestArchives/Archives/PrePostHeaders.zip (+0 -0)

📄 Description

This could occur when a zip file has a normal file header AND a post descriptor.

Fixes https://github.com/adamhathcock/sharpcompress/issues/269

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/272 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 7/8/2017 **Status:** ✅ Merged **Merged:** 7/17/2017 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `issue-269` --- ### 📝 Commits (3) - [`c0b8289`](https://github.com/adamhathcock/sharpcompress/commit/c0b8289363b7297c38c2d6e15102d423fb6993c4) Don't skip ZipReader data twice. - [`198e74a`](https://github.com/adamhathcock/sharpcompress/commit/198e74ab173fcf320a9b97accc0f348806b88bbd) Add archive for a new test - [`dab0509`](https://github.com/adamhathcock/sharpcompress/commit/dab050981e9cd25cc25c0cb51432a4accef86cc2) Merge branch 'master' into issue-269 ### 📊 Changes **5 files changed** (+29 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/FilePart.cs` (+1 -0) 📝 `src/SharpCompress/Common/Zip/StreamingZipFilePart.cs` (+2 -1) 📝 `src/SharpCompress/Readers/AbstractReader.cs` (+3 -1) 📝 `tests/SharpCompress.Test/Zip/ZipReaderTests.cs` (+23 -0) ➕ `tests/TestArchives/Archives/PrePostHeaders.zip` (+0 -0) </details> ### 📄 Description This could occur when a zip file has a normal file header AND a post descriptor. Fixes https://github.com/adamhathcock/sharpcompress/issues/269 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:18:17 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#940
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?