starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #337] Added ability to leave tar archive open after stream is closed #975

New Issue
Closed
opened 2026-01-29 22:18:26 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:18:26 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/adamhathcock/sharpcompress/pull/337

State: closed
Merged: Yes

I'm not sure if this flag should be included in WriterOptions since no other archives could support it. Moreover zip archive also has finalization logic but there is no sense to leave it open since it is not possible to resume zip archive writing (correct me if I'm wrong and I'll move this flag to WriterOptions).

If there are no objections with this approach - I'll add tests for these changes.
Related to #323

**Original Pull Request:** https://github.com/adamhathcock/sharpcompress/pull/337 **State:** closed **Merged:** Yes --- I'm not sure if this flag should be included in WriterOptions since no other archives could support it. Moreover zip archive also has finalization logic but there is no sense to leave it open since it is not possible to resume zip archive writing (correct me if I'm wrong and I'll move this flag to WriterOptions). If there are no objections with this approach - I'll add tests for these changes. Related to #323
claunia added the pull-request label 2026-01-29 22:18:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#975
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?