[PR #369] [MERGED] Rework LeaveOpen to be consistent #989

New Issue

Closed

opened 2026-01-29 22:18:30 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 22:18:30 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/369
Author: @adamhathcock
Created: 4/22/2018
Status: ✅ Merged
Merged: 5/5/2018
Merged by: @adamhathcock

Base: master ← Head: leaveOpen

---

📝 Commits (9)

• e919c99 First pass of removing explicit leaveOpen on streams.
• f18e5b7 Archives set up correctly
• bf58742 rework of leave stream open for readers
• 68a5e47 More testing of file handling
• 89ae8ca Rejigger read only substream
• 33f7258 Merge branch 'master' into leaveOpen
• fafd8da Merge branch 'master' into leaveOpen
• e9d0fb8 Merge branch 'master' into leaveOpen
• 9a9d64b Merge branch 'master' into leaveOpen

📊 Changes

32 files changed (+169 additions, -169 deletions)

View changed files

📝 src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs (+1 -1)
📝 src/SharpCompress/Common/GZip/GZipFilePart.cs (+1 -1)
📝 src/SharpCompress/Common/SevenZip/SevenZipFilePart.cs (+0 -1)
📝 src/SharpCompress/Common/Volume.cs (+7 -3)
📝 src/SharpCompress/Common/Zip/ZipFilePart.cs (+1 -1)
📝 src/SharpCompress/Compressors/BZip2/BZip2Stream.cs (+5 -6)
📝 src/SharpCompress/Compressors/BZip2/CBZip2InputStream.cs (+5 -20)
📝 src/SharpCompress/Compressors/BZip2/CBZip2OutputStream.cs (+5 -15)
📝 src/SharpCompress/Compressors/Deflate/DeflateStream.cs (+3 -5)
📝 src/SharpCompress/Compressors/Deflate/GZipStream.cs (+4 -10)
📝 src/SharpCompress/Compressors/Deflate/ZlibBaseStream.cs (+1 -7)
📝 src/SharpCompress/Compressors/Deflate/ZlibStream.cs (+6 -12)
📝 src/SharpCompress/Compressors/Deflate64/Deflate64Stream.cs (+9 -11)
📝 src/SharpCompress/Compressors/LZMA/LZipStream.cs (+3 -8)
📝 src/SharpCompress/Compressors/Rar/MultiVolumeReadOnlyStream.cs (+1 -9)
📝 src/SharpCompress/IO/NonDisposingStream.cs (+11 -4)
📝 src/SharpCompress/IO/ReadOnlySubStream.cs (+2 -12)
📝 src/SharpCompress/Readers/AbstractReader.cs (+6 -14)
📝 src/SharpCompress/Readers/GZip/GZipReader.cs (+1 -1)
📝 src/SharpCompress/Readers/Rar/MultiVolumeRarReader.cs (+1 -1)

...and 12 more files

📄 Description

Use NonDisposingStream to prevent closing of streams.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/369 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 4/22/2018 **Status:** ✅ Merged **Merged:** 5/5/2018 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `leaveOpen` --- ### 📝 Commits (9) - [`e919c99`](https://github.com/adamhathcock/sharpcompress/commit/e919c99b14b0e0e333afa91d7d55965f72edb679) First pass of removing explicit leaveOpen on streams. - [`f18e5b7`](https://github.com/adamhathcock/sharpcompress/commit/f18e5b75bbf5c9167b1808b36aa1191436605970) Archives set up correctly - [`bf58742`](https://github.com/adamhathcock/sharpcompress/commit/bf58742ddffb0252e15f4804f4c29a822027b536) rework of leave stream open for readers - [`68a5e47`](https://github.com/adamhathcock/sharpcompress/commit/68a5e474a6a96a0f74e185a33e633223c7f7812c) More testing of file handling - [`89ae8ca`](https://github.com/adamhathcock/sharpcompress/commit/89ae8ca5260cea5efeead1deacfd0836e9ec14e3) Rejigger read only substream - [`33f7258`](https://github.com/adamhathcock/sharpcompress/commit/33f7258ea2313d8f960b777cb399d9cbfda04dc9) Merge branch 'master' into leaveOpen - [`fafd8da`](https://github.com/adamhathcock/sharpcompress/commit/fafd8da91d6d9cc507d0f3837a8f43550637adf7) Merge branch 'master' into leaveOpen - [`e9d0fb8`](https://github.com/adamhathcock/sharpcompress/commit/e9d0fb85ac7714d81864700950fd0ee2c0635579) Merge branch 'master' into leaveOpen - [`9a9d64b`](https://github.com/adamhathcock/sharpcompress/commit/9a9d64bcbe5e140dd6c0c7cca59508b4d1e01610) Merge branch 'master' into leaveOpen ### 📊 Changes **32 files changed** (+169 additions, -169 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs` (+1 -1) 📝 `src/SharpCompress/Common/GZip/GZipFilePart.cs` (+1 -1) 📝 `src/SharpCompress/Common/SevenZip/SevenZipFilePart.cs` (+0 -1) 📝 `src/SharpCompress/Common/Volume.cs` (+7 -3) 📝 `src/SharpCompress/Common/Zip/ZipFilePart.cs` (+1 -1) 📝 `src/SharpCompress/Compressors/BZip2/BZip2Stream.cs` (+5 -6) 📝 `src/SharpCompress/Compressors/BZip2/CBZip2InputStream.cs` (+5 -20) 📝 `src/SharpCompress/Compressors/BZip2/CBZip2OutputStream.cs` (+5 -15) 📝 `src/SharpCompress/Compressors/Deflate/DeflateStream.cs` (+3 -5) 📝 `src/SharpCompress/Compressors/Deflate/GZipStream.cs` (+4 -10) 📝 `src/SharpCompress/Compressors/Deflate/ZlibBaseStream.cs` (+1 -7) 📝 `src/SharpCompress/Compressors/Deflate/ZlibStream.cs` (+6 -12) 📝 `src/SharpCompress/Compressors/Deflate64/Deflate64Stream.cs` (+9 -11) 📝 `src/SharpCompress/Compressors/LZMA/LZipStream.cs` (+3 -8) 📝 `src/SharpCompress/Compressors/Rar/MultiVolumeReadOnlyStream.cs` (+1 -9) 📝 `src/SharpCompress/IO/NonDisposingStream.cs` (+11 -4) 📝 `src/SharpCompress/IO/ReadOnlySubStream.cs` (+2 -12) 📝 `src/SharpCompress/Readers/AbstractReader.cs` (+6 -14) 📝 `src/SharpCompress/Readers/GZip/GZipReader.cs` (+1 -1) 📝 `src/SharpCompress/Readers/Rar/MultiVolumeRarReader.cs` (+1 -1) _...and 12 more files_ </details> ### 📄 Description Use NonDisposingStream to prevent closing of streams. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 22:18:30 +00:00

claunia closed this issue 2026-01-29 22:18:30 +00:00

claunia referenced this issue 2026-01-29 22:20:25 +00:00

[PR #989] [MERGED] Add support for empty directory entries in archives #1409

claunia referenced this issue 2026-01-29 22:20:26 +00:00

[PR #989] Add support for empty directory entries in archives #1412

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

release

adam/merge-release-to-master

dependabot/nuget/xunit.v3-3.2.2

adam/more-explode-async

copilot/fix-infinite-loop-rar-archive

adam/data-descriptor-fix

adam/fix-tests-with-proper-rewind

copilot/fix-data-descriptor-stream-bug

adam/lmza-investigation

adam/create-rar-async

adam/async-rar2

copilot/support-multi-threading-path

copilot/sub-pr-1132-again

adam/memory-perf

copilot/add-performance-benchmarking

copilot/sub-pr-1121

copilot/add-password-support-zip-files

copilot/add-so-optimized-zip-support

adam/rar-async-only

copilot/add-buffered-stream-async-read

copilot/sub-pr-1076

copilot/fix-decompression-exception

copilot/fix-archivefactory-issue

copilot/rationalize-sourcestream-volumes

adam/open-async

copilot/add-ace-archive-support

copilot/sub-pr-1040-again

adam/more-async-3

copilot/fix-tararchive-incomplete-iteration

adam/multi-threaded

copilot/sub-pr-1040

adam/awesome-copilot

copilot/fix-ziparchive-extraction-issue

copilot/fix-tararchive-open-crash

copilot/fix-tar-xz-file-reading-issue

copilot/setup-copilot-instructions

copilot/fix-decompression-performance-issue

copilot/convert-stream-access-to-async

adam/enable-agent

adam/async-deflate

adam/async-rar

adam/more-cleanup

adam/zstd

async-2

zstandard

net461-tests

dmg

async

build-netcore3

recycle-memory-stream

presentation

pax

netcore2

zip_encryption

dotnet-tool

tar_redux

native_zlib

Issue-197

system_buffers

TarNames

7zip_sfx

portable_crypto

WinRT

new_7zip

0.44.5

0.44.4

0.44.3

0.44.2

0.44.1

0.44.0

0.43.0

0.42.1

0.42.0

0.41.0

0.40.0

0.39.0

0.38.0

0.37.2

0.37.1

0.37.0

0.36.0

0.35.0

0.34.2

0.34.1

0.34.0

0.33.0

0.32.2

0.32.1

0.32

0.31

0.30.1

0.30

0.29

0.29.0

0.28.3

0.28.2

0.28.1

0.28

0.27.1

0.27

0.26

0.25.1

0.25

0.24

0.23

0.22

0.21.1

0.21

0.21.0

0.20.0

0.19.2

0.19.1

0.19

0.18.2

0.18.1

0.18

0.17.1

0.17.0

0.16.2

0.16.1

0.16.0

0.15.2

0.15.1

0.15.0

0.14.1

0.14.0

0.13.1

0.13.0

0.12.4

0.12.3

0.12.2

0.12.1

0.12.0

0.11.6

0.11.5

0.11.4

0.11.3

0.11.2

0.11.1

0.11

0.10.3

0.10.2

0.10.1.3

0.10.1.2

0.10.1.1

0.10.1

0.10

0.9

Labels

Clear labels

bug

duplicate

enhancement

feedback requested

not bug

pull-request

Mirrored from GitHub Pull Request

question

up for grabs

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/sharpcompress#989