starred/terminal-microsoft-1
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 17:56:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use float instead of double by default (#17100)

Browse Source 
While `double` is probably generally preferable for UI code,
our application is essentially a complex wrapper wrapper around
DWrite, D2D and D3D, all of which use `float` exclusively.

Of course it also uses XAML, but that one uses `float` for roughly
1/3rd of its API functions, so I'm not sure what it prefers.
Additionally, it's mostly a coincidence that we use WinUI/XAML for
Windows Terminal whereas DWrite/D2D/D3D are effectively essential.
This is demonstrated by the fact that we have a `HwndTerminal`,
while there's no alternative to e.g. D3D on Windows.

The goal of this PR is that DIP based calculations never end up
mixing `float` and `double`. This PR also changes opacity-related
values to `float` because I felt like that fits the theme.
This commit is contained in:
Leonard Hecker
2024-04-23 02:07:00 +02:00
committed by GitHub
parent f49cf44b79
commit 99061ee272
45 changed files with 180 additions and 178 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
src/cascadia/UnitTests_Control/ControlCoreTests.cpp
View File

@@ -137,14 +137,14 @@ namespace ControlUnitTests
VERIFY_IS_NOT_NULL(core);
// A callback to make sure that we're raising TransparencyChanged events
auto expectedOpacity = 0.5;
auto expectedOpacity = 0.5f;
auto opacityCallback = [&](auto&&, Control::TransparencyChangedEventArgs args) mutable {
VERIFY_ARE_EQUAL(expectedOpacity, args.Opacity());
VERIFY_ARE_EQUAL(expectedOpacity, core->Opacity());
// The Settings object's opacity shouldn't be changed
VERIFY_ARE_EQUAL(0.5, settings->Opacity());
VERIFY_ARE_EQUAL(0.5f, settings->Opacity());
if (expectedOpacity < 1.0)
if (expectedOpacity < 1.0f)
{
VERIFY_IS_TRUE(settings->UseAcrylic());
VERIFY_IS_TRUE(core->_settings->UseAcrylic());
@@ -153,7 +153,7 @@ namespace ControlUnitTests
// GH#603: Adjusting opacity shouldn't change whether or not we
// requested acrylic.
auto expectedUseAcrylic = expectedOpacity < 1.0;
auto expectedUseAcrylic = expectedOpacity < 1.0f;
VERIFY_IS_TRUE(core->_settings->UseAcrylic());
VERIFY_ARE_EQUAL(expectedUseAcrylic, core->UseAcrylic());
};
@@ -166,39 +166,39 @@ namespace ControlUnitTests
VERIFY_IS_TRUE(core->_initializedTerminal);
Log::Comment(L"Increasing opacity till fully opaque");
expectedOpacity += 0.1; // = 0.6;
core->AdjustOpacity(0.1);
expectedOpacity += 0.1; // = 0.7;
core->AdjustOpacity(0.1);
expectedOpacity += 0.1; // = 0.8;
core->AdjustOpacity(0.1);
expectedOpacity += 0.1; // = 0.9;
core->AdjustOpacity(0.1);
expectedOpacity += 0.1; // = 1.0;
expectedOpacity += 0.1f; // = 0.6;
core->AdjustOpacity(0.1f);
expectedOpacity += 0.1f; // = 0.7;
core->AdjustOpacity(0.1f);
expectedOpacity += 0.1f; // = 0.8;
core->AdjustOpacity(0.1f);
expectedOpacity += 0.1f; // = 0.9;
core->AdjustOpacity(0.1f);
expectedOpacity += 0.1f; // = 1.0;
// cast to float because floating point numbers are mean
VERIFY_ARE_EQUAL(1.0f, base::saturated_cast<float>(expectedOpacity));
core->AdjustOpacity(0.1);
VERIFY_ARE_EQUAL(1.0f, expectedOpacity);
core->AdjustOpacity(0.1f);
Log::Comment(L"Increasing opacity more doesn't actually change it to be >1.0");
expectedOpacity = 1.0;
core->AdjustOpacity(0.1);
expectedOpacity = 1.0f;
core->AdjustOpacity(0.1f);
Log::Comment(L"Decrease opacity");
expectedOpacity -= 0.25; // = 0.75;
core->AdjustOpacity(-0.25);
expectedOpacity -= 0.25; // = 0.5;
core->AdjustOpacity(-0.25);
expectedOpacity -= 0.25; // = 0.25;
core->AdjustOpacity(-0.25);
expectedOpacity -= 0.25; // = 0.05;
expectedOpacity -= 0.25f; // = 0.75;
core->AdjustOpacity(-0.25f);
expectedOpacity -= 0.25f; // = 0.5;
core->AdjustOpacity(-0.25f);
expectedOpacity -= 0.25f; // = 0.25;
core->AdjustOpacity(-0.25f);
expectedOpacity -= 0.25f; // = 0.05;
// cast to float because floating point numbers are mean
VERIFY_ARE_EQUAL(0.0f, base::saturated_cast<float>(expectedOpacity));
core->AdjustOpacity(-0.25);
VERIFY_ARE_EQUAL(0.0f, expectedOpacity);
core->AdjustOpacity(-0.25f);
Log::Comment(L"Decreasing opacity more doesn't actually change it to be < 0");
expectedOpacity = 0.0;
core->AdjustOpacity(-0.25);
expectedOpacity = 0.0f;
core->AdjustOpacity(-0.25f);
}
void ControlCoreTests::TestFreeAfterClose()