starred/terminal-microsoft-1
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 01:04:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

sgr: consider ITU T.416 colors with color space 0 valid (#19768)

Browse Source 
This PR fixes an issue where SGR color sequences containing a Color
Space ID of 0 (e.g., \e[38:2:0:r:g:bm) were incorrectly rejected as
invalid.

According to ITU T.416, the Color Space ID parameter is defined, and a
value of 0 is implementation-defined. It is widely accepted by other
terminal emulators (like XTerm) as the default RGB color space. This
change modifies the check to explicitly allow an ID of 0 while still
rejecting other non-standard IDs, ensuring compatibility with tools that
emit fully qualified T.416 sequences.

Closes #19547
This commit is contained in:
Vallabh Mahajan
2026-01-23 22:51:55 +05:30
committed by GitHub
parent 8d94edd7b0
commit c8549bebed
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/terminal/adapter/adaptDispatchGraphics.cpp
View File

@@ -125,10 +125,10 @@ void AdaptDispatch::_SetRgbColorsHelperFromSubParams(const VTParameter colorItem
// sub params are in the order: // sub params are in the order:
// :2:<color-space-id>:<r>:<g>:<b> // :2:<color-space-id>:<r>:<g>:<b>
// We treat a color as invalid if it has a non-empty color space ID, as // We treat a color as invalid if it has a non-zero color space ID, as
// some applications that support non-standard ODA color sequence might // some applications that support non-standard ODA color sequence might
// send the red value in its place. // send the red value in its place.
const bool hasColorSpaceId = options.at(1).has_value(); const bool validColorSpace = options.at(1).value_or(0) == 0;
const size_t red = options.at(2).value_or(0); const size_t red = options.at(2).value_or(0);
const size_t green = options.at(3).value_or(0); const size_t green = options.at(3).value_or(0);
@@ -136,7 +136,7 @@ void AdaptDispatch::_SetRgbColorsHelperFromSubParams(const VTParameter colorItem
// We only apply the color if the R, G, B values fit within a byte. // We only apply the color if the R, G, B values fit within a byte.
// This is to match XTerm's and VTE's behavior. // This is to match XTerm's and VTE's behavior.
if (!hasColorSpaceId && red <= 255 && green <= 255 && blue <= 255) if (validColorSpace && red <= 255 && green <= 255 && blue <= 255)
{ {
applyColor(TextColor{ RGB(red, green, blue) }); applyColor(TextColor{ RGB(red, green, blue) });
} }