From fd1b1c35b400b75df9aa510ff6f61838987c0b67 Mon Sep 17 00:00:00 2001 From: Mike Griese Date: Wed, 21 Aug 2024 17:07:06 -0500 Subject: [PATCH] Set the default for `autoMarkPrompts` to `true` (#17761) As we discussed in bug bash. There's really no downside to us enabling it by default (and leaving showMarksOnScrollbar: false). It'll mark lines as "prompts" when the user hits enter. This will have a couple good side effects: * When folks have right-aligned prompts (like, from oh-my-posh), the `enter` will terminate where shell integration thinks the command is, so that the right-prompt doesn't end up in the commandline history * the scrollToMark actions will Just Work without any other shell integration Closes #17632 --- doc/cascadia/profiles.schema.json | 2 +- src/cascadia/TerminalSettingsModel/MTSMSettings.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/cascadia/profiles.schema.json b/doc/cascadia/profiles.schema.json index defe63d150..325e73f2d0 100644 --- a/doc/cascadia/profiles.schema.json +++ b/doc/cascadia/profiles.schema.json @@ -2855,7 +2855,7 @@ } }, "autoMarkPrompts": { - "default": false, + "default": true, "description": "When set to true, prompts will automatically be marked.", "type": "boolean" }, diff --git a/src/cascadia/TerminalSettingsModel/MTSMSettings.h b/src/cascadia/TerminalSettingsModel/MTSMSettings.h index 397a852c58..85e091077a 100644 --- a/src/cascadia/TerminalSettingsModel/MTSMSettings.h +++ b/src/cascadia/TerminalSettingsModel/MTSMSettings.h @@ -95,7 +95,7 @@ Author(s): X(bool, RightClickContextMenu, "experimental.rightClickContextMenu", false) \ X(Windows::Foundation::Collections::IVector, BellSound, "bellSound", nullptr) \ X(bool, Elevate, "elevate", false) \ - X(bool, AutoMarkPrompts, "autoMarkPrompts", false) \ + X(bool, AutoMarkPrompts, "autoMarkPrompts", true) \ X(bool, ShowMarks, "showMarksOnScrollbar", false) \ X(bool, RepositionCursorWithMouse, "experimental.repositionCursorWithMouse", false) \ X(bool, ReloadEnvironmentVariables, "compatibility.reloadEnvironmentVariables", true) \