terminal-microsoft

mirror of https://github.com/microsoft/terminal.git synced 2026-04-05 21:44:31 +00:00

Files

Vallabh Mahajan 69e4590bc5 Add setting for customizable delimiter for file drag-and-drop (#19799 )

## Summary of the Pull Request
This PR introduces a new profile setting, `dragDropDelimiter`, which
allows users to configure the string separator used when dragging and
dropping multiple files into the terminal. The default behavior remains
a single space (`" "`) for backward compatibility.

## References and Relevant Issues
* Closes #19565

## Detailed Description of the Pull Request / Additional comments
**Implementation Details:**
* **Settings:** Added `DragDropDelimiter` to `MTSMSettings.h` and
`Profile.idl`.
* **Control:** Wired the setting through `ControlProperties.h` so the
terminal logic can see it.
* **Logic:** Updated `TermControl::OnDrop` to use the new delimiter when
joining paths.
* **UI:** Added the text box in the Advanced Settings page and updated
the ViewModel.

## Validation Steps Performed
* **Manual Verification:**
    * Verified default behavior (space separator) works as before.
* Configured `dragDropDelimiter` to `", "`, `";"`, and custom strings in
`settings.json` and from settings UI.
    * Confirmed dropped files are joined correctly.
* **Build:** Validated that the solution builds cleanly.

## Notes for Reviewers
1. **Delimiter Length:** Currently, there is no limit on the maximum
length of the delimiter string. Let me know if this should be changed.
3.  **Localization:** I changed only `Resources/en-US` file.
4. **ViewModel:** In `ProfileViewModel.cpp`, I added the `else if` block
for the new setting, but left it empty because no other UI logic
currently depends on it.

## PR Checklist
- [x] Closes #19565
- [ ] Documentation updated
- [x] Schema updated (if necessary)

2026-03-30 10:38:01 -07:00

cascadia

Add setting for customizable delimiter for file drag-and-drop (#19799 )

2026-03-30 10:38:01 -07:00

images

Run all images through ImgBot (#8169 )

2020-11-05 18:03:40 -08:00

reference

Fix the spellbot (#8259 )

2020-11-13 09:45:08 -08:00

specs

Fix initial position parsing from -pos tag (#19409 )