From 8ef8e95eb54bc93e2ee47ceb9c39ce46d286c3d9 Mon Sep 17 00:00:00 2001 From: "Dustin L. Howett" Date: Fri, 29 May 2026 12:37:13 -0500 Subject: [PATCH 1/4] meta: add a solution filter that only opens conhost components (#20271) It loads faster, and a full "solution" build produces everything required to run and test conhost. --- .github/actions/spelling/expect/expect.txt | 1 + conhost.slnf | 45 ++++++++++++++++++++++ 2 files changed, 46 insertions(+) create mode 100644 conhost.slnf diff --git a/.github/actions/spelling/expect/expect.txt b/.github/actions/spelling/expect/expect.txt index 56f0bb4211..6d09960c68 100644 --- a/.github/actions/spelling/expect/expect.txt +++ b/.github/actions/spelling/expect/expect.txt @@ -1555,6 +1555,7 @@ SLGP SLIST slmult sln +slnf slnx slpit SManifest diff --git a/conhost.slnf b/conhost.slnf new file mode 100644 index 0000000000..8fdb9eb271 --- /dev/null +++ b/conhost.slnf @@ -0,0 +1,45 @@ +{ + "solution": { + "path": "OpenConsole.slnx", + "projects": [ + "src\\audio\\midi\\lib\\midi.vcxproj", + "src\\buffer\\out\\lib\\bufferout.vcxproj", + "src\\buffer\\out\\ut_textbuffer\\TextBuffer.Unit.Tests.vcxproj", + "src\\host\\exe\\Host.EXE.vcxproj", + "src\\host\\ft_fuzzer\\Host.FuzzWrapper.vcxproj", + "src\\host\\ft_host\\Host.FeatureTests.vcxproj", + "src\\host\\ft_uia\\Host.Tests.UIA.csproj", + "src\\host\\lib\\hostlib.vcxproj", + "src\\host\\proxy\\Host.Proxy.vcxproj", + "src\\host\\ut_host\\Host.UnitTests.vcxproj", + "src\\host\\ut_lib\\host.unittest.vcxproj", + "src\\interactivity\\base\\lib\\InteractivityBase.vcxproj", + "src\\interactivity\\onecore\\lib\\onecore.LIB.vcxproj", + "src\\interactivity\\win32\\lib\\win32.LIB.vcxproj", + "src\\interactivity\\win32\\ut_interactivity_win32\\Interactivity.Win32.UnitTests.vcxproj", + "src\\internal\\internal.vcxproj", + "src\\propsheet\\propsheet.vcxproj", + "src\\propslib\\propslib.vcxproj", + "src\\renderer\\atlas\\atlas.vcxproj", + "src\\renderer\\base\\lib\\base.vcxproj", + "src\\renderer\\gdi\\lib\\gdi.vcxproj", + "src\\renderer\\wddmcon\\lib\\wddmcon.vcxproj", + "src\\server\\lib\\server.vcxproj", + "src\\terminal\\adapter\\lib\\adapter.vcxproj", + "src\\terminal\\adapter\\ut_adapter\\Adapter.UnitTests.vcxproj", + "src\\terminal\\input\\lib\\terminalinput.vcxproj", + "src\\terminal\\parser\\ft_fuzzer\\VTCommandFuzzer.vcxproj", + "src\\terminal\\parser\\ft_fuzzwrapper\\FuzzWrapper.vcxproj", + "src\\terminal\\parser\\lib\\parser.vcxproj", + "src\\terminal\\parser\\ut_parser\\Parser.UnitTests.vcxproj", + "src\\til\\ut_til\\til.unit.tests.vcxproj", + "src\\tools\\nihilist\\Nihilist.vcxproj", + "src\\tsf\\tsf.vcxproj", + "src\\types\\lib\\types.vcxproj", + "src\\types\\ut_types\\Types.Unit.Tests.vcxproj", + "src\\winconpty\\dll\\winconptydll.vcxproj", + "src\\winconpty\\ft_pty\\winconpty.FeatureTests.vcxproj", + "src\\winconpty\\lib\\winconptylib.vcxproj" + ] + } +} \ No newline at end of file From 00e0ecb8b50e45137a6496a3e05028124b4ea7e5 Mon Sep 17 00:00:00 2001 From: Carlos Zamora Date: Fri, 29 May 2026 11:57:00 -0700 Subject: [PATCH 2/4] Add screen reader announcement for opening/closing navigation pane (#20275) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary of the Pull Request Adds a manual event handler for `PaneOpened`/`PaneClosed` on the navigation view in the settings UI. After catching the event, we raise a UIA notification event to force the attached screen reader to read out "Navigation pane opened/closed" appropriately. This experience aligns with WinUI and the text is localized appropriately. ## Validation Steps Performed ✅ Narrator announces "Navigation pane opened/closed" appropriately (aligns with WinUI 3 gallery experience) ## PR Checklist Closes #19687 📝 NOTE: the associated issue is currently affecting our accessibility score --- .../TerminalSettingsEditor/MainPage.cpp | 22 +++++++++++++++++++ .../TerminalSettingsEditor/MainPage.h | 4 ++++ .../TerminalSettingsEditor/MainPage.xaml | 2 ++ .../Resources/en-US/Resources.resw | 8 +++++++ 4 files changed, 36 insertions(+) diff --git a/src/cascadia/TerminalSettingsEditor/MainPage.cpp b/src/cascadia/TerminalSettingsEditor/MainPage.cpp index 7b082ea53c..2f3cd75db0 100644 --- a/src/cascadia/TerminalSettingsEditor/MainPage.cpp +++ b/src/cascadia/TerminalSettingsEditor/MainPage.cpp @@ -381,6 +381,28 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation _setThemeOnPopups(SettingsSearchBox(), requestedTheme); } + void MainPage::_AnnounceNavPaneState(bool opened) + { + if (const auto automationPeer{ Automation::Peers::FrameworkElementAutomationPeer::FromElement(SettingsNav()) }) + { + automationPeer.RaiseNotificationEvent( + Automation::Peers::AutomationNotificationKind::ActionCompleted, + Automation::Peers::AutomationNotificationProcessing::MostRecent, + opened ? RS_(L"Nav_PaneOpenedAnnouncement") : RS_(L"Nav_PaneClosedAnnouncement"), + L"SettingsNavPaneState"); + } + } + + void MainPage::SettingsNav_PaneOpened(const MUX::Controls::NavigationView&, const IInspectable&) + { + _AnnounceNavPaneState(true); + } + + void MainPage::SettingsNav_PaneClosed(const MUX::Controls::NavigationView&, const IInspectable&) + { + _AnnounceNavPaneState(false); + } + // Function Description: // - Called when NavigationView items are invoked. Navigates to the corresponding page. // Arguments: diff --git a/src/cascadia/TerminalSettingsEditor/MainPage.h b/src/cascadia/TerminalSettingsEditor/MainPage.h index 81719751c6..60c11f9a90 100644 --- a/src/cascadia/TerminalSettingsEditor/MainPage.h +++ b/src/cascadia/TerminalSettingsEditor/MainPage.h @@ -56,6 +56,8 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation void SettingsNav_Loaded(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args); void SettingsNav_ItemInvoked(const Microsoft::UI::Xaml::Controls::NavigationView& sender, const Microsoft::UI::Xaml::Controls::NavigationViewItemInvokedEventArgs& args); + void SettingsNav_PaneOpened(const Microsoft::UI::Xaml::Controls::NavigationView& sender, const Windows::Foundation::IInspectable& args); + void SettingsNav_PaneClosed(const Microsoft::UI::Xaml::Controls::NavigationView& sender, const Windows::Foundation::IInspectable& args); void SaveButton_Click(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args); void ResetButton_Click(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args); void BreadcrumbBar_ItemClicked(const Microsoft::UI::Xaml::Controls::BreadcrumbBar& sender, const Microsoft::UI::Xaml::Controls::BreadcrumbBarItemClickedEventArgs& args); @@ -100,6 +102,8 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation void _NavigateToColorSchemeHandler(const IInspectable& sender, const IInspectable& args); Microsoft::UI::Xaml::Controls::NavigationViewItem _FindProfileNavItem(winrt::guid profileGuid) const; + void _AnnounceNavPaneState(bool opened); + void _UpdateBackgroundForMica(); void _MoveXamlParsedNavItemsIntoItemSource(); diff --git a/src/cascadia/TerminalSettingsEditor/MainPage.xaml b/src/cascadia/TerminalSettingsEditor/MainPage.xaml index 27ef0043fb..950295a10c 100644 --- a/src/cascadia/TerminalSettingsEditor/MainPage.xaml +++ b/src/cascadia/TerminalSettingsEditor/MainPage.xaml @@ -68,6 +68,8 @@ IsSettingsVisible="False" ItemInvoked="SettingsNav_ItemInvoked" Loaded="SettingsNav_Loaded" + PaneClosed="SettingsNav_PaneClosed" + PaneOpened="SettingsNav_PaneOpened" TabFocusNavigation="Cycle"> diff --git a/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw index f24f67a0e2..640d67dfd9 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw @@ -669,6 +669,14 @@ Startup Header for the "startup" menu item. This navigates to a page that lets you see and modify settings related to the app's launch experience (i.e. screen position, mode, etc.) + + Navigation pane opened + Screen reader announcement made when the user activates the toggle button that opens the settings navigation pane. + + + Navigation pane closed + Screen reader announcement made when the user activates the toggle button that closes the settings navigation pane. + Open JSON file Header for a menu item. This opens the JSON file that is used to log the app's settings. From 7fc12cf949a148277dd6a7fdbec3d0302b125570 Mon Sep 17 00:00:00 2001 From: Windows Console Service Bot <14666831+consvc@users.noreply.github.com> Date: Fri, 29 May 2026 14:00:30 -0500 Subject: [PATCH 3/4] Localization Updates - "Dropdown Menu" (#20259) Co-authored-by: Console Service Bot --- .../TerminalSettingsEditor/Resources/de-DE/Resources.resw | 4 ++-- .../TerminalSettingsEditor/Resources/es-ES/Resources.resw | 4 ++-- .../TerminalSettingsEditor/Resources/fr-FR/Resources.resw | 4 ++-- .../TerminalSettingsEditor/Resources/it-IT/Resources.resw | 4 ++-- .../TerminalSettingsEditor/Resources/ja-JP/Resources.resw | 4 ++-- .../TerminalSettingsEditor/Resources/ko-KR/Resources.resw | 4 ++-- .../TerminalSettingsEditor/Resources/pt-BR/Resources.resw | 4 ++-- .../TerminalSettingsEditor/Resources/qps-ploc/Resources.resw | 4 ++-- .../TerminalSettingsEditor/Resources/qps-ploca/Resources.resw | 4 ++-- .../TerminalSettingsEditor/Resources/qps-plocm/Resources.resw | 4 ++-- .../TerminalSettingsEditor/Resources/ru-RU/Resources.resw | 4 ++-- .../TerminalSettingsEditor/Resources/zh-CN/Resources.resw | 4 ++-- .../TerminalSettingsEditor/Resources/zh-TW/Resources.resw | 4 ++-- 13 files changed, 26 insertions(+), 26 deletions(-) diff --git a/src/cascadia/TerminalSettingsEditor/Resources/de-DE/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/de-DE/Resources.resw index 3b20dcb8ee..c355ec9e71 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/de-DE/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/de-DE/Resources.resw @@ -2394,8 +2394,8 @@ Accessible name for a control allowing the user to select the icon from a list of built in icons. - Menü „Neue Registerkarte“ - Header for the "new tab menu" menu item. This navigates to a page that lets you see and modify settings related to the app's new tab menu (i.e. profile ordering, nested folders, dividers, etc.) + Dropdownmenü + Header for the "dropdown menu" menu item (formerly "new tab menu"). This navigates to a page that lets you see and modify settings related to the app's dropdown menu (i.e. profile ordering, nested folders, dividers, etc.) <Trennzeichen> diff --git a/src/cascadia/TerminalSettingsEditor/Resources/es-ES/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/es-ES/Resources.resw index 28fc273118..8fc3f89b57 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/es-ES/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/es-ES/Resources.resw @@ -2394,8 +2394,8 @@ Accessible name for a control allowing the user to select the icon from a list of built in icons. - Menú Nueva pestaña - Header for the "new tab menu" menu item. This navigates to a page that lets you see and modify settings related to the app's new tab menu (i.e. profile ordering, nested folders, dividers, etc.) + Menú desplegable + Header for the "dropdown menu" menu item (formerly "new tab menu"). This navigates to a page that lets you see and modify settings related to the app's dropdown menu (i.e. profile ordering, nested folders, dividers, etc.) <Separator> diff --git a/src/cascadia/TerminalSettingsEditor/Resources/fr-FR/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/fr-FR/Resources.resw index 6dbe23803b..0d94de6420 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/fr-FR/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/fr-FR/Resources.resw @@ -2394,8 +2394,8 @@ Accessible name for a control allowing the user to select the icon from a list of built in icons. - Menu Nouvel onglet - Header for the "new tab menu" menu item. This navigates to a page that lets you see and modify settings related to the app's new tab menu (i.e. profile ordering, nested folders, dividers, etc.) + Menu déroulant + Header for the "dropdown menu" menu item (formerly "new tab menu"). This navigates to a page that lets you see and modify settings related to the app's dropdown menu (i.e. profile ordering, nested folders, dividers, etc.) <Separator> diff --git a/src/cascadia/TerminalSettingsEditor/Resources/it-IT/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/it-IT/Resources.resw index 72778d4534..4eb29a8e06 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/it-IT/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/it-IT/Resources.resw @@ -2394,8 +2394,8 @@ Accessible name for a control allowing the user to select the icon from a list of built in icons. - Menu Nuova scheda - Header for the "new tab menu" menu item. This navigates to a page that lets you see and modify settings related to the app's new tab menu (i.e. profile ordering, nested folders, dividers, etc.) + Menu a discesa + Header for the "dropdown menu" menu item (formerly "new tab menu"). This navigates to a page that lets you see and modify settings related to the app's dropdown menu (i.e. profile ordering, nested folders, dividers, etc.) <Separator> diff --git a/src/cascadia/TerminalSettingsEditor/Resources/ja-JP/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/ja-JP/Resources.resw index 7ac0c6cc8e..0b2d07a0bc 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/ja-JP/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/ja-JP/Resources.resw @@ -2394,8 +2394,8 @@ Accessible name for a control allowing the user to select the icon from a list of built in icons. - 新しいタブ メニュー - Header for the "new tab menu" menu item. This navigates to a page that lets you see and modify settings related to the app's new tab menu (i.e. profile ordering, nested folders, dividers, etc.) + ドロップダウン メニュー + Header for the "dropdown menu" menu item (formerly "new tab menu"). This navigates to a page that lets you see and modify settings related to the app's dropdown menu (i.e. profile ordering, nested folders, dividers, etc.) <区切り> diff --git a/src/cascadia/TerminalSettingsEditor/Resources/ko-KR/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/ko-KR/Resources.resw index cd4e601694..65175f6296 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/ko-KR/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/ko-KR/Resources.resw @@ -2394,8 +2394,8 @@ Accessible name for a control allowing the user to select the icon from a list of built in icons. - 새 탭 메뉴 - Header for the "new tab menu" menu item. This navigates to a page that lets you see and modify settings related to the app's new tab menu (i.e. profile ordering, nested folders, dividers, etc.) + 드롭다운 메뉴 + Header for the "dropdown menu" menu item (formerly "new tab menu"). This navigates to a page that lets you see and modify settings related to the app's dropdown menu (i.e. profile ordering, nested folders, dividers, etc.) <구분 기호> diff --git a/src/cascadia/TerminalSettingsEditor/Resources/pt-BR/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/pt-BR/Resources.resw index 7d52d28450..bcb7cb4561 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/pt-BR/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/pt-BR/Resources.resw @@ -2394,8 +2394,8 @@ Accessible name for a control allowing the user to select the icon from a list of built in icons. - Menu nova guia - Header for the "new tab menu" menu item. This navigates to a page that lets you see and modify settings related to the app's new tab menu (i.e. profile ordering, nested folders, dividers, etc.) + Menu Suspenso + Header for the "dropdown menu" menu item (formerly "new tab menu"). This navigates to a page that lets you see and modify settings related to the app's dropdown menu (i.e. profile ordering, nested folders, dividers, etc.) <Separador> diff --git a/src/cascadia/TerminalSettingsEditor/Resources/qps-ploc/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/qps-ploc/Resources.resw index cdf6c6bf63..bc56d35cb6 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/qps-ploc/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/qps-ploc/Resources.resw @@ -2398,8 +2398,8 @@ Accessible name for a control allowing the user to select the icon from a list of built in icons. - Ŋēẁ Ťãь Μëηΰ !!! - Header for the "new tab menu" menu item. This navigates to a page that lets you see and modify settings related to the app's new tab menu (i.e. profile ordering, nested folders, dividers, etc.) + Ďřόφďőŵⁿ Мεήΰ !!! + Header for the "dropdown menu" menu item (formerly "new tab menu"). This navigates to a page that lets you see and modify settings related to the app's dropdown menu (i.e. profile ordering, nested folders, dividers, etc.) <Šєрαяāτоŕ> !!! diff --git a/src/cascadia/TerminalSettingsEditor/Resources/qps-ploca/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/qps-ploca/Resources.resw index cdf6c6bf63..bc56d35cb6 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/qps-ploca/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/qps-ploca/Resources.resw @@ -2398,8 +2398,8 @@ Accessible name for a control allowing the user to select the icon from a list of built in icons. - Ŋēẁ Ťãь Μëηΰ !!! - Header for the "new tab menu" menu item. This navigates to a page that lets you see and modify settings related to the app's new tab menu (i.e. profile ordering, nested folders, dividers, etc.) + Ďřόφďőŵⁿ Мεήΰ !!! + Header for the "dropdown menu" menu item (formerly "new tab menu"). This navigates to a page that lets you see and modify settings related to the app's dropdown menu (i.e. profile ordering, nested folders, dividers, etc.) <Šєрαяāτоŕ> !!! diff --git a/src/cascadia/TerminalSettingsEditor/Resources/qps-plocm/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/qps-plocm/Resources.resw index cdf6c6bf63..bc56d35cb6 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/qps-plocm/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/qps-plocm/Resources.resw @@ -2398,8 +2398,8 @@ Accessible name for a control allowing the user to select the icon from a list of built in icons. - Ŋēẁ Ťãь Μëηΰ !!! - Header for the "new tab menu" menu item. This navigates to a page that lets you see and modify settings related to the app's new tab menu (i.e. profile ordering, nested folders, dividers, etc.) + Ďřόφďőŵⁿ Мεήΰ !!! + Header for the "dropdown menu" menu item (formerly "new tab menu"). This navigates to a page that lets you see and modify settings related to the app's dropdown menu (i.e. profile ordering, nested folders, dividers, etc.) <Šєрαяāτоŕ> !!! diff --git a/src/cascadia/TerminalSettingsEditor/Resources/ru-RU/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/ru-RU/Resources.resw index 2ed9ed275d..36aa4e64e2 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/ru-RU/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/ru-RU/Resources.resw @@ -2394,8 +2394,8 @@ Accessible name for a control allowing the user to select the icon from a list of built in icons. - Меню “Новая вкладка” - Header for the "new tab menu" menu item. This navigates to a page that lets you see and modify settings related to the app's new tab menu (i.e. profile ordering, nested folders, dividers, etc.) + Раскрывающееся меню + Header for the "dropdown menu" menu item (formerly "new tab menu"). This navigates to a page that lets you see and modify settings related to the app's dropdown menu (i.e. profile ordering, nested folders, dividers, etc.) <Разделитель> diff --git a/src/cascadia/TerminalSettingsEditor/Resources/zh-CN/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/zh-CN/Resources.resw index 9b5a5fab20..cc87433121 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/zh-CN/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/zh-CN/Resources.resw @@ -2394,8 +2394,8 @@ Accessible name for a control allowing the user to select the icon from a list of built in icons. - 新选项卡菜单 - Header for the "new tab menu" menu item. This navigates to a page that lets you see and modify settings related to the app's new tab menu (i.e. profile ordering, nested folders, dividers, etc.) + 下拉菜单 + Header for the "dropdown menu" menu item (formerly "new tab menu"). This navigates to a page that lets you see and modify settings related to the app's dropdown menu (i.e. profile ordering, nested folders, dividers, etc.) <分隔符> diff --git a/src/cascadia/TerminalSettingsEditor/Resources/zh-TW/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/zh-TW/Resources.resw index ed47981d0e..c28692eb60 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/zh-TW/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/zh-TW/Resources.resw @@ -2394,8 +2394,8 @@ Accessible name for a control allowing the user to select the icon from a list of built in icons. - 新增索引標籤功能表 - Header for the "new tab menu" menu item. This navigates to a page that lets you see and modify settings related to the app's new tab menu (i.e. profile ordering, nested folders, dividers, etc.) + 下拉式功能表 + Header for the "dropdown menu" menu item (formerly "new tab menu"). This navigates to a page that lets you see and modify settings related to the app's dropdown menu (i.e. profile ordering, nested folders, dividers, etc.) <分隔符號> From 7d582e9290a958144fa11c7149f5e6c9b2b9e05e Mon Sep 17 00:00:00 2001 From: "Dustin L. Howett" Date: Mon, 1 Jun 2026 16:44:04 -0500 Subject: [PATCH 4/4] chore: remove remaining references to ATL and MFC (#20260) Apparently we got rid of ATL in 2019 with #719 --- src/common.build.pre.props | 4 +--- src/unit.tests.x64.runsettings | 2 -- src/unit.tests.x86.runsettings | 2 -- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/common.build.pre.props b/src/common.build.pre.props index b3f57bf230..0b9ee8a966 100644 --- a/src/common.build.pre.props +++ b/src/common.build.pre.props @@ -122,8 +122,6 @@ Conhost code uses a lot of nameless structs/unions. C4312: 'type cast': conversion from 'A' to 'B' of greater size Conhost code converts DWORDs to HANDLEs for instance. - C4467: usage of ATL attributes is deprecated - Conhost code still uses ATL. C26445: Do not assign std::span or std::string_view to a reference. They are cheap to construct and are not owners of the underlying data. (gsl.view). Even for MSVC v19.32 this is actually far from true. Copying (as opposed to referencing) larger than register-sized structures is fairly expensive. Example: https://godbolt.org/z/oPco88PaP @@ -136,7 +134,7 @@ C26494: Variable 'index' is uninitialized. Always initialize an object (type. 5). This diagnostic is broken in VS 17.7 which our CI currently uses. It's fixed in 17.8. --> - 4201;4312;4467;5105;26434;26445;26456;26478;26494;%(DisableSpecificWarnings) + 4201;4312;5105;26434;26445;26456;26478;26494;%(DisableSpecificWarnings) _WINDOWS;EXTERNAL_BUILD;_SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING;%(PreprocessorDefinitions) true precomp.h diff --git a/src/unit.tests.x64.runsettings b/src/unit.tests.x64.runsettings index eb936b53d5..f45c1ea5ed 100644 --- a/src/unit.tests.x64.runsettings +++ b/src/unit.tests.x64.runsettings @@ -56,7 +56,6 @@ Included items must then not match any entries in the exclude list to remain inc ^Fabrikam\.UnitTest\..* ^std::.* - ^ATL::.* .*::__GetTestMethodInfo.* ^Microsoft::VisualStudio::CppCodeCoverageFramework::.* ^Microsoft::VisualStudio::CppUnitTestFramework::.* @@ -83,7 +82,6 @@ Included items must then not match any entries in the exclude list to remain inc - .*\\atlmfc\\.* .*\\vctools\\.* .*\\public\\sdk\\.* .*\\microsoft sdks\\.* diff --git a/src/unit.tests.x86.runsettings b/src/unit.tests.x86.runsettings index e9a92a2153..3808a15523 100644 --- a/src/unit.tests.x86.runsettings +++ b/src/unit.tests.x86.runsettings @@ -56,7 +56,6 @@ Included items must then not match any entries in the exclude list to remain inc ^Fabrikam\.UnitTest\..* ^std::.* - ^ATL::.* .*::__GetTestMethodInfo.* ^Microsoft::VisualStudio::CppCodeCoverageFramework::.* ^Microsoft::VisualStudio::CppUnitTestFramework::.* @@ -83,7 +82,6 @@ Included items must then not match any entries in the exclude list to remain inc - .*\\atlmfc\\.* .*\\vctools\\.* .*\\public\\sdk\\.* .*\\microsoft sdks\\.*