From 26069dad5fb5d50ce11685ccc4f6fefd47203d9b Mon Sep 17 00:00:00 2001
From: niels9001 <niels9001@users.noreply.github.com>
Date: Sat, 16 May 2026 22:47:44 +0200
Subject: [PATCH] Replace Bold with SemiBold; clean up new-tab tooltips

Bold and Italic are not part of the Fluent typography ramp. As a first pass:

- Replace all FontWeight=Bold usages in TerminalApp with SemiBold (matches Fluent's BodyStrong).
  - SuggestionsControl description title
  - Default-profile flyout item in the new-tab dropdown
  - HighlightedTextControl fallback run style for matched text

- Remove the italic styling on the new-tab '+' button tooltip and the per-profile dropdown tooltip; insert a blank line between the title and the shortcut hints; add spaces around '+' in the en-US shortcut strings (Alt + Click / Shift + Click / Ctrl + Click).

Part of #20228

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 src/cascadia/TerminalApp/HighlightedTextControl.cpp     | 4 ++--
 src/cascadia/TerminalApp/Resources/en-US/Resources.resw | 6 +++---
 src/cascadia/TerminalApp/SuggestionsControl.xaml        | 2 +-
 src/cascadia/TerminalApp/TabRowControl.xaml             | 8 +++-----
 src/cascadia/TerminalApp/TerminalPage.cpp               | 4 +---
 5 files changed, 10 insertions(+), 14 deletions(-)

diff --git a/src/cascadia/TerminalApp/HighlightedTextControl.cpp b/src/cascadia/TerminalApp/HighlightedTextControl.cpp
index fc5447fdf8..c726c45464 100644
--- a/src/cascadia/TerminalApp/HighlightedTextControl.cpp
+++ b/src/cascadia/TerminalApp/HighlightedTextControl.cpp
@@ -152,8 +152,8 @@ namespace winrt::TerminalApp::implementation
                     }
                     else
                     {
-                        // Default style: bold
-                        run.FontWeight(FontWeights::Bold());
+                        // Default style: semibold
+                        run.FontWeight(FontWeights::SemiBold());
                     }
                     inlinesCollection.Append(run);
 
diff --git a/src/cascadia/TerminalApp/Resources/en-US/Resources.resw b/src/cascadia/TerminalApp/Resources/en-US/Resources.resw
index 2fe41f21a0..aa44646e56 100644
--- a/src/cascadia/TerminalApp/Resources/en-US/Resources.resw
+++ b/src/cascadia/TerminalApp/Resources/en-US/Resources.resw
@@ -443,13 +443,13 @@
     <value>Open a new tab</value>
   </data>
   <data name="NewPaneRun.Text" xml:space="preserve">
-    <value>Alt+Click to split the current window</value>
+    <value>Alt + Click to split the current window</value>
   </data>
   <data name="NewWindowRun.Text" xml:space="preserve">
-    <value>Shift+Click to open a new window</value>
+    <value>Shift + Click to open a new window</value>
   </data>
   <data name="ElevatedRun.Text" xml:space="preserve">
-    <value>Ctrl+Click to open as administrator</value>
+    <value>Ctrl + Click to open as administrator</value>
   </data>
   <data name="WindowCloseButton.[using:Windows.UI.Xaml.Controls]ToolTipService.ToolTip" xml:space="preserve">
     <value>Close</value>
diff --git a/src/cascadia/TerminalApp/SuggestionsControl.xaml b/src/cascadia/TerminalApp/SuggestionsControl.xaml
index a673b984ba..94342ddee0 100644
--- a/src/cascadia/TerminalApp/SuggestionsControl.xaml
+++ b/src/cascadia/TerminalApp/SuggestionsControl.xaml
@@ -228,7 +228,7 @@
                         Visibility="Collapsed">
                 <TextBlock x:Name="_descriptionTitle"
                            FontSize="14"
-                           FontWeight="Bold"
+                           FontWeight="SemiBold"
                            IsTextSelectionEnabled="True"
                            TextWrapping="WrapWholeWords">
                     <TextBlock.ContextFlyout>
diff --git a/src/cascadia/TerminalApp/TabRowControl.xaml b/src/cascadia/TerminalApp/TabRowControl.xaml
index 11335b654c..c63d0b70a2 100644
--- a/src/cascadia/TerminalApp/TabRowControl.xaml
+++ b/src/cascadia/TerminalApp/TabRowControl.xaml
@@ -71,11 +71,9 @@
                     <ToolTipService.ToolTip>
                         <ToolTip Placement="Mouse">
                             <TextBlock TextWrapping="Wrap">
-                                <Run x:Uid="NewTabRun" /> <LineBreak />
-                                <Run x:Uid="NewPaneRun"
-                                     FontStyle="Italic" /> <LineBreak />
-                                <Run x:Uid="NewWindowRun"
-                                     FontStyle="Italic" />
+                                <Run x:Uid="NewTabRun" /> <LineBreak /><LineBreak />
+                                <Run x:Uid="NewPaneRun" /> <LineBreak />
+                                <Run x:Uid="NewWindowRun" />
                             </TextBlock>
                         </ToolTip>
                     </ToolTipService.ToolTip>
diff --git a/src/cascadia/TerminalApp/TerminalPage.cpp b/src/cascadia/TerminalApp/TerminalPage.cpp
index 0d4a245fd2..ec9d9ff04e 100644
--- a/src/cascadia/TerminalApp/TerminalPage.cpp
+++ b/src/cascadia/TerminalApp/TerminalPage.cpp
@@ -1295,17 +1295,15 @@ namespace winrt::TerminalApp::implementation
         newTabRun.Text(RS_(L"NewTabRun/Text"));
         auto newPaneRun = WUX::Documents::Run();
         newPaneRun.Text(RS_(L"NewPaneRun/Text"));
-        newPaneRun.FontStyle(FontStyle::Italic);
         auto newWindowRun = WUX::Documents::Run();
         newWindowRun.Text(RS_(L"NewWindowRun/Text"));
-        newWindowRun.FontStyle(FontStyle::Italic);
         auto elevatedRun = WUX::Documents::Run();
         elevatedRun.Text(RS_(L"ElevatedRun/Text"));
-        elevatedRun.FontStyle(FontStyle::Italic);
 
         auto textBlock = WUX::Controls::TextBlock{};
         textBlock.Inlines().Append(newTabRun);
         textBlock.Inlines().Append(WUX::Documents::LineBreak{});
+        textBlock.Inlines().Append(WUX::Documents::LineBreak{});
         textBlock.Inlines().Append(newPaneRun);
         textBlock.Inlines().Append(WUX::Documents::LineBreak{});
         textBlock.Inlines().Append(newWindowRun);