starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-12 21:25:50 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

A hypothetical fix for hidden windows (#15213)

Browse Source 
We had a report in a mail thread that someone's Terminal windows were
getting created hidden, and never showing themselves.

As a theory, I'm guessing that dwFlags didn't say that we should
actually use `wShowWindow`. So, to be more correct, let's actually obey
that.

I'm gonna send this package to them to see if it fixes them.

Related to #14957.

Likely regressed in #13838.
This commit is contained in:
Mike Griese
2023-04-25 16:42:09 -05:00
committed by GitHub
parent fea6eeddfd
commit 4ebc383cb6
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/cascadia/WindowsTerminal/WindowEmperor.cpp
View File

@@ -79,7 +79,7 @@ bool WindowEmperor::HandleCommandlineArgs()
// so we can open a new window with the same state.
STARTUPINFOW si;
GetStartupInfoW(&si);
const auto showWindow = si.wShowWindow;
const uint32_t showWindow = WI_IsFlagSet(si.dwFlags, STARTF_USESHOWWINDOW) ? si.wShowWindow : SW_SHOW;
Remoting::CommandlineArgs eventArgs{ { args }, { cwd }, showWindow };