From 57b9549ff814b52cdcf2bf36c69488db22abcde2 Mon Sep 17 00:00:00 2001 From: Brandon Dong Date: Wed, 26 Jul 2023 17:13:49 -0700 Subject: [PATCH] Fix matches of multiple schemas on "colorScheme" (#15748) Adds proper `type` for `SchemePair` definition to avoid warnings about matches of multiple schemas. Same fix as https://github.com/microsoft/terminal/pull/4045 ## Validation Steps Performed - Pointed $schema to local file instead of https://aka.ms/terminal-profiles-schema - Confirmed warning goes away when using a string - Confirmed using the light/dark object format still passes validation - Confirmed values like `"colorScheme": 3` no longer incorrectly pass validation whereas they would before --- doc/cascadia/profiles.schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/cascadia/profiles.schema.json b/doc/cascadia/profiles.schema.json index d3ccfa8d12..c681ef2926 100644 --- a/doc/cascadia/profiles.schema.json +++ b/doc/cascadia/profiles.schema.json @@ -260,7 +260,8 @@ "description": "Name of the scheme to use when the app is using dark theme", "type": "string" } - } + }, + "type": "object" }, "FontConfig": { "properties": {