diff --git a/src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp b/src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp index d3f2647bc8..ef0b6919d8 100644 --- a/src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp +++ b/src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp @@ -1421,7 +1421,7 @@ namespace TerminalAppLocalTests VERIFY_ARE_EQUAL(L"profile0", terminalArgs.Profile()); VERIFY_IS_NULL(terminalArgs.Elevate()); - const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, terminalArgs); + const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, settings.WindowSettingsDefaults(), terminalArgs); const auto termSettings = termSettingsResult.DefaultSettings(); VERIFY_ARE_EQUAL(L"cmd.exe", termSettings->Commandline()); VERIFY_ARE_EQUAL(false, termSettings->Elevate()); @@ -1444,7 +1444,7 @@ namespace TerminalAppLocalTests VERIFY_ARE_EQUAL(L"profile1", terminalArgs.Profile()); VERIFY_IS_NULL(terminalArgs.Elevate()); - const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, terminalArgs); + const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, settings.WindowSettingsDefaults(), terminalArgs); const auto termSettings = termSettingsResult.DefaultSettings(); VERIFY_ARE_EQUAL(L"pwsh.exe", termSettings->Commandline()); VERIFY_ARE_EQUAL(true, termSettings->Elevate()); @@ -1467,7 +1467,7 @@ namespace TerminalAppLocalTests VERIFY_ARE_EQUAL(L"profile2", terminalArgs.Profile()); VERIFY_IS_NULL(terminalArgs.Elevate()); - const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, terminalArgs); + const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, settings.WindowSettingsDefaults(), terminalArgs); const auto termSettings = termSettingsResult.DefaultSettings(); VERIFY_ARE_EQUAL(L"wsl.exe", termSettings->Commandline()); VERIFY_ARE_EQUAL(false, termSettings->Elevate()); @@ -1492,7 +1492,7 @@ namespace TerminalAppLocalTests VERIFY_IS_NOT_NULL(terminalArgs.Elevate()); VERIFY_IS_FALSE(terminalArgs.Elevate().Value()); - const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, terminalArgs); + const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, settings.WindowSettingsDefaults(), terminalArgs); const auto termSettings = termSettingsResult.DefaultSettings(); VERIFY_ARE_EQUAL(L"cmd.exe", termSettings->Commandline()); VERIFY_ARE_EQUAL(false, termSettings->Elevate()); @@ -1516,7 +1516,7 @@ namespace TerminalAppLocalTests VERIFY_IS_NOT_NULL(terminalArgs.Elevate()); VERIFY_IS_FALSE(terminalArgs.Elevate().Value()); - const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, terminalArgs); + const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, settings.WindowSettingsDefaults(), terminalArgs); const auto termSettings = termSettingsResult.DefaultSettings(); VERIFY_ARE_EQUAL(L"pwsh.exe", termSettings->Commandline()); VERIFY_ARE_EQUAL(false, termSettings->Elevate()); @@ -1540,7 +1540,7 @@ namespace TerminalAppLocalTests VERIFY_IS_NOT_NULL(terminalArgs.Elevate()); VERIFY_IS_FALSE(terminalArgs.Elevate().Value()); - const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, terminalArgs); + const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, settings.WindowSettingsDefaults(), terminalArgs); const auto termSettings = termSettingsResult.DefaultSettings(); VERIFY_ARE_EQUAL(L"wsl.exe", termSettings->Commandline()); VERIFY_ARE_EQUAL(false, termSettings->Elevate()); @@ -1565,7 +1565,7 @@ namespace TerminalAppLocalTests VERIFY_IS_NOT_NULL(terminalArgs.Elevate()); VERIFY_IS_TRUE(terminalArgs.Elevate().Value()); - const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, terminalArgs); + const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, settings.WindowSettingsDefaults(), terminalArgs); const auto termSettings = termSettingsResult.DefaultSettings(); VERIFY_ARE_EQUAL(L"cmd.exe", termSettings->Commandline()); VERIFY_ARE_EQUAL(true, termSettings->Elevate()); @@ -1588,7 +1588,7 @@ namespace TerminalAppLocalTests VERIFY_IS_NOT_NULL(terminalArgs.Elevate()); VERIFY_IS_TRUE(terminalArgs.Elevate().Value()); - const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, terminalArgs); + const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, settings.WindowSettingsDefaults(), terminalArgs); const auto termSettings = termSettingsResult.DefaultSettings(); VERIFY_ARE_EQUAL(L"pwsh.exe", termSettings->Commandline()); VERIFY_ARE_EQUAL(true, termSettings->Elevate()); @@ -1612,7 +1612,7 @@ namespace TerminalAppLocalTests VERIFY_IS_NOT_NULL(terminalArgs.Elevate()); VERIFY_IS_TRUE(terminalArgs.Elevate().Value()); - const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, terminalArgs); + const auto termSettingsResult = TerminalSettings::CreateWithNewTerminalArgs(settings, settings.WindowSettingsDefaults(), terminalArgs); const auto termSettings = termSettingsResult.DefaultSettings(); VERIFY_ARE_EQUAL(L"wsl.exe", termSettings->Commandline()); VERIFY_ARE_EQUAL(true, termSettings->Elevate()); diff --git a/src/cascadia/TerminalApp/TerminalPage.cpp b/src/cascadia/TerminalApp/TerminalPage.cpp index e130807f78..aaaed4c926 100644 --- a/src/cascadia/TerminalApp/TerminalPage.cpp +++ b/src/cascadia/TerminalApp/TerminalPage.cpp @@ -467,7 +467,7 @@ namespace winrt::TerminalApp::implementation _tabRow.ShowElevationShield(IsRunningElevated() && _currentWindowSettings().ShowAdminShield()); // Apply the ShowWorkspacesButton theme setting. - if (const auto theme = _settings.GlobalSettings().CurrentTheme()) + if (const auto theme = _settings.GlobalSettings().CurrentTheme(_currentWindowSettings())) { _tabRow.ShowWorkspacesButton(theme.Window() ? theme.Window().ShowWorkspacesButton() : true); } @@ -4130,7 +4130,7 @@ namespace winrt::TerminalApp::implementation _tabRow.ShowElevationShield(IsRunningElevated() && _currentWindowSettings().ShowAdminShield()); // Apply the ShowWorkspacesButton theme setting. - if (const auto theme = _settings.GlobalSettings().CurrentTheme()) + if (const auto theme = _settings.GlobalSettings().CurrentTheme(_currentWindowSettings())) { _tabRow.ShowWorkspacesButton(theme.Window() ? theme.Window().ShowWorkspacesButton() : true); }