starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-07 13:51:51 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Back off between attempts to start the tests (#15106)

Browse Source 
Looking through this test, I seriously don't understand how this doesn't
work. I mean, I don't really get how it _does_ work, but at this point
in the tests, we've actually established that both `Nihilist.exe` _and_
openconsole are running. From my read, there's no reason these should be
failing at this point.

We previously added a "retry 5 times" bit to this test, in #8534. That
did work back then. So uh, just do that... again?
This commit is contained in:
Mike Griese
2023-04-13 13:38:38 -05:00
committed by GitHub
parent f671f065bf
commit 72d0566fa6
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/host/ft_host/InitTests.cpp
View File

@@ -237,11 +237,12 @@ MODULE_SETUP(ModuleSetup)
// to the one that belongs to the CMD.exe in the new OpenConsole.exe window.
VERIFY_WIN32_BOOL_SUCCEEDED_RETURN(FreeConsole());
// Wait a moment for the driver to be ready after freeing to attach.
VERIFY_WIN32_BOOL_SUCCEEDED_RETURN(AttachConsole(dwFindPid));
auto tries = 0;
while (tries < 5)
int tries = 0;
DWORD delay;
// This will wait for up to 32s in total (from 10ms to 163840ms)
for (delay = 10; delay < 30000u; delay *= 2)
{
tries++;
Log::Comment(NoThrowString().Format(L"Attempt #%d to confirm we've attached", tries));
@@ -267,17 +268,20 @@ MODULE_SETUP(ModuleSetup)
auto succeeded = GetConsoleScreenBufferInfoEx(hOut, &csbiexBefore);
if (!succeeded)
{
auto gle = GetLastError();
const auto gle = GetLastError();
VERIFY_ARE_EQUAL(6u, gle, L"If we fail to set up the console, GetLastError should return 6 here.");
Sleep(1000);
// Sleep with a backoff, to give us longer to try next time.
WaitForSingleObject(GetCurrentThread(), delay);
}
else
{
Log::Comment(NoThrowString().Format(L"Succeeded on try #%d", tries));
break;
}
};
VERIFY_IS_LESS_THAN(tries, 5, L"Make sure we set up the new console in time");
VERIFY_IS_LESS_THAN(delay, 30000u, L"Make sure we set up the new console in time");
return true;
}