From 9009dfab9bedce27bf4116eacf5c4a3880f02e1c Mon Sep 17 00:00:00 2001 From: Carlos Zamora Date: Mon, 22 Jun 2026 13:35:17 -0700 Subject: [PATCH] fix resw comment + directly call VM fns --- src/cascadia/TerminalSettingsEditor/Profiles.cpp | 10 ---------- src/cascadia/TerminalSettingsEditor/Profiles.h | 2 -- src/cascadia/TerminalSettingsEditor/Profiles.xaml | 4 ++-- .../Resources/en-US/Resources.resw | 2 +- 4 files changed, 3 insertions(+), 15 deletions(-) diff --git a/src/cascadia/TerminalSettingsEditor/Profiles.cpp b/src/cascadia/TerminalSettingsEditor/Profiles.cpp index 065534f8a7..950157d74e 100644 --- a/src/cascadia/TerminalSettingsEditor/Profiles.cpp +++ b/src/cascadia/TerminalSettingsEditor/Profiles.cpp @@ -39,16 +39,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation TelemetryPrivacyDataTag(PDT_ProductAndServiceUsage)); } - void Profiles::Defaults_Click(const IInspectable& /*sender*/, const RoutedEventArgs& /*args*/) - { - _ViewModel.RequestOpenDefaults(); - } - - void Profiles::ColorSchemes_Click(const IInspectable& /*sender*/, const RoutedEventArgs& /*args*/) - { - _ViewModel.RequestOpenColorSchemes(); - } - // The primary "+" half of the SplitButton — adds either a new empty // profile or a duplicate of the currently selected source profile, // depending on what the user picked from the flyout. diff --git a/src/cascadia/TerminalSettingsEditor/Profiles.h b/src/cascadia/TerminalSettingsEditor/Profiles.h index be78f9c095..0bc45f551e 100644 --- a/src/cascadia/TerminalSettingsEditor/Profiles.h +++ b/src/cascadia/TerminalSettingsEditor/Profiles.h @@ -59,8 +59,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation void OnNavigatedTo(const winrt::Windows::UI::Xaml::Navigation::NavigationEventArgs& e); - void Defaults_Click(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args); - void ColorSchemes_Click(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args); void AddProfile_Click(const Microsoft::UI::Xaml::Controls::SplitButton& sender, const Microsoft::UI::Xaml::Controls::SplitButtonClickEventArgs& args); void AddProfileFlyout_Opening(const Windows::Foundation::IInspectable& sender, const Windows::Foundation::IInspectable& args); void Profile_Click(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args); diff --git a/src/cascadia/TerminalSettingsEditor/Profiles.xaml b/src/cascadia/TerminalSettingsEditor/Profiles.xaml index d66d04ce18..6e5487db49 100644 --- a/src/cascadia/TerminalSettingsEditor/Profiles.xaml +++ b/src/cascadia/TerminalSettingsEditor/Profiles.xaml @@ -28,7 +28,7 @@ @@ -38,7 +38,7 @@ diff --git a/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw index 80672e4996..02830d9114 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw @@ -1307,7 +1307,7 @@ Color schemes - Title for the "Color schemes" navigator on the Profiles landing page. Clicking this opens the same page reachable from the top-level Color schemes nav item. + Title for the "Color schemes" navigator on the Profiles landing page. Clicking this opens the the color schemes page. Add, edit, or remove the color schemes that your profiles can use.