starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-08 05:37:27 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Stop the beef when you hover off a hyperlink (#15120)

Browse Source 
Big surprise, apparently W.F.Uri can parse the empty string into
garbage!
This commit is contained in:
Dustin L. Howett
2023-04-05 18:10:54 -05:00
committed by GitHub
parent 5db8af6277
commit a98a0cf2c6
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/cascadia/TerminalControl/TermControl.cpp
View File

@@ -3017,20 +3017,21 @@ namespace winrt::Microsoft::Terminal::Control::implementation
if (lastHoveredCell)
{
winrt::hstring uriText = _core.HoveredUriText();
if (uriText.empty())
{
co_return;
}
try
{
// DisplayUri will filter out non-printable characters and confusables.
Windows::Foundation::Uri parsedUri{ uriText };
if (!parsedUri)
{
co_return;
}
uriText = parsedUri.DisplayUri();
}
catch (...)
{
LOG_CAUGHT_EXCEPTION();
uriText = {};
}
if (!uriText.empty())
{
const auto panel = SwapChainPanel();
const auto scale = panel.CompositionScaleX();
const auto offset = panel.ActualOffset();
@@ -3052,6 +3053,7 @@ namespace winrt::Microsoft::Terminal::Control::implementation
OverlayCanvas().SetLeft(HyperlinkTooltipBorder(), locationInDIPs.x - offset.x);
OverlayCanvas().SetTop(HyperlinkTooltipBorder(), locationInDIPs.y - offset.y);
}
CATCH_LOG();
}
}
}