starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-07 05:39:46 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Fix the add/delete unfocused appearance buttons (#12451)

Browse Source 
## Summary of the Pull Request
The add/delete unfocused appearance buttons now have text on them and are closed to the `Unfocused appearance` header

## References
#11353 

## PR Checklist
* [ ] Closes #xxx
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [x] I work here

## Validation Steps Performed
<img width="548" alt="add" src="https://user-images.githubusercontent.com/26824113/153463971-de14a68b-5ed9-4768-80f8-2a5a5a21bc9f.png">
<img width="557" alt="delete" src="https://user-images.githubusercontent.com/26824113/153463993-9a7413d4-d895-4813-a6ff-1b157f1e72f4.png">
This commit is contained in:
PankajBhojwani
2022-02-11 06:25:02 -08:00
committed by GitHub
parent 19a5eb208d
commit c0083efadd
2 changed files with 26 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/cascadia/TerminalSettingsEditor/Profiles_Appearance.xaml
View File

@@ -141,23 +141,34 @@
<TextBlock x:Uid="Profile_UnfocusedAppearanceTextBlock"
Style="{StaticResource TitleTextBlockStyle}" />
<Button x:Uid="Profile_CreateUnfocusedAppearanceButton"
Margin="32,0,0,0"
Margin="10,0,0,0"
Click="CreateUnfocusedAppearance_Click"
Style="{StaticResource BaseButtonStyle}"
Visibility="{x:Bind local:Converters.InvertedBooleanToVisibility(Profile.HasUnfocusedAppearance), Mode=OneWay}">
<Button.Content>
<FontIcon FontSize="{StaticResource StandardIconSize}"
Glyph="&#xE710;" />
<StackPanel Orientation="Horizontal">
<FontIcon Margin="0,3,0,0"
FontSize="{StaticResource StandardIconSize}"
Glyph="&#xE710;" />
<TextBlock x:Uid="Profile_AddAppearanceButton"
Margin="10,0,0,0"
FontSize="{StaticResource StandardIconSize}" />
</StackPanel>
</Button.Content>
</Button>
<Button x:Uid="Profile_DeleteUnfocusedAppearanceButton"
Margin="32,0,0,0"
Margin="10,0,0,0"
Click="DeleteUnfocusedAppearance_Click"
Style="{StaticResource BaseButtonStyle}"
Visibility="{x:Bind Profile.HasUnfocusedAppearance, Mode=OneWay}">
<Button.Content>
<FontIcon FontSize="{StaticResource StandardIconSize}"
Glyph="&#xE74D;" />
<StackPanel Orientation="Horizontal">
<FontIcon FontSize="{StaticResource StandardIconSize}"
Glyph="&#xE74D;" />
<TextBlock x:Uid="Profile_DeleteAppearanceButton"
Margin="10,0,0,0"
FontSize="{StaticResource StandardIconSize}" />
</StackPanel>
</Button.Content>
<Button.Resources>
<ResourceDictionary>

10
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
View File

@@ -964,9 +964,17 @@
<comment>A description for what the "tab title" setting does. Presented near "Profile_TabTitle".</comment>
</data>
<data name="Profile_UnfocusedAppearanceTextBlock.Text" xml:space="preserve">
<value>Unfocused Appearance</value>
<value>Unfocused appearance</value>
<comment>The header for the section where the unfocused appearance settings can be changed.</comment>
</data>
<data name="Profile_AddAppearanceButton.Text" xml:space="preserve">
<value>Add</value>
<comment>Button label that adds an unfocused appearance for this profile.</comment>
</data>
<data name="Profile_DeleteAppearanceButton.Text" xml:space="preserve">
<value>Delete</value>
<comment>Button label that deletes the unfocused appearance for this profile.</comment>
</data>
<data name="Profile_UseAcrylic.Header" xml:space="preserve">
<value>Enable acrylic</value>
<comment>Header for a control to toggle the acrylic-like rendering of the background. The acrylic material creates a translucent texture.</comment>