starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Show a more descriptive error message when the ConptyConnection fails to start for some reason #10007

New Issue
Closed
opened 2026-01-31 02:09:56 +00:00 by claunia · 11 comments
claunia commented 2026-01-31 02:09:56 +00:00
Owner
Copy Link

Originally created by @RufusJWB on GitHub (Aug 5, 2020).

Description of the new feature/enhancement

Show a speaking error message, when it is necessary to run Terminal with admin privileges. See https://github.com/microsoft/terminal/issues/4272 for the problem

Proposed technical implementation details (optional)

Originally created by @RufusJWB on GitHub (Aug 5, 2020). # Description of the new feature/enhancement Show a speaking error message, when it is necessary to run Terminal with admin privileges. See https://github.com/microsoft/terminal/issues/4272 for the problem # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. -->
claunia commented 2026-01-31 02:09:57 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Aug 5, 2020):

How about just displaying the error message that matches the error code, like so:

[error 0x800702e4 when launching `C:\Program Files\PowerShell\6\pwsh.exe']
The requested operation requires elevation.

Or does Windows Terminal have to recognize the 0x800702e4 code specifically and display something more verbose?

@KalleOlaviNiemitalo commented on GitHub (Aug 5, 2020): How about just displaying the error message that matches the error code, like so: ``` [error 0x800702e4 when launching `C:\Program Files\PowerShell\6\pwsh.exe'] The requested operation requires elevation. ``` Or does Windows Terminal have to recognize the 0x800702e4 code specifically and display something more verbose?
claunia commented 2026-01-31 02:09:57 +00:00
Author
Owner
Copy Link

@RufusJWB commented on GitHub (Aug 5, 2020):

I think displaying the error message would be perfectly fine. I had to google it. With the error message, this wouldn't have been necessary.

@RufusJWB commented on GitHub (Aug 5, 2020): I think displaying the error message would be perfectly fine. I had to google it. With the error message, this wouldn't have been necessary.
claunia commented 2026-01-31 02:09:58 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Aug 5, 2020):

Could even extend that to process exit codes that look like NTSTATUS error codes:

[process exited with code 3221225786]
The application terminated as a result of a CTRL+C.

That would have a greater risk of false matches, though.

@KalleOlaviNiemitalo commented on GitHub (Aug 5, 2020): Could even extend that to process exit codes that look like NTSTATUS error codes: ``` [process exited with code 3221225786] The application terminated as a result of a CTRL+C. ``` That would have a greater risk of false matches, though.
claunia commented 2026-01-31 02:09:58 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 5, 2020):

This isn't a bad idea, and I bet @DHowett thought about something like this when he first added the error codes

@zadjii-msft commented on GitHub (Aug 5, 2020): This isn't a bad idea, and I bet @DHowett thought about something like this when he first added the error codes
claunia commented 2026-01-31 02:09:58 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 6, 2020):

Yeah, we can definitely do better with these error messages!

@DHowett commented on GitHub (Aug 6, 2020): Yeah, we can definitely do better with these error messages!
claunia commented 2026-01-31 02:09:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 7, 2022):

For those who'd like to try this themselves, I added a similar kind of error message in #10045.

Collected relevant error messages:

Symbolic Name Error Description Header
ERROR_ELEVATION_REQUIRED The requested operation requires elevation. winerror.h
STATUS_CONTROL_C_EXIT {Application Exit by CTRL+C} The application terminated as a result of a CTRL+C. ntstatus.h
MSG_DIR_BAD_COMMAND_OR_FILE '%1' is not recognized as an internal or external command, operable program or batch file. cmdmsg.h
@zadjii-msft commented on GitHub (Apr 7, 2022): For those who'd like to try this themselves, I added a similar kind of error message in #10045. Collected relevant error messages: Symbolic Name | Error Description | Header -- | -- | -- ERROR_ELEVATION_REQUIRED | The requested operation requires elevation. | winerror.h STATUS_CONTROL_C_EXIT | {Application Exit by CTRL+C} The application terminated as a result of a CTRL+C. | ntstatus.h [MSG_DIR_BAD_COMMAND_OR_FILE ](https://github.com/microsoft/terminal/issues/11073)| '%1' is not recognized as an internal or external command, operable program or batch file. | cmdmsg.h
claunia commented 2026-01-31 02:09:59 +00:00
Author
Owner
Copy Link

@Harshit-Agarwal-2022 commented on GitHub (Oct 7, 2024):

Hello , I have read through the issue and I want to try to help in adding the new error message , Can someone guide me as to how to recreate the same runtime conditions as in #4272 ?

@Harshit-Agarwal-2022 commented on GitHub (Oct 7, 2024): Hello , I have read through the issue and I want to try to help in adding the new error message , Can someone guide me as to how to recreate the same runtime conditions as in #4272 ?
claunia commented 2026-01-31 02:09:59 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Oct 8, 2024):

@Harshit-Agarwal-2022, create a Windows Terminal profile that runs %windir%\system32\msconfig.exe, and try to start that profile. The application requires elevation, and this causes error 2147943140 (0x800702e4) as in https://github.com/microsoft/terminal/issues/4272 (unless Windows Terminal itself is elevated).

@KalleOlaviNiemitalo commented on GitHub (Oct 8, 2024): @Harshit-Agarwal-2022, create a Windows Terminal profile that runs `%windir%\system32\msconfig.exe`, and try to start that profile. The application requires elevation, and this causes error 2147943140 (0x800702e4) as in <https://github.com/microsoft/terminal/issues/4272> (unless Windows Terminal itself is elevated).
claunia commented 2026-01-31 02:10:00 +00:00
Author
Owner
Copy Link

@ATOMworkplace commented on GitHub (Oct 15, 2024):

@Harshit-Agarwal-2022 You still working on this issue?

@ATOMworkplace commented on GitHub (Oct 15, 2024): @Harshit-Agarwal-2022 You still working on this issue?
claunia commented 2026-01-31 02:10:00 +00:00
Author
Owner
Copy Link

@Harshit-Agarwal-2022 commented on GitHub (Oct 16, 2024):

@ATOMworkplace I was facing some issues with vs 2022 while building the terminal repo on my local system so i havent started with the issue yet , you can work on it if you want , I was able to recreate the error log using @KalleOlaviNiemitalo 's instructions

@Harshit-Agarwal-2022 commented on GitHub (Oct 16, 2024): @ATOMworkplace I was facing some issues with vs 2022 while building the terminal repo on my local system so i havent started with the issue yet , you can work on it if you want , I was able to recreate the error log using @KalleOlaviNiemitalo 's instructions
claunia commented 2026-01-31 02:10:01 +00:00
Author
Owner
Copy Link

@ATOMworkplace commented on GitHub (Oct 16, 2024):

@Harshit-Agarwal-2022 Sure, thanks for letting me know, I'll give it a try and see what I can do.

@ATOMworkplace commented on GitHub (Oct 16, 2024): @Harshit-Agarwal-2022 Sure, thanks for letting me know, I'll give it a try and see what I can do.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalConnection good first issue Help Wanted In-PR Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10007
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?