starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Show a validation warning when someone sets a setColorScheme action with an invalid scheme #10068

New Issue
Closed
opened 2026-01-31 02:11:38 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 02:11:38 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Aug 7, 2020).

Follow up from #6993.

Basically the title.

We'll have to scan the tree of actions manually for all the "set color scheme" actions, and ensure each of them has a valid scheme. We can't do this during the parsing of the arg itself, we'll have to do this manually in the Validate phase

Originally created by @zadjii-msft on GitHub (Aug 7, 2020). Follow up from #6993. Basically the title. We'll have to scan the tree of actions manually for all the "set color scheme" actions, and ensure each of them has a valid scheme. We can't do this during the parsing of the arg itself, we'll have to do this manually in the Validate phase
claunia commented 2026-01-31 02:11:40 +00:00
Author
Owner
Copy Link

@mpela81 commented on GitHub (Oct 30, 2020):

Some random thoughts while checking this:

  • iterate over all commands in the settings, if at least one "set color scheme" action refers to an unknown scheme, raise the warning
  • check for nested commands as well
  • noticed that the global commands list includes this non-expanded command from default json:
{
    // Select color scheme...
    "name": { "key": "SetColorSchemeParentCommandName" },
    "commands": [
        {
            "iterateOn": "schemes",
            "name": "${scheme.name}",
            "command": { "action": "setColorScheme", "colorScheme": "${scheme.name}" }
        }
    ]
}

What could be a good way to skip validating these? 🤔

@mpela81 commented on GitHub (Oct 30, 2020): Some random thoughts while checking this: - iterate over all commands in the settings, if at least one "set color scheme" action refers to an unknown scheme, raise the warning - check for nested commands as well - noticed that the global commands list includes this non-expanded command from default json: ``` { // Select color scheme... "name": { "key": "SetColorSchemeParentCommandName" }, "commands": [ { "iterateOn": "schemes", "name": "${scheme.name}", "command": { "action": "setColorScheme", "colorScheme": "${scheme.name}" } } ] } ``` What could be a good way to skip validating these? 🤔
claunia commented 2026-01-31 02:11:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 30, 2020):

You could probably ignore any commands with "iterateOn": "schemes", at least for now. That's going to create one action for each color scheme, so you could reasonably assume that the provided colorScheme (which will be expanded out once we know what the set of schemes is) will be valid.

@zadjii-msft commented on GitHub (Oct 30, 2020): You could probably ignore any commands with `"iterateOn": "schemes"`, at least for now. That's going to create one action for each color scheme, so you could reasonably assume that the provided colorScheme (which will be expanded out once we know what the set of schemes is) will be valid.
claunia commented 2026-01-31 02:11:40 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8147, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8147, which has now been successfully released as `Windows Terminal Preview v1.6.10272.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10272.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings good first issue Help Wanted Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10068
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?