starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Consider refactoring CommandPalette + Switcher => LiveFilteringListView #10151

New Issue
Open
opened 2026-01-31 02:13:49 +00:00 by claunia · 11 comments
claunia commented 2026-01-31 02:13:49 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Aug 13, 2020).

There's a good core of an implementation here for a live filtering list view, and I believe that having it serve two leaders (command palette and tab switcher) may unnecessarily complicate its implementation.

Is there something we can do about that?

Originally created by @DHowett on GitHub (Aug 13, 2020). There's a good core of an implementation here for a live filtering list view, and I believe that having it serve two leaders (command palette and tab switcher) may unnecessarily complicate its implementation. Is there something we can do about that?
claunia commented 2026-01-31 02:13:51 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 23, 2020):

@DHowett - I guess I am causing a lot of headache for you with tons of small PRs (realized how distracting this can be after reading https://www.wired.com/story/open-source-coders-few-tired/).

I cannot work on big tasks, especially the ones that are prioritized (very hard to combine it with a family and 12h/day work), especially the ones that require a deep understanding of the architecture and the product. Hence I am hunting for quick wins (up to one night of coding) that are close to surface (I have no clue how rendering works, why VT, etc., etc.)

So probably instead I can work on a stuff like this

  • it will take me a while
  • the interface is simple
  • it is quite standalone (a lot of coding that can be merged, and then a short integration)
  • it is not on the roadmap

Actually I would like to do even more with the Command Palette, which is IMHO much more complex than it should be. This is at least how I would like to see it:

  • We need a simple ephemeral host control with no business logic (it should open nicely and close on time - something like a flyout)
  • Inside the host we will have
  • a control for Tab Switching (with the tab search capabilities)
  • a control for Actions (with nested commands capabilities)
  • a control for Command Lines
  • a logic that switches between their visibility (can be fully Xaml)
  • Terminal page will work with these controls directly (updating data via model-viewmodel binding, and registering to business domain events like "CommandSelectedForExecution", "TabSelectedForPreview", "TabSelectedForSwitch")
  • LiveFilteringListView will implement a significant part of the common logic (filtered command has already extracted the filtering and sorting, but we still need to extract the list rendering and the navigation)

But this one I am afraid to work on, as it will take me few months to implement and even months to merge - I will probably die while merging conflicts.

Long story short - let me know how I can be of a greater use (and a lesser pita). What would you prefer: polishes like today, stuff like the above or something else (given the limitations I mentioned)?

@zadjii-msft - FYI.

@Don-Vito commented on GitHub (Nov 23, 2020): @DHowett - I guess I am causing a lot of headache for you with tons of small PRs (realized how distracting this can be after reading https://www.wired.com/story/open-source-coders-few-tired/). I cannot work on big tasks, especially the ones that are prioritized (very hard to combine it with a family and 12h/day work), especially the ones that require a deep understanding of the architecture and the product. Hence I am hunting for quick wins (up to one night of coding) that are close to surface (I have no clue how rendering works, why VT, etc., etc.) So probably instead I can work on a stuff like this * it will take me a while * the interface is simple * it is quite standalone (a lot of coding that can be merged, and then a short integration) * it is not on the roadmap Actually I would like to do even more with the Command Palette, which is IMHO much more complex than it should be. This is at least how I would like to see it: * We need a simple ephemeral host control with no business logic (it should open nicely and close on time - something like a flyout) * Inside the host we will have * a control for Tab Switching (with the tab search capabilities) * a control for Actions (with nested commands capabilities) * a control for Command Lines * a logic that switches between their visibility (can be fully Xaml) * Terminal page will work with these controls directly (updating data via model-viewmodel binding, and registering to business domain events like "CommandSelectedForExecution", "TabSelectedForPreview", "TabSelectedForSwitch") * LiveFilteringListView will implement a significant part of the common logic (filtered command has already extracted the filtering and sorting, but we still need to extract the list rendering and the navigation) But this one I am afraid to work on, as it will take me few months to implement and even months to merge - I will probably die while merging conflicts. Long story short - let me know how I can be of a greater use (and a lesser pita). What would you prefer: polishes like today, stuff like the above or something else (given the limitations I mentioned)? @zadjii-msft - FYI.
claunia commented 2026-01-31 02:13:51 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 23, 2020):

I know you originally asked Dustin, but these are my thoughts on the matter:

Absolutely don't worry about sending out a ton of small PRs. I kinda like it, they're more easily digestible and reviewable IMO. And at this rate, you've probably committed more code to the Command Palette than I have 😆 It's been nice to have someone working on UX improvements while I've been so heads-down on architectural pieces.

This does seem like a task that's relatively right up your alley, but if it's not something that works with your own contribution schedule, don't worry about it. I think the team is happy to work on more of the big-picture architectural work and let the community come in with the smaller polish fixes and features. I think at the end of the day, you should work on whatever you're passionate about and and think you can ship. I have no doubt that you'd be able to get this one done, but if you want to work on 10 other smaller fixes instead, that's great too.

That being said, I don't think I'd worry too much about merge conflicts till the end of the year - probably a lot less code flow than usual with all the holidays coming up 😄

@zadjii-msft commented on GitHub (Nov 23, 2020): I know you originally asked Dustin, but these are my thoughts on the matter: Absolutely don't worry about sending out a ton of small PRs. I kinda like it, they're more easily digestible and reviewable IMO. And at this rate, you've probably committed more code to the Command Palette than I have 😆 It's been nice to have someone working on UX improvements while I've been so heads-down on architectural pieces. This does seem like a task that's relatively right up your alley, but if it's not something that works with your own contribution schedule, don't worry about it. I think the team is happy to work on more of the big-picture architectural work and let the community come in with the smaller polish fixes and features. I think at the end of the day, you should work on whatever you're passionate about and and think you can ship. I have no doubt that you'd be able to get this one done, but if you want to work on 10 other smaller fixes instead, that's great too. That being said, I don't think I'd worry too much about merge conflicts till the end of the year - probably a lot less code flow than usual with all the holidays coming up 😄
claunia commented 2026-01-31 02:13:52 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 23, 2020):

I know you originally asked Dustin, but these are my thoughts on the matter:

@zadjii-msft - I really value your opinion as well, as you are mostly the one working with me! 💟

I asked Dustin while assuming he suffers most: usually it's an area expert + Dustin who review the code (in addition to all other context switches he has being a lead).

@Don-Vito commented on GitHub (Nov 23, 2020): > > > I know you originally asked Dustin, but these are my thoughts on the matter: > @zadjii-msft - I really value your opinion as well, as you are mostly the one working with me! 💟 I asked Dustin while assuming he suffers most: usually it's an area expert + Dustin who review the code (in addition to all other context switches he has being a lead).
claunia commented 2026-01-31 02:13:52 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 24, 2020):

@Don-Vito i love smaller PRs. They're easy to cherry-pick and when you look back at the history there's a bunch of individual pure changes -- easily revertable, easily blameable, etc.

I'm always asking folks on the team to please break this up into multiple PRs. Sometimes it works ;) and sometimes it doesn't!

@DHowett commented on GitHub (Nov 24, 2020): @Don-Vito i love smaller PRs. They're easy to cherry-pick and when you look back at the history there's a bunch of individual pure changes -- easily revertable, easily blameable, etc. I'm always asking folks on the team to please break this up into multiple PRs. Sometimes it works ;) and sometimes it doesn't!
claunia commented 2026-01-31 02:13:52 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 24, 2020):

That having been said: this is a pretty intense refactoring, so I would totally not expect you to (if you choose to do it) break it into smaller chunks. Sometimes you need to rip the band-aid off and come in and wrecking-ball something. miniksa has done that more than once 😁

@DHowett commented on GitHub (Nov 24, 2020): That having been said: this is a pretty intense refactoring, so I would totally not expect you to (if you choose to do it) break it into smaller chunks. Sometimes you need to rip the band-aid off and come in and wrecking-ball something. miniksa has done that more than once :grin:
claunia commented 2026-01-31 02:13:52 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 24, 2020):

I absolutely agree that PRs must be small (I am not smart enough to review large ones, so once I was coding it kept me and the team disciplined). So even a larger contribution will arrive in small chunks (probably some history rewriting will be required to achieve this 😊)

The question was what will work better - many small contributions (some bug bashing and quick wins) or a more rare but significant contributions (still split into numerous PRs).

Right now I am happy with the sole fact of writing code so I will probably enjoy any kind of tasks.

@Don-Vito commented on GitHub (Nov 24, 2020): I absolutely agree that PRs must be small (I am not smart enough to review large ones, so once I was coding it kept me and the team disciplined). So even a larger contribution will arrive in small chunks (probably some history rewriting will be required to achieve this :blush:) The question was what will work better - many small contributions (some bug bashing and quick wins) or a more rare but significant contributions (still split into numerous PRs). Right now I am happy with the sole fact of writing code so I will probably enjoy any kind of tasks.
claunia commented 2026-01-31 02:13:53 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 24, 2020):

Right now I am happy with the sole fact of writing code so I will probably enjoy any kind of tasks.

That works for us. Either size is fine -- I'm not gonna be overburdened by a helpful, responsive and well-meaning community member at any rate. 😁

@DHowett commented on GitHub (Nov 24, 2020): > Right now I am happy with the sole fact of writing code so I will probably enjoy any kind of tasks. That works for us. Either size is fine -- I'm not gonna be overburdened by a helpful, responsive and well-meaning community member at any rate. :grin:
claunia commented 2026-01-31 02:13:53 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 27, 2020):

OK.. hopefully I have a plan how to achieve this gradually. Since I cannot edit this one - creating a new ticket.

@Don-Vito commented on GitHub (Nov 27, 2020): OK.. hopefully I have a plan how to achieve this gradually. Since I cannot edit this one - creating a new ticket.
claunia commented 2026-01-31 02:13:54 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 27, 2020):

@Don-Vito you can leave your design plan as a comment here and I can update it as necessary

In general our issues are very fluid. 😄

@DHowett commented on GitHub (Nov 27, 2020): @Don-Vito you can leave your design plan as a comment here and I can update it as necessary In general our issues are very fluid. 😄
claunia commented 2026-01-31 02:13:55 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 27, 2020):

@Don-Vito you can leave your design plan as a comment here and I can update it as necessary

In general our issues are very fluid. 😄

I created a separate one, because I am not sure it will fully cover this one, please see https://github.com/microsoft/terminal/issues/8415

@Don-Vito commented on GitHub (Nov 27, 2020): > > > @Don-Vito you can leave your design plan as a comment here and I can update it as necessary > > In general our issues are very fluid. 😄 I created a separate one, because I am not sure it will fully cover this one, please see https://github.com/microsoft/terminal/issues/8415
claunia commented 2026-01-31 02:13:55 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 27, 2020):

(If i file an issue titled “make x do y”, the title is usually interpretable as “i am uncomfortable with x” and “maybe y would be better?” But as a dev lead I should work on not imposing my opinion quite so much!)

@DHowett commented on GitHub (Nov 27, 2020): (If i file an issue titled “make x do y”, the title is usually interpretable as “i am uncomfortable with x” and “maybe y would be better?” But as a dev lead I should work on not imposing my opinion quite so much!)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CmdPal Area-CodeHealth Area-UserInterface Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10151
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?