F7 tunneling broken #10173

Closed
opened 2026-01-31 02:14:21 +00:00 by claunia · 11 comments
Owner

Originally created by @luzhkovvv on GitHub (Aug 14, 2020).

F7 tunneling introduced by #4807 seem to be broken in 1.2.2234.0 preview, but still works in 1.1.2233.0 release

Environment

Windows build number: Microsoft Windows [Version 10.0.19041.450]
Windows Terminal version (if applicable): Version: 1.2.2234.0

Steps to reproduce

Press F7

Expected behavior

F7 key is passed to application

Actual behavior

Nothing happens

Originally created by @luzhkovvv on GitHub (Aug 14, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> F7 tunneling introduced by #4807 seem to be broken in 1.2.2234.0 preview, but still works in 1.1.2233.0 release # Environment ```none Windows build number: Microsoft Windows [Version 10.0.19041.450] Windows Terminal version (if applicable): Version: 1.2.2234.0 ``` # Steps to reproduce Press F7 <!-- A description of how to trigger this bug. --> # Expected behavior F7 key is passed to application <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior Nothing happens <!-- What's actually happening? -->
Author
Owner

@DHowett commented on GitHub (Aug 14, 2020):

Thanks. It looks like it worked in 1.2.2022 as well.

@DHowett commented on GitHub (Aug 14, 2020): Thanks. It looks like it worked in 1.2.2022 as well.
Author
Owner

@DHowett commented on GitHub (Aug 14, 2020):

Good money says this regressed with #7145.

@DHowett commented on GitHub (Aug 14, 2020): Good money says this regressed with #7145.
Author
Owner

@luzhkovvv commented on GitHub (Aug 14, 2020):

WOW! That's a lightning-fast fix! 👍

@luzhkovvv commented on GitHub (Aug 14, 2020): WOW! That's a lightning-fast fix! 👍
Author
Owner

@ghost commented on GitHub (Aug 26, 2020):

:tada:This issue was addressed in #7298, which has now been successfully released as Windows Terminal v1.2.2381.0.🎉

Handy links:

@ghost commented on GitHub (Aug 26, 2020): :tada:This issue was addressed in #7298, which has now been successfully released as `Windows Terminal v1.2.2381.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.2.2381.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@ghost commented on GitHub (Aug 26, 2020):

:tada:This issue was addressed in #7298, which has now been successfully released as Windows Terminal Preview v1.3.2382.0.🎉

Handy links:

@ghost commented on GitHub (Aug 26, 2020): :tada:This issue was addressed in #7298, which has now been successfully released as `Windows Terminal Preview v1.3.2382.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.3.2382.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@KillyMXI commented on GitHub (Nov 27, 2020):

Weird. I'm on 1.4.3243.0 and F7 doesn't work.

@KillyMXI commented on GitHub (Nov 27, 2020): Weird. I'm on 1.4.3243.0 and F7 doesn't work.
Author
Owner

@DHowett commented on GitHub (Nov 28, 2020):

@killymxi with what shell? Are you getting a “caret browsing” pop-up when you use it? Gotta share a bit more info than “it doesn’t work” 😄

@DHowett commented on GitHub (Nov 28, 2020): @killymxi with what shell? Are you getting a “caret browsing” pop-up when you use it? Gotta share a bit more info than “it doesn’t work” 😄
Author
Owner

@KillyMXI commented on GitHub (Nov 28, 2020):

@DHowett Good question. It didn't occur to me to check it outside of WT.
Now I checked:

  • PowerShell 5.1.19041.546 and 7.1.0;
  • Bare, inside WT and inside ConsoleZ.

And in all 2x3 cases there were no observable reaction to F7 key (no pop-up, nothing at all). And in all of those cases F8 key did it's thing (autocompletion from history).

So it's not WT after all, but now I'm even more puzzled how to trace my issue. This was the only relevant thing I've found.
I even checked whether F7 is working on my keyboard now, and the key itself is functional.

@KillyMXI commented on GitHub (Nov 28, 2020): @DHowett Good question. It didn't occur to me to check it outside of WT. Now I checked: - PowerShell 5.1.19041.546 and 7.1.0; - Bare, inside WT and inside ConsoleZ. And in all 2x3 cases there were no observable reaction to F7 key (no pop-up, nothing at all). And in all of those cases F8 key did it's thing (autocompletion from history). So it's not WT after all, but now I'm even more puzzled how to trace my issue. This was the only relevant thing I've found. I even checked whether F7 is working on my keyboard now, and the key itself is functional.
Author
Owner

@DHowett commented on GitHub (Nov 28, 2020):

Ah! So, PowerShell doesn’t do anything with F7 by default since the advent of PSReadline. It’s a line editing library that handles history, syntax highlighting, history search, etc. Life is way better with it enabled, but if you want to test a few things without it you can always Remove-Module PSReadline! (It’s only temporary)

@DHowett commented on GitHub (Nov 28, 2020): Ah! So, PowerShell doesn’t do anything with F7 by default since the advent of PSReadline. It’s a line editing library that handles history, syntax highlighting, history search, etc. Life is way better with it enabled, but if you want to test a few things without it you can always `Remove-Module PSReadline`! (It’s only temporary)
Author
Owner

@DHowett commented on GitHub (Nov 28, 2020):

(PSReadline is far more featureful than our old line editor, which is also the one that provides the F7 pop-up.)

@DHowett commented on GitHub (Nov 28, 2020): (PSReadline is far more featureful than our old line editor, which is also the one that provides the F7 pop-up.)
Author
Owner

@KillyMXI commented on GitHub (Nov 28, 2020):

Ah, I see now. I could've realized that during my search. Sorry about that.

I rather should get familiar with the "new" default, so I'll go and read about PSReadline.

I was trying to refresh all the ways to work with history in PS, and since this one is being phased out, there is no point for me to resurrect it.

@KillyMXI commented on GitHub (Nov 28, 2020): Ah, I see now. I could've realized that during my search. Sorry about that. I rather should get familiar with the "new" default, so I'll go and read about PSReadline. I was trying to refresh all the ways to work with history in PS, and since this one is being phased out, there is no point for me to resurrect it.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10173