better move focus to right if possible when removing focus, rather than to left #1018

Closed
opened 2026-01-30 22:14:02 +00:00 by claunia · 3 comments
Owner

Originally created by @bef178 on GitHub (May 13, 2019).

The more often used tabbed application, Chrome (as well as Edge), uses the strategy to move the focus to right when removing focus.
That is: a b c d => a c d, when b removed

While, currently we: a b c d => a c d, when b removed

Originally created by @bef178 on GitHub (May 13, 2019). The more often used tabbed application, Chrome (as well as Edge), uses the strategy to move the focus to right when removing focus. That is: a **b** c d => a **c** d, when b removed While, currently we: a **b** c d => **a** c d, when b removed
Author
Owner

@zadjii-msft commented on GitHub (May 13, 2019):

Seems like a good and just fix to me.

If someone wanted to take a look at this, the code for controlling the tabs behavior is largely in TerminalApp/App.cpp

@zadjii-msft commented on GitHub (May 13, 2019): Seems like a good and just fix to me. If someone wanted to take a look at this, the code for controlling the tabs behavior is largely in `TerminalApp/App.cpp`
Author
Owner

@Summon528 commented on GitHub (Jun 4, 2019):

Shouldn't we close this one because of #767 ?

@Summon528 commented on GitHub (Jun 4, 2019): Shouldn't we close this one because of #767 ?
Author
Owner

@zadjii-msft commented on GitHub (Jun 4, 2019):

Yes we should, I guess the "the" in that PR broke github's auto-linking.

@zadjii-msft commented on GitHub (Jun 4, 2019): Yes we should, I guess the "the" in that PR broke github's auto-linking.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1018