Caption button animations use wrong color #10195

Closed
opened 2026-01-31 02:14:57 +00:00 by claunia · 10 comments
Owner

Originally created by @OuSimeng on GitHub (Aug 17, 2020).

For titlebar of terminal:

image
image

When the hover effect is about to end, the icon turns black, but it turns to white when it done

I'm not sure you can understand my bad English clearly

Originally created by @OuSimeng on GitHub (Aug 17, 2020). # For titlebar of terminal: ![image](https://user-images.githubusercontent.com/57934391/90369003-91461d00-e09d-11ea-86f0-7f4a5bc2b182.png) ![image](https://user-images.githubusercontent.com/57934391/90369064-a91da100-e09d-11ea-8541-8bc3eea45007.png) ## When the hover effect is about to end, the icon turns black, but it turns to white when it done > I'm not sure you can understand my bad English clearly
Author
Owner

@DHowett commented on GitHub (Aug 17, 2020):

Are you using "theme":"dark" even though you are on a Light-theme OS?

@DHowett commented on GitHub (Aug 17, 2020): Are you using `"theme":"dark"` even though you are on a Light-theme OS?
Author
Owner

@OuSimeng commented on GitHub (Aug 17, 2020):

image

maybe?

There is no problem in light theme
image
image

@OuSimeng commented on GitHub (Aug 17, 2020): ![image](https://user-images.githubusercontent.com/57934391/90373396-6e6b3700-e0a4-11ea-8789-e567a63a213f.png) ## maybe? There is no problem in light theme ![image](https://user-images.githubusercontent.com/57934391/90373719-f3eee700-e0a4-11ea-9a3d-bb7a2b1300b3.png) ![image](https://user-images.githubusercontent.com/57934391/90373732-f94c3180-e0a4-11ea-8289-48fdb10bc0e8.png)
Author
Owner

@OuSimeng commented on GitHub (Aug 17, 2020):

I can't understand why it needs to "turn black" in dark theme when hover

@OuSimeng commented on GitHub (Aug 17, 2020): I can't understand why it needs to "turn black" in dark theme when hover
Author
Owner

@DHowett commented on GitHub (Aug 17, 2020):

It is a bug. Thank you for the info.

@DHowett commented on GitHub (Aug 17, 2020): It is a bug. Thank you for the info.
Author
Owner

@AnuthaDev commented on GitHub (Aug 18, 2020):

@DHowett Can I get some pointers on where to start with this🙏

@AnuthaDev commented on GitHub (Aug 18, 2020): @DHowett Can I get some pointers on where to start with this🙏
Author
Owner

@skyline75489 commented on GitHub (Aug 29, 2020):

@AnuthaDev The caption control are defined in MinMaxCloseControl.xaml and related. You may found it useful.

@skyline75489 commented on GitHub (Aug 29, 2020): @AnuthaDev The caption control are defined in `MinMaxCloseControl.xaml` and related. You may found it useful.
Author
Owner

@AnuthaDev commented on GitHub (Aug 29, 2020):

@AnuthaDev The caption control are defined in MinMaxCloseControl.xaml and related. You may found it useful.

Thanks @skyline75489 , but I already know that😅.

Unfortunately I won't be able to contribute for ~2 months (exams!) , so feel free to work on it😊

@AnuthaDev commented on GitHub (Aug 29, 2020): > @AnuthaDev The caption control are defined in `MinMaxCloseControl.xaml` and related. You may found it useful. Thanks @skyline75489 , but I already know that😅. Unfortunately I won't be able to contribute for ~2 months (exams!) , so feel free to work on it😊
Author
Owner

@skyline75489 commented on GitHub (Aug 29, 2020):

You're always welcome to contribute . Good luck with the exam 😄 . By the way Dustin is the leader of this project so he's kinda busier. Feel free to reach me as I'm more of a community member.

@skyline75489 commented on GitHub (Aug 29, 2020): You're always welcome to contribute . Good luck with the exam 😄 . By the way Dustin is the leader of this project so he's kinda busier. Feel free to reach me as I'm more of a community member.
Author
Owner

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8649, which has now been successfully released as Windows Terminal v1.5.10271.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8649, which has now been successfully released as `Windows Terminal v1.5.10271.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.5.10271.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8649, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8649, which has now been successfully released as `Windows Terminal Preview v1.6.10272.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10272.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10195