starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

There's a resource leak somewhere in the App/Control/Connection stack #1023

New Issue
Closed
opened 2026-01-30 22:14:06 +00:00 by claunia · 7 comments
claunia commented 2026-01-30 22:14:06 +00:00
Owner
Copy Link

Originally created by @Kirbk on GitHub (May 13, 2019).

When closing a tab, the memory that was allocated for the tab is retained. This leads to a massive memory leak when the application is used continuously, opening and closing tabs like users do. This uses gigabytes of RAM, the only way to clear it is to close out of the terminal completely and relaunch it.

Originally created by @Kirbk on GitHub (May 13, 2019). When closing a tab, the memory that was allocated for the tab is retained. This leads to a massive memory leak when the application is used continuously, opening and closing tabs like users do. This uses gigabytes of RAM, the only way to clear it is to close out of the terminal completely and relaunch it.
claunia commented 2026-01-30 22:14:08 +00:00
Author
Owner
Copy Link

@onekopaka commented on GitHub (May 14, 2019):

I do not have very concrete data on it yet, but I also see a massive memory leak in WindowsTerminal.exe, even with only ever having just one tab open.

I tend to see this memory consumption happen most aggressively with any sort of application that continuously updates the screen like mtr or htop (I'm using the version of OpenSSH bundled with Windows build 18362 to connect to a Linux machine to run these). A session that run for just under 40 minutes got up to over 1000 MB of memory usage according to Task Manager.

@onekopaka commented on GitHub (May 14, 2019): I do not have very concrete data on it yet, but I also see a massive memory leak in WindowsTerminal.exe, even with only ever having just one tab open. I tend to see this memory consumption happen most aggressively with any sort of application that continuously updates the screen like mtr or htop (I'm using the version of OpenSSH bundled with Windows build 18362 to connect to a Linux machine to run these). A session that run for just under 40 minutes got up to over 1000 MB of memory usage according to Task Manager.
claunia commented 2026-01-30 22:14:08 +00:00
Author
Owner
Copy Link

@onekopaka commented on GitHub (May 14, 2019):

Another bit of information, all that memory seems to be released over time, that same session, now sitting at a shell over SSH calms down and now roughly 3 hours later, it is using an efficient and trim 8.5 MB of RAM according to Task Manager.

@onekopaka commented on GitHub (May 14, 2019): Another bit of information, all that memory seems to be released over time, that same session, now sitting at a shell over SSH calms down and now roughly 3 hours later, it is using an efficient and trim 8.5 MB of RAM according to Task Manager.
claunia commented 2026-01-30 22:14:08 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 14, 2019):

@onekopaka I moved your bug report to 768, to try and keep this thread specific to the cleanup of the TermControl's when a tab is closed

@zadjii-msft commented on GitHub (May 14, 2019): @onekopaka I moved your bug report to 768, to try and keep this thread specific to the cleanup of the TermControl's when a tab is closed
claunia commented 2026-01-30 22:14:08 +00:00
Author
Owner
Copy Link

@dreamer-dead commented on GitHub (May 22, 2019):

Is it possible to reproduce this leak after #914 was merged into master?
I can't check that by myself =(

@dreamer-dead commented on GitHub (May 22, 2019): Is it possible to reproduce this leak after #914 was merged into `master`? I can't check that by myself =(
claunia commented 2026-01-30 22:14:08 +00:00
Author
Owner
Copy Link

@Kirbk commented on GitHub (May 24, 2019):

@dreamer-dead I just rechecked and it still appears to still be present in the most recent merge.

@Kirbk commented on GitHub (May 24, 2019): @dreamer-dead I just rechecked and it still appears to still be present in the most recent merge.
claunia commented 2026-01-30 22:14:09 +00:00
Author
Owner
Copy Link

@driver1998 commented on GitHub (May 30, 2019):

I guess when the tab closes, it doesn't end the conhost process attached to it.

What I did:
Start Windows Terminal, open 9 powershell tabs, and close 8 of them.
Result:
批注 2019-05-30 123646

@driver1998 commented on GitHub (May 30, 2019): I guess when the tab closes, it doesn't end the conhost process attached to it. What I did: Start Windows Terminal, open 9 powershell tabs, and close 8 of them. Result: ![批注 2019-05-30 123646](https://user-images.githubusercontent.com/22699485/58608751-a0458180-82d7-11e9-9d30-e5d330c6082b.png)
claunia commented 2026-01-30 22:14:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 10, 2019):

Somehow, I fixed this in #825. Hooray!

@zadjii-msft commented on GitHub (Jun 10, 2019): Somehow, I fixed this in #825. Hooray!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Issue-Bug Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1023
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?