starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

NewTab won't leave the Command Palette #10348

New Issue
Closed
opened 2026-01-31 02:19:09 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 02:19:09 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Aug 28, 2020).

Environment

Windows build number: 10.0.19042.0
Windows Terminal version : 1.3.2382.0

Steps to reproduce

Add the following to your settings.json:

{ "name": null, "command": { "action": "newTab", "commandline": "wsl.exe" }, "keys": "f2" }

Expected behavior

This entry does not appear in the Command Palette.

Actual behavior

It appears in the Command Palette after explicitly setting "name" to null.

Originally created by @carlos-zamora on GitHub (Aug 28, 2020). # Environment ```none Windows build number: 10.0.19042.0 Windows Terminal version : 1.3.2382.0 ``` # Steps to reproduce Add the following to your settings.json: ``` { "name": null, "command": { "action": "newTab", "commandline": "wsl.exe" }, "keys": "f2" } ``` # Expected behavior This entry does not appear in the Command Palette. # Actual behavior It appears in the Command Palette after explicitly setting "name" to null.
claunia commented 2026-01-31 02:19:11 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 28, 2020):

oh no, this is another instance where we need to know the difference between null and ""!

Except not in JSON. In Command.cpp:33-66

@DHowett commented on GitHub (Aug 28, 2020): _oh no_, this is another instance where we need to know the difference between `null` and `""`! Except not in JSON. In Command.cpp:33-66
claunia commented 2026-01-31 02:19:11 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 20, 2020):

Hi. I've tried to resolve this, yet I think it can't be since code is acting the way it is.
{ "name": null, "command": { "action": "newTab", "commandline": "wsl.exe" }, "keys": "f2" } and
{"command": {"action": "splitPane", "commandline": "wsl.exe" },"keys": "f2" } are pretty much treated as exactly same(meaning they are both null) so no matter I use something like name.isNull(), name == Json::Value::nullSingleton, and name == NULL "name": null would pass if (const auto name{ json[JsonKey(NameKey)] }) in Command.cpp line 63 and _nameFromJson() returns L"". However, I was able to "name": null to not apeear in the CommandPalette, but at same time all the commands which dose not have name key in it e.g({ "command": "scrollDown", "keys": "ctrl+shift+down" }) also disappeared from it I only got Select color scheme..., New tab..., Split pane... in the CommandPalette. All I am saying is that if there are way to differentiate
{ "name": null, "command": { "action": "newTab", "commandline": "wsl.exe" }, "keys": "f2" } and
{"command": {"action": "splitPane", "commandline": "wsl.exe" },"keys": "f2" }
this issue can be resolved. Sorry if I'm wrong.

@ghost commented on GitHub (Oct 20, 2020): Hi. I've tried to resolve this, yet I think it can't be since code is acting the way it is. `{ "name": null, "command": { "action": "newTab", "commandline": "wsl.exe" }, "keys": "f2" }` and ` {"command": {"action": "splitPane", "commandline": "wsl.exe" },"keys": "f2" }` are pretty much treated as exactly same(meaning they are both `null`) so no matter I use something like `name.isNull()`, `name == Json::Value::nullSingleton`, and `name == NULL` `"name": null` would pass `if (const auto name{ json[JsonKey(NameKey)] })` in Command.cpp line 63 and `_nameFromJson() `returns `L""`. However, I was able to `"name": null` to not apeear in the CommandPalette, but at same time all the commands which dose not have `name` key in it e.g(`{ "command": "scrollDown", "keys": "ctrl+shift+down" }`) also disappeared from it I only got Select color scheme..., New tab..., Split pane... in the CommandPalette. All I am saying is that if there are way to differentiate `{ "name": null, "command": { "action": "newTab", "commandline": "wsl.exe" }, "keys": "f2" }` and ` {"command": {"action": "splitPane", "commandline": "wsl.exe" },"keys": "f2" }` this issue can be resolved. Sorry if I'm wrong.
claunia commented 2026-01-31 02:19:11 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Dec 10, 2020):

@zadjii-msft, @DHowett - so this one is broken for 4 months.. and actually I am not sure when it really worked last time for commands that have action args 😊 Right now I don't see any evidence it ever worked 🤔

So.. I am not sure if it is acceptable.. but cannot we simply replace this mechanism with something more explicit and parse-able. Like adding a dedicated field (aka "hideFromPalette")? Since I am not sure we can call it breaking compatibility

@Don-Vito commented on GitHub (Dec 10, 2020): @zadjii-msft, @DHowett - so this one is broken for 4 months.. and actually I am not sure when it really worked last time for commands that have action args :blush: Right now I don't see any evidence it ever worked 🤔 So.. I am not sure if it is acceptable.. but cannot we simply replace this mechanism with something more explicit and parse-able. Like adding a dedicated field (aka "hideFromPalette")? Since I am not sure we can call it breaking compatibility
claunia commented 2026-01-31 02:19:12 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 11, 2020):

FYI future readers: #8402 has more investigation in it too.

Yea, I think the "name": null idea for hiding came about long before auto-generated names did, so now hiding with a null name seems weird.

I'm almost wondering how important hiding default commands is in the first place. It doesn't really seem like we've gotten requests for it. It's not like having default keybindings, where their presence might impact other apps.

That would certainly make the design easier. If we didn't need to worry about hiding defaults, we could focus on just hiding commands defined by the user.

@zadjii-msft commented on GitHub (Dec 11, 2020): FYI future readers: #8402 has more investigation in it too. Yea, I think the `"name": null` idea for hiding came about long before auto-generated names did, so now hiding with a null name seems weird. I'm almost wondering how important **hiding default commands** is in the first place. It doesn't really seem like we've gotten requests for it. It's not like having default keybindings, where their presence might impact other apps. That would certainly make the design easier. If we didn't need to worry about hiding defaults, we could focus on just hiding commands defined by the user.
claunia commented 2026-01-31 02:19:12 +00:00
Author
Owner
Copy Link

@atimholt commented on GitHub (Dec 13, 2020):

For what it's worth, I'm always for as much customizability as possible. The presence of commands that one has long decided they're never going to use creates a measure of noise and, worse, can often hinder "fluent" use by necessitating more keystrokes for the fuzzy-find search.

@atimholt commented on GitHub (Dec 13, 2020): For what it's worth, I'm always for as much customizability as possible. The presence of commands that one has long decided they're never going to use creates a measure of noise and, worse, can often hinder "fluent" use by necessitating more keystrokes for the fuzzy-find search.
claunia commented 2026-01-31 02:19:13 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #9621, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #9621, which has now been successfully released as `Windows Terminal Preview v1.9.1445.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.9.1445.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CmdPal Area-UserInterface Issue-Bug Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10348
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?