starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Mouse selection doesn't work like other apps when mouse cursor is to the left of the text area, to select whole line(s) #10425

New Issue
Closed
opened 2026-01-31 02:21:13 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 02:21:13 +00:00
Owner
Copy Link

Originally created by @zpostfacto on GitHub (Aug 31, 2020).

I absolutely love love this product, thank you so much guys for making it.

This may be a duplicate of #5099 (I'm not sure), but I wanted to call out one specific behaviour that I find to be especially clearly wrong based on muscle memory from other apps, and also irritating to work around.

Environment

Windows Terminal 1.2.2381.0, installed from the app store, on Windows 10.

Steps to reproduce

OK, I want to select one or more whole lines, including their newline. In almost every other app I have ever used, if you start dragging and then drag while the mouse cursor is to the left of the text area (perhaps even outside the window, which is fine, since the mouse is captured), then the first character on the line will not be included in the selection, since you are to the left of it. In Windows Terminal, it is included, and this seems wrong. It's especially irritating because basically there's no way to get your selection to include that last newline and thus select whole blocks of text with the mouse.

So, steps to reproduce are:

  • Click somewhere and start selecting multiple lines.
  • While dragging, move the mouse far to the left of the first column of text, such as into the margin, or up against the left edge of the monitor.

Expected behavior

I expect the selection to end with a newline character from the last selected line.

Actual behavior

Instead, the first character of the line below is included, like this:

image

(My mouse cursor isn't int he screen cap, but it's to the left of the current window.)

Also, if somebody can point me in the right direction, I could probably fix this and submit a PR. Just need a pointer to where to start poking around.

Originally created by @zpostfacto on GitHub (Aug 31, 2020). I absolutely love love this product, thank you so much guys for making it. This may be a duplicate of #5099 (I'm not sure), but I wanted to call out one specific behaviour that I find to be especially clearly wrong based on muscle memory from other apps, and also irritating to work around. # Environment Windows Terminal 1.2.2381.0, installed from the app store, on Windows 10. # Steps to reproduce OK, I want to select one or more whole lines, including their newline. In almost every other app I have ever used, if you start dragging and then drag while the mouse cursor is to the left of the text area (perhaps even outside the window, which is fine, since the mouse is captured), then the first character on the line will not be included in the selection, since you are to the left of it. In Windows Terminal, it is included, and this seems wrong. It's especially irritating because basically there's no way to get your selection to include that last newline and thus select whole blocks of text with the mouse. So, steps to reproduce are: * Click somewhere and start selecting multiple lines. * While dragging, move the mouse far to the left of the first column of text, such as into the margin, or up against the left edge of the monitor. # Expected behavior I expect the selection to end with a newline character from the last selected line. # Actual behavior Instead, the first character of the line below is included, like this: ![image](https://user-images.githubusercontent.com/3768219/91758315-a5e9e100-eb84-11ea-8e46-a0ba60efe88a.png) (My mouse cursor isn't int he screen cap, but it's to the left of the current window.) Also, if somebody can point me in the right direction, I could probably fix this and submit a PR. Just need a pointer to where to start poking around.
claunia added the Resolution-Duplicate label 2026-01-31 02:21:13 +00:00
claunia commented 2026-01-31 02:21:14 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 3, 2020):

Hey, thanks for the report! You're right about this being a /duplicate of #5099 -- making the selection inclusive on the left and exclusive on the right will resolve this pretty handily (because you'd need to move into the right half of the first cell to select the cell).

There's a branch, if you want to look at some of its historical diffs, where I poked at this for a little bit. It's not pleasant, because changing up our coordinate system never is. https://github.com/microsoft/terminal/tree/dev/duhowett/hax-selection-exclusive

@DHowett commented on GitHub (Sep 3, 2020): Hey, thanks for the report! You're right about this being a /duplicate of #5099 -- making the selection inclusive on the left and exclusive on the right will resolve this pretty handily (because you'd need to move into the right half of the first cell to select the cell). There's a branch, if you want to look at some of its historical diffs, where I poked at this for a little bit. It's not pleasant, because changing up our coordinate system never is. https://github.com/microsoft/terminal/tree/dev/duhowett/hax-selection-exclusive
claunia commented 2026-01-31 02:21:14 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 3, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Sep 3, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10425
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?