starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

"Disable Scroll-Forward" doesn't account for page-up/page-down keys #10471

New Issue
Closed
opened 2026-01-31 02:22:23 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 02:22:23 +00:00
Owner
Copy Link

Originally created by @carlreinke on GitHub (Sep 2, 2020).

Environment

Windows build number: 10.0.19041.0

Steps to reproduce

  1. Start PowerShell in conhost.
  2. Enable "Disable Scroll-Forward".
  3. Run a command that produces multiple screens of output.
  4. Use the page-up key to scroll to the top of the output.
  5. Use the page-down key to scroll past the output.

Expected behavior

Scrolling it limited to the output and the scrollbar lets you scroll the output.

Actual behavior

After running command, scrollbar is as expected:
image

After page-up key once, scrollbar is indeterminate:
image

After page-up key again, scrollbar indicates that you see all the output (but you don't):
image

After page-down key, you have scrolled past the end of the output:
image

Originally created by @carlreinke on GitHub (Sep 2, 2020). # Environment Windows build number: 10.0.19041.0 # Steps to reproduce 1. Start PowerShell in conhost. 1. Enable "Disable Scroll-Forward". 1. Run a command that produces multiple screens of output. 1. Use the page-up key to scroll to the top of the output. 1. Use the page-down key to scroll past the output. # Expected behavior Scrolling it limited to the output and the scrollbar lets you scroll the output. # Actual behavior After running command, scrollbar is as expected: ![image](https://user-images.githubusercontent.com/11667451/92039310-1aae4e00-ed32-11ea-81d2-0893d2d913ed.png) After page-up key once, scrollbar is indeterminate: ![image](https://user-images.githubusercontent.com/11667451/92039360-2c8ff100-ed32-11ea-9507-92a3cd5103b2.png) After page-up key again, scrollbar indicates that you see all the output (but you don't): ![image](https://user-images.githubusercontent.com/11667451/92039398-39144980-ed32-11ea-8289-39689beb257d.png) After page-down key, you have scrolled past the end of the output: ![image](https://user-images.githubusercontent.com/11667451/92039443-4c271980-ed32-11ea-9d06-4e268c9d8717.png)
claunia added the Resolution-By-DesignNeeds-Tag-Fix labels 2026-01-31 02:22:24 +00:00
claunia commented 2026-01-31 02:22:24 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 2, 2020):

So I've got some unfortunate news!

PowerShell (specifically PSReadline) has implemented its own handling for PgUp/PgDown:

PS C:\Users\duhowett> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.19041.1
...
BuildVersion                   10.0.19041.1
...

PS C:\Users\duhowett> Get-PSReadLineKeyHandler | ? Key -Like "*Page*"

Miscellaneous functions
=======================
Key           Function              Description
---           --------              -----------
PageDown      ScrollDisplayDown     Scroll the display down one screen
Ctrl+PageDown ScrollDisplayDownLine Scroll the display down one line
PageUp        ScrollDisplayUp       Scroll the display up one screen
Ctrl+PageUp   ScrollDisplayUpLine   Scroll the display up one line

In these handlers (code here), they're directly manipulating the console screen buffer.

Because they're setting the actual active viewport using these APIs, there's nothing we can really do but listen to them. If they want to scroll the viewport into the unpopulated region below the virtual bottom, they're fully allowed to do so.

Resolution on this one is, regrettable, "by design" -- we have to support these APIs forever, even if they coincide with our experimental features in an unfortunate way.

@DHowett commented on GitHub (Sep 2, 2020): So I've got some unfortunate news! PowerShell (specifically PSReadline) has implemented its own handling for <kbd>PgUp</kbd>/<kbd>PgDown</kbd>: ``` PS C:\Users\duhowett> $PSVersionTable Name Value ---- ----- PSVersion 5.1.19041.1 ... BuildVersion 10.0.19041.1 ... PS C:\Users\duhowett> Get-PSReadLineKeyHandler | ? Key -Like "*Page*" Miscellaneous functions ======================= Key Function Description --- -------- ----------- PageDown ScrollDisplayDown Scroll the display down one screen Ctrl+PageDown ScrollDisplayDownLine Scroll the display down one line PageUp ScrollDisplayUp Scroll the display up one screen Ctrl+PageUp ScrollDisplayUpLine Scroll the display up one line ``` In these handlers (code [here](https://github.com/PowerShell/PSReadLine/blob/a88c22fd60a69f41d1b727b7c51b5cbf8f9b5f68/PSReadLine/Render.cs#L1263-L1288)), they're directly manipulating the console screen buffer. Because they're setting the actual active viewport using these APIs, there's nothing we can really do but listen to them. If they want to scroll the viewport into the unpopulated region below the virtual bottom, they're fully allowed to do so. Resolution on this one is, regrettable, "by design" -- we have to support these APIs forever, even if they coincide with our experimental features in an unfortunate way.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Resolution-By-Design
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10471
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?