starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Tab exits with code 1 when Console.SetBufferSize has been modified and you maximize window #10558

New Issue
Open
opened 2026-01-31 02:24:38 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 02:24:38 +00:00
Owner
Copy Link

Originally created by @ajkennedy-HEC on GitHub (Sep 9, 2020).

Possibly related to #1461. I understand the text rendering errors, but the process exiting is different.

When I set the console buffer size to maximum height and run my code from Windows Terminal (in non-maximized, 'windowed' mode), everything appears to work correctly. Windows Terminal honors the buffer-size that I've set, and I can scroll back in history appropriately.

If I maximize that window after running the program, the tab process exits with code 1.

A small C# program that reproduces this issue:

    static void Main(string[] args)
    {
      Console.SetBufferSize(Console.BufferWidth, 32766);
      Console.WriteLine("Buffer size changed.");

      // 100 lines is roughly the minimum it takes to crash the tab. Small behavior changes
      // depending on my initial window size. 
      for (int i = 0; i < 100; i++)
      {
        Console.WriteLine("Line");
      }
    }

image

Windows Version 2004, OS Build 19041.450
Windows Terminal Version 1.2.2381.0

Originally created by @ajkennedy-HEC on GitHub (Sep 9, 2020). Possibly related to #1461. I understand the text rendering errors, but the process exiting is different. When I set the console buffer size to maximum height and run my code from Windows Terminal (in non-maximized, 'windowed' mode), everything appears to work correctly. Windows Terminal honors the buffer-size that I've set, and I can scroll back in history appropriately. If I maximize that window after running the program, the tab process exits with code 1. A small C# program that reproduces this issue: ``` static void Main(string[] args) { Console.SetBufferSize(Console.BufferWidth, 32766); Console.WriteLine("Buffer size changed."); // 100 lines is roughly the minimum it takes to crash the tab. Small behavior changes // depending on my initial window size. for (int i = 0; i < 100; i++) { Console.WriteLine("Line"); } } ``` ![image](https://user-images.githubusercontent.com/14296437/92624793-c39e0100-f27c-11ea-9daa-6287c77cbc5d.png) Windows Version 2004, OS Build 19041.450 Windows Terminal Version 1.2.2381.0
claunia commented 2026-01-31 02:24:40 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 9, 2020):

Alright, there's gonna be two fixes here: rejecting making the buffer taller than the viewport (sorry, but we've got to do that -- it'll also fix #4062) and fixing the openconsole/conpty crash.

@DHowett commented on GitHub (Sep 9, 2020): Alright, there's gonna be two fixes here: rejecting making the buffer taller than the viewport (sorry, but we've got to do that -- it'll also fix #4062) and fixing the openconsole/conpty crash.
claunia commented 2026-01-31 02:24:40 +00:00
Author
Owner
Copy Link

@flevi29 commented on GitHub (Nov 25, 2020):

Oh, that's sad, but understandable. Changing buffer size also causes some weird behavior, where if I resize Windows Terminal a few times the text kinda corrupts.
Screenshot 2020-11-25 144825

@flevi29 commented on GitHub (Nov 25, 2020): Oh, that's sad, but understandable. Changing buffer size also causes some weird behavior, where if I resize Windows Terminal a few times the text kinda corrupts. ![Screenshot 2020-11-25 144825](https://user-images.githubusercontent.com/55688616/100229684-4c981080-2f2d-11eb-9b95-59db88b48db8.png)
claunia commented 2026-01-31 02:24:40 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 25, 2020):

Indeed, that’s why we will have to reject buffer size changes 😄

@DHowett commented on GitHub (Nov 25, 2020): Indeed, that’s why we will have to reject buffer size changes :smile:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Area-Server Help Wanted Issue-Bug Priority-2 Product-Conpty Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10558
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?