starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

New 1.4 VT colors bug, foreground color not applied to " " (space) cells when hyperlinked #10710

New Issue
Open
opened 2026-01-31 02:28:01 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 02:28:01 +00:00
Owner
Copy Link

Originally created by @PhMajerus on GitHub (Sep 22, 2020).

Come on, you knew this was coming, it's almost the same as #5502 😅

So we now have hyperlinks that show dotted underline under characters that are part of a link (since 1.4.2652.0)
You're probably delaying taking the attributes into account until they have a visible effect, which is sensible.
So foreground colors are not applied until a non-space character is shown.

But for hyperlinks, you're using the foreground color to draw the dotted underline, so you should now check if cell is a non-space or part of a hyperlink.

The following should only have the "Red" 3 cells with a red foreground color, but instead the red foreground is kept for two extra cells until the 'h' character is encountered, incorrectly making the dotted underline red in those cells.
echo -e '\e]8;;http://www.example.com/\aSample \e[31mRed\e[m hyperlink\e]8;;\a'

image

Originally created by @PhMajerus on GitHub (Sep 22, 2020). Come on, you knew this was coming, it's almost the same as #5502 😅 So we now have hyperlinks that show dotted underline under characters that are part of a link (since 1.4.2652.0) You're probably delaying taking the attributes into account until they have a visible effect, which is sensible. So foreground colors are not applied until a non-space character is shown. But for hyperlinks, you're using the foreground color to draw the dotted underline, so you should now check if cell is a non-space or part of a hyperlink. The following should only have the "Red" 3 cells with a red foreground color, but instead the red foreground is kept for two extra cells until the 'h' character is encountered, incorrectly making the dotted underline red in those cells. `echo -e '\e]8;;http://www.example.com/\aSample \e[31mRed\e[m hyperlink\e]8;;\a'` ![image](https://user-images.githubusercontent.com/25664275/93941906-a7479d00-fd2f-11ea-9dc6-6ffb1973da62.png)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Priority-2 Product-Conpty Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10710
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?