Hyperlinks: Please allow "file" schema #10711

Closed
opened 2026-01-31 02:28:01 +00:00 by claunia · 5 comments
Owner

Originally created by @daniel-liuzzi on GitHub (Sep 22, 2020).

Description of the new feature/enhancement

At the moment, hyperlink support seems limited to just http and https schemas. It would be nice if file was supported as well.

A sample use case for this is https://github.com/dandavison/delta, an excellent viewer for git and diff output that, among other things, shows line numbers in a git diff as links pointing to the given file. This currently doesn't work due to Windows Terminal blocking the file schema:

image

Originally created by @daniel-liuzzi on GitHub (Sep 22, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement At the moment, hyperlink support [seems limited](https://github.com/microsoft/terminal/blob/49b9d41caf1ae03180af3744bdb5d910d702fb10/src/cascadia/TerminalApp/TerminalPage.cpp#L1809) to just `http` and `https` schemas. It would be nice if `file` was supported as well. A sample use case for this is https://github.com/dandavison/delta, an excellent viewer for git and diff output that, among other things, shows line numbers in a git diff as links pointing to the given file. This currently doesn't work due to Windows Terminal blocking the file schema: ![image](https://user-images.githubusercontent.com/143884/93928043-01d5fe80-fd1a-11ea-8257-ffedfdc5541a.png)
Author
Owner

@DHowett commented on GitHub (Sep 22, 2020):

/dup #7526

@DHowett commented on GitHub (Sep 22, 2020): /dup #7526
Author
Owner

@ghost commented on GitHub (Sep 22, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Sep 22, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Author
Owner

@DHowett commented on GitHub (Sep 22, 2020):

I hate duping things to PRs, but this one has some active discussion on it.

We were having a long discussion over on #7526 about it, and never came to anywhere we felt comfortable with. The same discussion is playing out in #7668, because of how hard it is for the Terminal alone to map paths...

@DHowett commented on GitHub (Sep 22, 2020): I hate duping things to PRs, but this one has some active discussion on it. > We were having a long discussion over on #7526 about it, and never came to anywhere we felt comfortable with. The same discussion is playing out in #7668, because of how hard it is for the Terminal alone to map paths...
Author
Owner

@DHowett commented on GitHub (Sep 22, 2020):

On second thought, I'll reopen this bug as a landing site to redirect folks / point the PR at.

@DHowett commented on GitHub (Sep 22, 2020): On second thought, I'll reopen this bug as a landing site to redirect folks / point the PR at.
Author
Owner

@ghost commented on GitHub (Mar 1, 2021):

:tada:This issue was addressed in #7526, which has now been successfully released as Windows Terminal Preview v1.7.572.0.🎉

Handy links:

@ghost commented on GitHub (Mar 1, 2021): :tada:This issue was addressed in #7526, which has now been successfully released as `Windows Terminal Preview v1.7.572.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.7.572.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10711