starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Convert LocalTests_SettingsModel into UnitTests_SettingsModel #10781

New Issue
Open
opened 2026-01-31 02:30:08 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 02:30:08 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Sep 25, 2020).

Description of the new feature/enhancement

#7667 introduces the TerminalSettingsModel by ripping out a large chunk of TerminalApp. All of the testing was thrown into LocalTests_SettingsModel. Moving them into a unit tests project like TermApp.UnitTests allows us to run these in CI.

About 20/33 tests are able to be moved into a UnitTests-like project with no modifications.
2/33 can be moved with minor modifications (see below).
The remaining 11/33 require a larger refactor (this issue tracks this).

Proposed technical implementation details (optional)

SettingsModelLocalTests::KeyBindingsTests

  • All of these tests fail because they need to construct a KeyChord. KeyChord is in the TerminalControl namespace.

SettingsModelLocalTests::CommandTests

  • TestResourceKeyName and TestLayerOnAutogeneratedName fail because they need access to the resource loader.

SettingsModelLocalTests::SerializationTests

  • The tests below fail because they need to import defaults.json. Which results in hitting the two cases above.
    • TestReorderWithNullGuids
    • TestReorderingWithoutGuid
    • TestLayeringNameOnlyProfiles
    • TestExplodingNameOnlyProfiles
    • TestDontLayerGuidFromUserDefaults
    • ValidateKeybindingsWarnings
  • TestCommandsAndKeybindings doesn't import defaults.json, but fails again because it hits the two cases above.
  • The two tests that can be fixed fairly easily are ValidateLegacyGlobalsWarning and TestTrailingCommas. They don't really need a dependency on importing defaults.json.
Originally created by @carlos-zamora on GitHub (Sep 25, 2020). # Description of the new feature/enhancement #7667 introduces the TerminalSettingsModel by ripping out a large chunk of TerminalApp. All of the testing was thrown into LocalTests_SettingsModel. Moving them into a unit tests project like TermApp.UnitTests allows us to run these in CI. About 20/33 tests are able to be moved into a UnitTests-like project with no modifications. 2/33 can be moved with minor modifications (see below). The remaining 11/33 require a larger refactor (this issue tracks this). # Proposed technical implementation details (optional) `SettingsModelLocalTests::KeyBindingsTests` - All of these tests fail because they need to construct a `KeyChord`. `KeyChord` is in the `TerminalControl` namespace. `SettingsModelLocalTests::CommandTests` - `TestResourceKeyName` and `TestLayerOnAutogeneratedName` fail because they need access to the resource loader. `SettingsModelLocalTests::SerializationTests` - The tests below fail because they need to import defaults.json. Which results in hitting the two cases above. - `TestReorderWithNullGuids` - `TestReorderingWithoutGuid` - `TestLayeringNameOnlyProfiles` - `TestExplodingNameOnlyProfiles` - `TestDontLayerGuidFromUserDefaults` - `ValidateKeybindingsWarnings` - `TestCommandsAndKeybindings` doesn't import defaults.json, but fails again because it hits the two cases above. - The two tests that can be fixed fairly easily are `ValidateLegacyGlobalsWarning` and `TestTrailingCommas`. They don't really need a dependency on importing defaults.json.
claunia added the Issue-TaskProduct-TerminalArea-CodeHealth labels 2026-01-31 02:30:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10781
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?