starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Minimize button glyph is one pixel too high #10794

New Issue
Open
opened 2026-01-31 02:30:31 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 02:30:31 +00:00
Owner
Copy Link

Originally created by @GardenVarietyPack on GitHub (Sep 26, 2020).

Windows Terminal Minimize Button

Description of the new feature/enhancement

The minimize button glyph is one pixel higher than all other window decorations and should be moved down by one pixel. The current design of the minimize button deviates from the rest of the Windows 10 UI by shifting the minimize button one pixel above the center-line of the other window control buttons instead of one pixel below. Ignoring all the other issues with Windows 10 and the design inconsistencies, it should at least be attempted to maintain consistency in the positioning of the window control elements.

Originally created by @GardenVarietyPack on GitHub (Sep 26, 2020). ![Windows Terminal Minimize Button](https://user-images.githubusercontent.com/71948533/94351343-0f5ff100-0058-11eb-92c7-77e425713b12.jpg) # Description of the new feature/enhancement The minimize button glyph is one pixel higher than all other window decorations and should be moved down by one pixel. The current design of the minimize button deviates from the rest of the Windows 10 UI by shifting the minimize button one pixel above the center-line of the other window control buttons instead of one pixel below. Ignoring all the other issues with Windows 10 and the design inconsistencies, it should at least be attempted to maintain consistency in the positioning of the window control elements.
claunia commented 2026-01-31 02:30:32 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 29, 2020):

Well, good eye! We're rolling our own Min/Max/Close control here, so I'm surprised we got it that close tbh 😆

/cc @DHowett, I think he's the one who wrote the paths for that icon originally, just as an fyi.

This probably isn't that hard to fix...

@zadjii-msft commented on GitHub (Sep 29, 2020): Well, good eye! We're rolling our own Min/Max/Close control here, so I'm surprised we got it that close tbh 😆 /cc @DHowett, I think he's the one who wrote the paths for that icon originally, just as an fyi. This probably isn't _that_ hard to fix...
claunia commented 2026-01-31 02:30:32 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 29, 2020):

@ocalvo you should know this if you're copying our xaml

@DHowett commented on GitHub (Sep 29, 2020): @ocalvo you should know this if you're copying our xaml
claunia commented 2026-01-31 02:30:32 +00:00
Author
Owner
Copy Link

@alanaEvey7 commented on GitHub (Oct 2, 2020):

Hi! I've recently tried to start working on this issue, but I'm wondering if I could some guidance on effective ways to test the changes I have made are doing what I expect. Every time I try and run this project it takes 20 minutes to build. Is there a better way?
Thanks in advance!

@alanaEvey7 commented on GitHub (Oct 2, 2020): Hi! I've recently tried to start working on this issue, but I'm wondering if I could some guidance on effective ways to test the changes I have made are doing what I expect. Every time I try and run this project it takes 20 minutes to build. Is there a better way? Thanks in advance!
claunia commented 2026-01-31 02:30:32 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 2, 2020):

@alanaEvey7 How are you building the package? Usually I just right click on the "CascadiaPackage" project in VS and hit "deploy", and that should only rebuild the part of the solution that changed (in your case, it should be only the TerminalApp dll).

image

Then once the project is deployed, you can just launch it from the start menu, or even debugging with VS is way faster.

@zadjii-msft commented on GitHub (Oct 2, 2020): @alanaEvey7 How are you building the package? Usually I just right click on the "CascadiaPackage" project in VS and hit "deploy", and that _should_ only rebuild the part of the solution that changed (in your case, it should be only the TerminalApp dll). ![image](https://user-images.githubusercontent.com/18356694/94888602-46127e80-043f-11eb-843b-a3733e742085.png) Then once the project is deployed, you can just launch it from the start menu, or even debugging with VS is way faster.
claunia commented 2026-01-31 02:30:33 +00:00
Author
Owner
Copy Link

@ocalvo commented on GitHub (Oct 3, 2020):

@ocalvo you should know this if you're copying our xaml

Thanks for bringing to my attention. We are taking note of it.

@ocalvo commented on GitHub (Oct 3, 2020): > @ocalvo you should know this if you're copying our xaml Thanks for bringing to my attention. We are taking note of it.
claunia commented 2026-01-31 02:30:33 +00:00
Author
Owner
Copy Link

@AnuthaDev commented on GitHub (Oct 3, 2020):

This probably isn't that hard to fix...

After spending 1 hour trying to fix it, I can conclude that either I am missing something extremely fundamental or this problem is very tricky.😥

@AnuthaDev commented on GitHub (Oct 3, 2020): >This probably isn't that hard to fix... After spending 1 hour trying to fix it, I can conclude that either I am missing something extremely fundamental or this problem is very tricky.😥
claunia commented 2026-01-31 02:30:33 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 5, 2020):

I'm pretty sure we just need to adjust this bit of XAML:

        <Button.Resources>
            <ResourceDictionary>
                <x:String x:Key="CaptionButtonPath">M 0 0 H 10</x:String>
            </ResourceDictionary>
        </Button.Resources>

In MinMaxCloseControl.xaml, but I'm not super familiar with how these paths are defined. If I had to make a totally uneducated guess, I'd try M 0 1 H 10, but again, I'm not sure about that.

@zadjii-msft commented on GitHub (Oct 5, 2020): I'm pretty sure we just need to adjust this bit of XAML: ```xaml <Button.Resources> <ResourceDictionary> <x:String x:Key="CaptionButtonPath">M 0 0 H 10</x:String> </ResourceDictionary> </Button.Resources> ``` In MinMaxCloseControl.xaml, but I'm not super familiar with how these paths are defined. If I had to make a totally uneducated guess, I'd try `M 0 1 H 10`, but again, I'm not sure about that.
claunia commented 2026-01-31 02:30:34 +00:00
Author
Owner
Copy Link

@AnuthaDev commented on GitHub (Oct 5, 2020):

@zadjii-msft That's exactly what I tried first, doesn't work. The stretch set to fill interferes with it. Setting it to none makes the icons appear very thin. It seems that the viewbox readjusts to only include the part where a path is present, at the centre, disregarding coordinates(if stretch is set to fill).

@AnuthaDev commented on GitHub (Oct 5, 2020): @zadjii-msft That's exactly what I tried first, doesn't work. The stretch set to fill interferes with it. Setting it to none makes the icons appear very thin. It seems that the viewbox readjusts to only include the part where a path is present, at the centre, disregarding coordinates(if stretch is set to fill).
claunia commented 2026-01-31 02:30:34 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 5, 2020):

huh. I wonder if there's anyway that we could add some padding inside that button to compensate for that. I'm gonna yank "easy starter" from this one, that's for sure 😃

@zadjii-msft commented on GitHub (Oct 5, 2020): _huh_. I wonder if there's anyway that we could add some padding inside that button to compensate for that. I'm gonna yank "easy starter" from this one, that's for sure 😃
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Task Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10794
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?