starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Surface keyboard shortcuts in Menu when shown #1080

New Issue
Closed
opened 2026-01-30 22:16:00 +00:00 by claunia · 6 comments
claunia commented 2026-01-30 22:16:00 +00:00
Owner
Copy Link

Originally created by @timheuer on GitHub (May 14, 2019).

Originally assigned to: @timheuer on GitHub.

Proposal: Ensure the Menu items show the keyboard shortcuts
Guidance: Keyboard accelerators

image
(note: yes the CTRL+Down is incorrect for settings, working on fixing that)

When enabling keyboard users, helping them not have to hunt for productive shortcuts is a good user experience. When using menus, it is best practice if a shortcut exists, to surface that to the user like above.

Changes are simple since the keyboard shortcuts are already there, changes to TerminalApp\App.cpp are all that are needed.

Questions:
[] How would this affect custom keybindings in #537 ?

Originally created by @timheuer on GitHub (May 14, 2019). Originally assigned to: @timheuer on GitHub. Proposal: Ensure the Menu items show the keyboard shortcuts Guidance: [Keyboard accelerators](https://docs.microsoft.com/en-us/windows/uwp/design/input/keyboard-accelerators) ![image](https://user-images.githubusercontent.com/4821/57726820-cf57c400-7644-11e9-8b0d-bc348e524262.png) (note: yes the CTRL+Down is incorrect for settings, working on fixing that) When enabling keyboard users, helping them not have to hunt for productive shortcuts is a good user experience. When using menus, it is best practice if a shortcut exists, to surface that to the user like above. Changes are simple since the keyboard shortcuts are already there, changes to TerminalApp\App.cpp are all that are needed. Questions: [] How would this affect custom keybindings in #537 ?
claunia added the Issue-FeatureNeeds-Tag-FixProduct-TerminalArea-UserInterface labels 2026-01-30 22:16:01 +00:00
claunia commented 2026-01-30 22:16:02 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (May 14, 2019):

@timheuer are you working on this? Should we assign you?

@miniksa commented on GitHub (May 14, 2019): @timheuer are you working on this? Should we assign you?
claunia commented 2026-01-30 22:16:02 +00:00
Author
Owner
Copy Link

@timheuer commented on GitHub (May 14, 2019):

Yes. There is a potential blocker in UWP APIs that I'm investigating, but I can take this.

@timheuer commented on GitHub (May 14, 2019): Yes. There is a potential blocker in UWP APIs that I'm investigating, but I can take this.
claunia commented 2026-01-30 22:16:02 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (May 15, 2019):

The JumpList items should match the order, and the profile order needs to persist so those keyboard accelerators can become almost muscle memory

@mdtauk commented on GitHub (May 15, 2019): The JumpList items should match the order, and the profile order needs to persist so those keyboard accelerators can become almost muscle memory
claunia commented 2026-01-30 22:16:02 +00:00
Author
Owner
Copy Link

@timheuer commented on GitHub (May 15, 2019):

@mdtauk this is not the JumpList item. But the menu already matches the order in profile.json file.

@timheuer commented on GitHub (May 15, 2019): @mdtauk this is not the JumpList item. But the menu already matches the order in profile.json file.
claunia commented 2026-01-30 22:16:02 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (May 15, 2019):

@timheuer noted :) - just wanted to emphasise the idea of keeping these consistent if the Shortcut Keys are numerical. Ctrl+Shift+1, 2, 3 etc

@mdtauk commented on GitHub (May 15, 2019): @timheuer noted :) - just wanted to emphasise the idea of keeping these consistent if the Shortcut Keys are numerical. Ctrl+Shift+1, 2, 3 etc
claunia commented 2026-01-30 22:16:03 +00:00
Author
Owner
Copy Link

@timheuer commented on GitHub (May 15, 2019):

The existing keybindings here are activated within the app. I can’t recall if you can trigger a jump list via a shortcut but good to add this feedback on that work item.

@timheuer commented on GitHub (May 15, 2019): The existing keybindings here are activated within the app. I can’t recall if you can trigger a jump list via a shortcut but good to add this feedback on that work item.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Feature Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1080
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?