Optimize the creation of the jumplist entries #10843

Closed
opened 2026-01-31 02:31:46 +00:00 by claunia · 3 comments
Owner

Originally created by @zadjii-msft on GitHub (Oct 1, 2020).

Originally assigned to: @PankajBhojwani on GitHub.

Taken from some rudimentary tracing that was done in #7774:

CShellLink::SetPath seems to be quite performance intensive for some reason. This is probably unnecessarily slowing down our startup.

Idea: maybe we could dispatch a background thread to update the jumplist? We don't really need to do that on the main thread, right?

Originally created by @zadjii-msft on GitHub (Oct 1, 2020). Originally assigned to: @PankajBhojwani on GitHub. Taken from some rudimentary tracing that was done in #7774: ![](https://user-images.githubusercontent.com/5862883/94674924-d0a89000-0310-11eb-8426-b5ee20bb0436.png) `CShellLink::SetPath` seems to be quite performance intensive for some reason. This is probably unnecessarily slowing down our startup. Idea: maybe we could dispatch a background thread to update the jumplist? We don't _really_ need to do that on the main thread, right?
Author
Owner

@DHowett commented on GitHub (Oct 1, 2020):

Yeah we should def dispatch this to the background with a copy of the profile list so it doesn’t get all mutated under us if there’s two quick back2back saves

@DHowett commented on GitHub (Oct 1, 2020): Yeah we should def dispatch this to the background with a copy of the profile list so it doesn’t get all mutated under us if there’s two quick back2back saves
Author
Owner

@ghost commented on GitHub (Nov 11, 2020):

:tada:This issue was addressed in #7978, which has now been successfully released as Windows Terminal v1.4.3141.0.🎉

Handy links:

@ghost commented on GitHub (Nov 11, 2020): :tada:This issue was addressed in #7978, which has now been successfully released as `Windows Terminal v1.4.3141.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.4.3141.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@ghost commented on GitHub (Nov 11, 2020):

:tada:This issue was addressed in #7978, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.🎉

Handy links:

@ghost commented on GitHub (Nov 11, 2020): :tada:This issue was addressed in #7978, which has now been successfully released as `Windows Terminal Preview v1.5.3142.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.5.3142.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10843