starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Resize with Reflow loses leading spaces on resize operation #1086

New Issue
Open
opened 2026-01-30 22:16:08 +00:00 by claunia · 0 comments
claunia commented 2026-01-30 22:16:08 +00:00
Owner
Copy Link

Originally created by @miniksa on GitHub (May 14, 2019).

To do this, we need to do #796 first.

This was a customer feedback bug MSFT:16934245. I didn't feel confident touching it because Resize with Reflow is sorta sketchy and was done before we really hit our stride on this project.

Here's the original Repro Steps:

Repro:

  1. Create a new C# console application.

  2. Use Console.WriteLine() to ask the user a question.

  3. Then use the ReadFromConsole_YesNo() method below to ask for a yes or no answer.

  4. Before pressing any key, maximize the console window that gets launched by VS.

ER: Insertion point remains indented by 4 spaces

AR: Insertion point jumps back to start of line

Once we have some actual tests around this, we might be able to dial in the resize with reflow algorithm to handle this better.

   /// <summary>
   /// Continuously reads lines of input from the console until a yes or no answer is received.
   /// Returns true if the read answer was "yes".  Otherwise, false is returned for "no".
   /// </summary>
   static bool ReadFromConsole_YesNo()
   {
       // Keep reading answers from the console until we get a "yes" or "no".
       while (true)
       {
           Console.Write("    "); // Indent input answers for readability
           Console.Out.Flush();
   
           string line = Console.ReadLine().Trim().ToLower(); // Get next answer
   
           // Check if it's a "yes" or "no".
           if      (line.Equals("yes")) {return true;}
           else if (line.Equals("y"))   {return true;}
           else if (line.Equals("no"))  {return false;}
           else if (line.Equals("n"))   {return false;}
       }
   }
Originally created by @miniksa on GitHub (May 14, 2019). To do this, we need to do #796 first. This was a customer feedback bug MSFT:16934245. I didn't feel confident touching it because Resize with Reflow is sorta sketchy and was done before we really hit our stride on this project. Here's the original Repro Steps: > Repro: > > 1. Create a new C# console application. > > 2. Use `Console.WriteLine()` to ask the user a question. > > 3. Then use the `ReadFromConsole_YesNo()` method below to ask for a yes or no answer. > > 4. Before pressing any key, maximize the console window that gets launched by VS. > > > > ER: Insertion point remains indented by 4 spaces > > AR: Insertion point jumps back to start of line Once we have some actual tests around this, we might be able to dial in the resize with reflow algorithm to handle this better. > ```c# > /// <summary> > /// Continuously reads lines of input from the console until a yes or no answer is received. > /// Returns true if the read answer was "yes". Otherwise, false is returned for "no". > /// </summary> > static bool ReadFromConsole_YesNo() > { > // Keep reading answers from the console until we get a "yes" or "no". > while (true) > { > Console.Write(" "); // Indent input answers for readability > Console.Out.Flush(); > > string line = Console.ReadLine().Trim().ToLower(); // Get next answer > > // Check if it's a "yes" or "no". > if (line.Equals("yes")) {return true;} > else if (line.Equals("y")) {return true;} > else if (line.Equals("no")) {return false;} > else if (line.Equals("n")) {return false;} > } > } > ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Interaction In-PR Issue-Bug Needs-Tag-Fix Priority-2 Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1086
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?