starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Split pane extends underlining #10893

New Issue
Closed
opened 2026-01-31 02:33:05 +00:00 by claunia · 10 comments
claunia commented 2026-01-31 02:33:05 +00:00
Owner
Copy Link

Originally created by @vefatica on GitHub (Oct 4, 2020).

Environment

Microsoft Windows 10 Pro for Workstations
10.0.18363.1082 (1909)
WindowsTerminalPreview_1.4.2652.0_x64

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable):

Any other software?

Steps to reproduce

In the shell of your choice, use ESC[4m to echo something underlined; be sure to terminate with ESC[0m. Use Alt+Shift+Plus to get a vertically split pane [note extended underlining]. Close the new pane [note underlining extended further].

Expected behavior

Underlining remains unchanged.

Actual behavior

See above and below.

Having managed to set the environment variable "esc" in cmd ...

image

Now I'll split vertically.

image

Now I'll close the new pane.

image

Originally created by @vefatica on GitHub (Oct 4, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment Microsoft Windows 10 Pro for Workstations 10.0.18363.1082 (1909) WindowsTerminalPreview_1.4.2652.0_x64 ```none Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] Windows Terminal version (if applicable): Any other software? ``` # Steps to reproduce In the shell of your choice, use ESC[4m to echo something underlined; be sure to terminate with ESC[0m. Use Alt+Shift+Plus to get a vertically split pane [note extended underlining]. Close the new pane [note underlining extended further]. <!-- A description of how to trigger this bug. --> # Expected behavior Underlining remains unchanged. <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior See above and below. <!-- What's actually happening? --> Having managed to set the environment variable "esc" in cmd ... ![image](https://user-images.githubusercontent.com/61856645/95020851-ac63f080-063b-11eb-87dd-29c200a52a4a.png) Now I'll split vertically. ![image](https://user-images.githubusercontent.com/61856645/95020879-c9002880-063b-11eb-8a8d-f915599e8902.png) Now I'll close the new pane. ![image](https://user-images.githubusercontent.com/61856645/95020898-df0de900-063b-11eb-8171-824acdca1f44.png)
claunia added the Resolution-Duplicate label 2026-01-31 02:33:05 +00:00
claunia commented 2026-01-31 02:33:06 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Oct 4, 2020):

Ubuntu/bash is probably easier. Start here:

image

@vefatica commented on GitHub (Oct 4, 2020): Ubuntu/bash is probably easier. Start here: ![image](https://user-images.githubusercontent.com/61856645/95021870-b12ba300-0641-11eb-89dc-58deeb9790d5.png)
claunia commented 2026-01-31 02:33:06 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 4, 2020):

/dup #32 (it’s the same issue: hyperlink is a text attribute, and color is just a really visible one)

@DHowett commented on GitHub (Oct 4, 2020): /dup #32 (it’s the same issue: hyperlink is a text attribute, and color is just a really visible one)
claunia commented 2026-01-31 02:33:06 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 4, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Oct 4, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 02:33:06 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Oct 5, 2020):

That's pretty old ... hard to fix or just low priority?

@vefatica commented on GitHub (Oct 5, 2020): That's pretty old ... hard to fix or just low priority?
claunia commented 2026-01-31 02:33:07 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 5, 2020):

Both.

@DHowett commented on GitHub (Oct 5, 2020): Both.
claunia commented 2026-01-31 02:33:07 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Nov 1, 2021):

Switching to/from full-screen does it too. This post is over a year old, #32 over four years old.

@vefatica commented on GitHub (Nov 1, 2021): Switching to/from full-screen does it too. This post is over a year old, #32 over **four** years old.
claunia commented 2026-01-31 02:33:07 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 1, 2021):

Yeah? It's both hard to fix and low-priority. Our text buffer isn't equipped to handle performant right-side measurement today.

@DHowett commented on GitHub (Nov 1, 2021): Yeah? It's both hard to fix and low-priority. Our text buffer isn't equipped to handle performant right-side measurement today.
claunia commented 2026-01-31 02:33:07 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Nov 1, 2021):

It affects colors too as you probably know. I can imagine that it's hard to fix; probably will require a very fundamental change. But I don't get the low priority. It seems a show-stopper as far being as ready-for-prime-time is concerned. And doesn't it get harder to fix the longer it goes unfixed?

Underlining is an attribute (COMMON_LVB_UNDERSCORE) ... yes/no? Isn't it stored? Or is nothing at all stored after the last character?

Is there any plan at all?

@vefatica commented on GitHub (Nov 1, 2021): It affects colors too as you probably know. I can imagine that it's hard to fix; probably will require a very fundamental change. But I don't get the low priority. It seems a show-stopper as far being as ready-for-prime-time is concerned. And doesn't it get harder to fix the longer it goes unfixed? Underlining is an attribute (COMMON_LVB_UNDERSCORE) ... yes/no? Isn't it stored? Or is nothing at all stored after the last character? Is there any plan at all?
claunia commented 2026-01-31 02:33:08 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 1, 2021):

I mean, this has been a bug in the Console since the days immemorial. It wasn't a show stopper 1989 so it's still not a show stopper now 😅

Underlining, colors, italics, any attribute of the text is stored in a TextAttribute, and those are stored in a TextAttributeRun, and the last one of those just gets resized to the width of the window on a resize, rather than filling in a placeholder "use the default attributes" TextAttributeRun.

Our "plan" to deal with that is largely in #8000, though, you're welcome to try finding an easier solution!

@zadjii-msft commented on GitHub (Nov 1, 2021): I mean, this has been a bug in the Console since the days immemorial. It wasn't a show stopper 1989 so it's still not a show stopper now 😅 Underlining, colors, italics, _any_ attribute of the text is stored in a `TextAttribute`, and those are stored in a `TextAttributeRun`, and the last one of those just gets resized to the width of the window on a resize, rather than filling in a placeholder "use the default attributes" `TextAttributeRun`. Our "plan" to deal with that is largely in #8000, though, you're welcome to try finding an easier solution!
claunia commented 2026-01-31 02:33:08 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Nov 1, 2021):

I have a kludgy workaround, at lease for the visual part of it. After turning off underlining (at the end of a line) I write a nbsp (0xA0). I imagine that would also work for other attributes. Why doesn't writing a real space (0x20) work ... are trailing spaces not saved?

@vefatica commented on GitHub (Nov 1, 2021): I have a kludgy workaround, at lease for the visual part of it. After turning off underlining (at the end of a line) I write a nbsp (0xA0). I imagine that would also work for other attributes. Why doesn't writing a real space (0x20) work ... are trailing spaces not saved?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10893
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?