Single-key binds for tab switching cause crash #10965

Closed
opened 2026-01-31 02:34:57 +00:00 by claunia · 6 comments
Owner

Originally created by @vvekic on GitHub (Oct 10, 2020).

Environment

Windows build number: 10.0.19041.0
Windows Terminal version (if applicable): 1.3.2651.0

Steps to reproduce

  1. Bind a single key (not a key combination such as the default crtl+tab) to either nextTab or prevTab. I used f3 for prevTab and f4 for nextTab.
  2. Spawn multiple tabs.
  3. Either quickly press your new nextTab or prevTab keys consecutively, or press and hold them.

Expected behavior

Tab switching should work even if switching tabs quickly or holding down the respective keys.
I expect to be able to bind byobu-like keys to tab control, i.e. f2, f3, f4 and use them effectively.

Actual behavior

The application crashes.

Note: I suspect it has something to do with the tabs context menu that spawns when switching tabs.

Originally created by @vvekic on GitHub (Oct 10, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 10.0.19041.0 Windows Terminal version (if applicable): 1.3.2651.0 ``` # Steps to reproduce 1. Bind a single key (not a key combination such as the default `crtl+tab`) to either `nextTab` or `prevTab`. I used `f3` for `prevTab` and `f4` for `nextTab`. 2. Spawn multiple tabs. 3. Either quickly press your new `nextTab` or `prevTab` keys consecutively, or press and hold them. # Expected behavior Tab switching should work even if switching tabs quickly or holding down the respective keys. I expect to be able to bind `byobu`-like keys to tab control, i.e. `f2`, `f3`, `f4` and use them effectively. # Actual behavior The application crashes. Note: I suspect it has something to do with the tabs context menu that spawns when switching tabs.
Author
Owner

@ghost commented on GitHub (Oct 11, 2020):

While you wait for it, you can use PowerToys's Keyboard Manager to bind a key to ctrl+tab

@ghost commented on GitHub (Oct 11, 2020): While you wait for it, you can use [PowerToys's](https://github.com/microsoft/PowerToys) Keyboard Manager to bind a key to <kbd>ctrl</kbd>+<kbd>tab</kbd>
Author
Owner

@vvekic commented on GitHub (Oct 12, 2020):

While you wait for it, you can use PowerToys's Keyboard Manager to bind a key to ctrl+tab

thanks! but alas, PowerToys only support remapping keys globally.

@vvekic commented on GitHub (Oct 12, 2020): > While you wait for it, you can use [PowerToys's](https://github.com/microsoft/PowerToys) Keyboard Manager to bind a key to ctrl+tab thanks! but alas, PowerToys only support remapping keys globally.
Author
Owner

@DHowett commented on GitHub (Oct 16, 2020):

Excellent catch. Thanks!

@DHowett commented on GitHub (Oct 16, 2020): Excellent catch. Thanks!
Author
Owner

@zadjii-msft commented on GitHub (Oct 29, 2020):

Well this is bizarre - I can't seem to get this to repro with either 1.3.2651.0 or 1.5.3011.0 (a recent internal build off main). I threw the following in my actions:


        { "command": "prevTab", "keys": "f1" },
        { "command": "nextTab", "keys": "f2" },

and they seem to be working fine, albeit, if I hold them for too long, the window does glitch out for a bit and stop actually changing tabs, as if it can't keep up with the switching.

I suspect it has something to do with the tabs context menu that spawns when switching tabs.

anything in particular that makes you think this?

We've got a bunch of changes in the works for how the tab switcher operates, maybe this will just go away in 1.5?

@zadjii-msft commented on GitHub (Oct 29, 2020): Well this is bizarre - I can't seem to get this to repro with either 1.3.2651.0 or 1.5.3011.0 (a recent internal build off `main`). I threw the following in my `actions`: ```json { "command": "prevTab", "keys": "f1" }, { "command": "nextTab", "keys": "f2" }, ``` and they seem to be working fine, albeit, if I hold them for too long, the window does glitch out for a bit and stop actually changing tabs, as if it can't keep up with the switching. > I suspect it has something to do with the tabs context menu that spawns when switching tabs. anything in particular that makes you think this? We've got a bunch of changes in the works for how the tab switcher operates, maybe this will just go away in 1.5?
Author
Owner

@Don-Vito commented on GitHub (Feb 7, 2021):

@vvekic - can you please check if it still happens to you in 1.6 preview?

@Don-Vito commented on GitHub (Feb 7, 2021): @vvekic - can you please check if it still happens to you in 1.6 preview?
Author
Owner

@ghost commented on GitHub (Feb 12, 2021):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Feb 12, 2021): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10965