[Functional-Command Palette]- User is not able to perform action using shortcuts when command palette is open. #11012

Closed
opened 2026-01-31 02:36:14 +00:00 by claunia · 8 comments
Owner

Originally created by @DasaradhaKamjula on GitHub (Oct 13, 2020).

User Experience:
Users who rely on screen reader/Keyboard will not be able to perform action efficiently if shortcuts are not working when command palette is open

Test Environment:
App: Windows Terminal Preview
Feature: Command Palette
OS: Win 10 2004 Build (19041.508)

Repro Steps:
1.Open Windows terminal Preview app
2.Open Command Palette using shortcut (Ctrl+shift+p)
3.Verify whether user is able to perform any shortcut operation when command palette is open.

Actual:
User is not able to perform action using shortcuts when command palette is open.

Expected:
User should be able to perform the shortcut operation even when the command palette is open.

Originally created by @DasaradhaKamjula on GitHub (Oct 13, 2020). **User Experience:** Users who rely on screen reader/Keyboard will not be able to perform action efficiently if shortcuts are not working when command palette is open **Test Environment:** App: Windows Terminal Preview Feature: Command Palette OS: Win 10 2004 Build (19041.508) **Repro Steps:** 1.Open Windows terminal Preview app 2.Open Command Palette using shortcut (Ctrl+shift+p) 3.Verify whether user is able to perform any shortcut operation when command palette is open. **Actual:** User is not able to perform action using shortcuts when command palette is open. **Expected:** User should be able to perform the shortcut operation even when the command palette is open.
Author
Owner

@zadjii-msft commented on GitHub (Oct 13, 2020):

@cinnamon-msft @DasaradhaKamjula What's the process for resolving these issues as dupes? We've already got #6679 tracking this same issue

@zadjii-msft commented on GitHub (Oct 13, 2020): @cinnamon-msft @DasaradhaKamjula What's the process for resolving these issues as dupes? We've already got #6679 tracking this same issue
Author
Owner

@ghost commented on GitHub (Oct 14, 2020):

This issue has been marked as duplicate and has not had any activity for 1 day. It will be closed for housekeeping purposes.

@ghost commented on GitHub (Oct 14, 2020): This issue has been marked as duplicate and has not had any activity for **1 day**. It will be closed for housekeeping purposes.
Author
Owner

@ghost commented on GitHub (Oct 15, 2020):

This issue has been marked as duplicate and has not had any activity for 1 day. It will be closed for housekeeping purposes.

@ghost commented on GitHub (Oct 15, 2020): This issue has been marked as duplicate and has not had any activity for **1 day**. It will be closed for housekeeping purposes.
Author
Owner

@ghost commented on GitHub (Oct 21, 2020):

I’m going to work on this.

@ghost commented on GitHub (Oct 21, 2020): I’m going to work on this.
Author
Owner

@zadjii-msft commented on GitHub (Oct 21, 2020):

@Hegunumo thanks! Be careful while working on this one - it might be trickier than it seems on the surface. I tried doing this before, by passing the ShortcutActionDispatch to the CommandPalette, but there were enough weird edge cases that I never followed up on it. There's a bunch more notes of the pitfalls I found in #6679.

If you need any help, feel free to ask questions ☺️

@zadjii-msft commented on GitHub (Oct 21, 2020): @Hegunumo thanks! Be careful while working on this one - it might be trickier than it seems on the surface. I tried doing this before, by passing the `ShortcutActionDispatch` to the `CommandPalette`, but there were enough weird edge cases that I never followed up on it. There's a bunch more notes of the pitfalls I found in #6679. If you need any help, feel free to ask questions ☺️
Author
Owner

@zadjii-msft commented on GitHub (Aug 19, 2021):

@Chandresh1007 @Priyanka-Chauhan123 @DasaradhaKamjula I believe this is fixed in newer versions of the Terminal. (fixed in #8586). Could you confirm and close this?

@zadjii-msft commented on GitHub (Aug 19, 2021): @Chandresh1007 @Priyanka-Chauhan123 @DasaradhaKamjula I believe this is fixed in newer versions of the Terminal. (fixed in #8586). Could you confirm and close this?
Author
Owner

@ghost commented on GitHub (Aug 23, 2021):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Aug 23, 2021): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
Author
Owner

@Priyanka-Chauhan123 commented on GitHub (Aug 24, 2021):

Issue is fixed. Verified on Windows Terminal Version: 1.9.1942.0. Hence, closing the bug.

@Priyanka-Chauhan123 commented on GitHub (Aug 24, 2021): Issue is fixed. Verified on Windows Terminal Version: 1.9.1942.0. Hence, closing the bug.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11012