[Visual requirement-Command Palette]-Luminosity ratio is 4.046:1 which is less than 4.5:1 for the shortcut text appended to the Commands. #11014

Closed
opened 2026-01-31 02:36:18 +00:00 by claunia · 6 comments
Owner

Originally created by @DasaradhaKamjula on GitHub (Oct 13, 2020).

Originally assigned to: @zadjii-msft on GitHub.

User Experience:
Vision impairment users will not be able to view the text clearly if the Luminosity ratio is less than 4.5:1 .

Test Environment:
App: Windows Terminal Preview
Feature: Command Palette
OS: Win 10 2004 Build (19041.508)

Repro Steps:
1.Open Windows terminal Preview app
2.Open Command Palette using shortcut (Ctrl+shift+p)
3.verify the Luminosity ratio for shortcut text.

Actual:
Luminosity ratio is 4.046:1 which is less than 4.5:1 for the shortcut texts appended to the commands.(For Example: Luminosity ratio of Close pane command shortcut text Ctrl+Shift+W is 4.04:1 )

Expected:
Luminosity ratio should be greater than 4.5:1 for the short cut texts which are appended to the commands

Originally created by @DasaradhaKamjula on GitHub (Oct 13, 2020). Originally assigned to: @zadjii-msft on GitHub. **User Experience:** Vision impairment users will not be able to view the text clearly if the Luminosity ratio is less than 4.5:1 . **Test Environment:** App: Windows Terminal Preview Feature: Command Palette OS: Win 10 2004 Build (19041.508) **Repro Steps:** 1.Open Windows terminal Preview app 2.Open Command Palette using shortcut (Ctrl+shift+p) 3.verify the Luminosity ratio for shortcut text. **Actual:** Luminosity ratio is 4.046:1 which is less than 4.5:1 for the shortcut texts appended to the commands.(For Example: Luminosity ratio of Close pane command shortcut text Ctrl+Shift+W is 4.04:1 ) **Expected:** Luminosity ratio should be greater than 4.5:1 for the short cut texts which are appended to the commands
Author
Owner

@zadjii-msft commented on GitHub (Oct 13, 2020):

Yep this is reasonable. I bet we could make the background of the keys even darker (in dark mode) relative to the cmdpal background, and that'll probably look good.

@zadjii-msft commented on GitHub (Oct 13, 2020): Yep this is reasonable. I bet we could make the background of the keys even _darker_ (in dark mode) relative to the cmdpal background, and that'll probably look good.
Author
Owner

@DHowett commented on GitHub (Jan 6, 2021):

This issue was fixed in #7937 and deployed to production in November.

@DHowett commented on GitHub (Jan 6, 2021): This issue was fixed in #7937 and deployed to production in November.
Author
Owner

@zadjii-msft commented on GitHub (Feb 25, 2021):

@awalia13 / @DasaradhaKamjula If this is confirmed as fixed, can we close this issue now?

@zadjii-msft commented on GitHub (Feb 25, 2021): @awalia13 / @DasaradhaKamjula If this is confirmed as fixed, can we close this issue now?
Author
Owner

@zadjii-msft commented on GitHub (May 20, 2021):

@Chandresh1007 If this is confirmed as fixed, can we close this issue now?

@zadjii-msft commented on GitHub (May 20, 2021): @Chandresh1007 If this is confirmed as fixed, can we close this issue now?
Author
Owner

@Priyanka-Chauhan123 commented on GitHub (Jun 23, 2021):

Issue is fixed. Verified on Windows terminal version: 1.8.1521.0 and OS version: Win 10 build 21390.2025. Hence, closing the bug.

@Priyanka-Chauhan123 commented on GitHub (Jun 23, 2021): Issue is fixed. Verified on Windows terminal version: 1.8.1521.0 and OS version: Win 10 build 21390.2025. Hence, closing the bug.
Author
Owner

@Priyanka-Chauhan123 commented on GitHub (Jan 9, 2024):

Closing the bug as issue has been fixed.

@Priyanka-Chauhan123 commented on GitHub (Jan 9, 2024): Closing the bug as issue has been fixed.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11014