ReadPendingInput plays unsafe byte/char games with pending data #1102

Open
opened 2026-01-30 22:16:36 +00:00 by claunia · 1 comment
Owner

Originally created by @miniksa on GitHub (May 15, 2019).

Originally assigned to: @adiviness on GitHub.

Ported from MSFT: 18047766.

I fixed an immediate crash bug in MSFT: 17987369 that affected this area, but realized at the time that it's really bad that the ReadPendingInput function in the console host is playing games with a void pointer and mix-and-match of byte versus character counting.

This represents investigating what we can do to stop mix/matching the char and byte counts in ReadPendingInput.

@adiviness might be working on something like this with his changes to input to support emoji...

Originally created by @miniksa on GitHub (May 15, 2019). Originally assigned to: @adiviness on GitHub. Ported from MSFT: 18047766. I fixed an immediate crash bug in MSFT: 17987369 that affected this area, but realized at the time that it's really bad that the `ReadPendingInput` function in the console host is playing games with a void pointer and mix-and-match of byte versus character counting. This represents investigating what we can do to stop mix/matching the char and byte counts in `ReadPendingInput`. @adiviness might be working on something like this with his changes to input to support emoji...
claunia added the Issue-FeatureProduct-ConhostArea-InputArea-Server labels 2026-01-30 22:16:36 +00:00
Author
Owner

@adiviness commented on GitHub (May 15, 2019):

Yup, I'm going to have to fix this up as well.

@adiviness commented on GitHub (May 15, 2019): Yup, I'm going to have to fix this up as well.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1102