starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Cannot use ALT to split panes after opening Close... tab submenu #11046

New Issue
Closed
opened 2026-01-31 02:37:07 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 02:37:07 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Oct 16, 2020).

Environment

Windows Terminal version (if applicable): 1.5.2892

Regression from #7728.

It looks like every time we try to split a pane, we try to re-register the menu items against the tab.
We try to reparent the menu items into a new context menu. Because of that, we eat an exception that they already have parents.

All Tab event registration fails afterwards for that tab.

Originally created by @DHowett on GitHub (Oct 16, 2020). # Environment ```none Windows Terminal version (if applicable): 1.5.2892 ``` Regression from #7728. It looks like every time we try to _split a pane_, we try to re-register the menu items against the tab. We try to reparent the menu items into a new context menu. Because of that, we eat an exception that they already have parents. All Tab event registration fails afterwards for that tab.
claunia commented 2026-01-31 02:37:09 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 16, 2020):

(/cc @mpela81, if you want to have a fun debugging session 😄)

@DHowett commented on GitHub (Oct 16, 2020): (/cc @mpela81, if you want to have a fun debugging session :smile:)
claunia commented 2026-01-31 02:37:09 +00:00
Author
Owner
Copy Link

@mpela81 commented on GitHub (Oct 16, 2020):

Fantastic 😄

As far as I can see, when splitting panes we call Tab::Initialize again, which re-builds the context menu from scratch. But we keep a reference to the closeTabsAfter/closeOtherTabs sub-menu items (to enable/disable them at runtime), so the same end up being appended to a new parent and 💣

To fix it, we could re-create the sub-items as well. Alternatively, the question is why creating the context menu again in the first place?

@mpela81 commented on GitHub (Oct 16, 2020): Fantastic 😄 As far as I can see, when splitting panes we call `Tab::Initialize` again, which re-builds the context menu from scratch. But we keep a reference to the closeTabsAfter/closeOtherTabs sub-menu items (to enable/disable them at runtime), so the same end up being appended to a new parent and 💣 To fix it, we could re-create the sub-items as well. Alternatively, the question is why creating the context menu again in the first place?
claunia commented 2026-01-31 02:37:09 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 16, 2020):

why creating the context menu again in the first place?

If I had to guess, I'd say... "oversight"!

@DHowett commented on GitHub (Oct 16, 2020): > why creating the context menu again in the first place? If I had to guess, I'd say... "oversight"!
claunia commented 2026-01-31 02:37:09 +00:00
Author
Owner
Copy Link

@mpela81 commented on GitHub (Oct 16, 2020):

why creating the context menu again in the first place?

If I had to guess, I'd say... "oversight"!

so... we could just move the _CreateContextMenu() call to the Tab's constructor, couldn't we?

@mpela81 commented on GitHub (Oct 16, 2020): > > > > why creating the context menu again in the first place? > > If I had to guess, I'd say... "oversight"! so... we could just move the `_CreateContextMenu()` call to the Tab's constructor, couldn't we?
claunia commented 2026-01-31 02:37:09 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 11, 2020):

:tada:This issue was addressed in #7961, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.🎉

Handy links:

@ghost commented on GitHub (Nov 11, 2020): :tada:This issue was addressed in #7961, which has now been successfully released as `Windows Terminal Preview v1.5.3142.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.5.3142.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11046
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?