starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Close Menu, "Close other tabs" and "Close tabs to right" always operate on tab index 0, are always enabled #11069

New Issue
Closed
opened 2026-01-31 02:37:48 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 02:37:48 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Oct 20, 2020).

Originally assigned to: @DHowett, @carlos-zamora on GitHub.

I'm not sure if this is an issue in main or an issue in feature/settings-ui.

/cc @mpela81

Originally created by @DHowett on GitHub (Oct 20, 2020). Originally assigned to: @DHowett, @carlos-zamora on GitHub. I'm not sure if this is an issue in main or an issue in feature/settings-ui. /cc @mpela81
claunia commented 2026-01-31 02:37:50 +00:00
Author
Owner
Copy Link

@mpela81 commented on GitHub (Oct 20, 2020):

Looks fine on master, maybe it wasn't fully merged onto the feature branch?

immagine

@mpela81 commented on GitHub (Oct 20, 2020): Looks fine on master, maybe it wasn't fully merged onto the feature branch? ![immagine](https://user-images.githubusercontent.com/1140981/96576414-7331ae80-12d2-11eb-9880-fdbb78ce0ee1.png)
claunia commented 2026-01-31 02:37:50 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 21, 2020):

Excellent. In that case, it's on me 😄

@DHowett commented on GitHub (Oct 21, 2020): Excellent. In that case, it's on me :smile:
claunia commented 2026-01-31 02:37:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 21, 2020):

Uh oh, I'm seeing this on the 1.5.2941.0 selfhost the team is working with as well.

@zadjii-msft commented on GitHub (Oct 21, 2020): Uh oh, I'm seeing this on the 1.5.2941.0 selfhost the team is working with as well.
claunia commented 2026-01-31 02:37:51 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 21, 2020):

Fortunately, that is built off feature/settings-ui!

@DHowett commented on GitHub (Oct 21, 2020): Fortunately, that is built off feature/settings-ui!
claunia commented 2026-01-31 02:37:51 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 22, 2020):

Looks like this was @carlos-zamora's merge commit

commit 0ce05b5405df96a829d4756f44e4b1daffe28083
Merge: e00275232 743283e43
Author: Carlos Zamora <cazamor@microsoft.com>
Date:   Fri Oct 16 12:48:21 2020 -0700

    Merge branch 'master' into feature/settings-ui

Carlos, this commit lost the call to _EnableCloseMenuItems in the various tab implementations that controlled whether the menu items were enabled/disabled.

@DHowett commented on GitHub (Oct 22, 2020): Looks like this was @carlos-zamora's merge commit ``` commit 0ce05b5405df96a829d4756f44e4b1daffe28083 Merge: e00275232 743283e43 Author: Carlos Zamora <cazamor@microsoft.com> Date: Fri Oct 16 12:48:21 2020 -0700 Merge branch 'master' into feature/settings-ui ``` Carlos, this commit lost the call to `_EnableCloseMenuItems` in the various tab implementations that controlled whether the menu items were enabled/disabled.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Bug Needs-Tag-Fix Priority-1 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11069
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?