starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add GH Action: Cache #11072

New Issue
Closed
opened 2026-01-31 02:37:55 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 02:37:55 +00:00
Owner
Copy Link

Originally created by @WSLUser on GitHub (Oct 19, 2020).

Description of the new feature/enhancement

Use GH Action Cache to speed up builds by caching the Nuget dependencies.

Proposed technical implementation details (optional)

Add a yaml config for testing this. https://github.com/actions/cache/blob/main/examples.md#c---nuget was the guidance I received to add it for this project.

Originally created by @WSLUser on GitHub (Oct 19, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> Use GH Action Cache to speed up builds by caching the Nuget dependencies. # Proposed technical implementation details (optional) Add a yaml config for testing this. https://github.com/actions/cache/blob/main/examples.md#c---nuget was the guidance I received to add it for this project. <!-- A clear and concise description of what you want to happen. -->
claunia added the Help WantedIssue-TaskResolution-Won't-FixProduct-MetaArea-Build labels 2026-01-31 02:37:56 +00:00
claunia commented 2026-01-31 02:37:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 19, 2020):

Sure, though I doubt this will really result in a noticeable build time improvement, since like 45 seconds is spent restoring packages, and 30 minutes is spent building the code and running the tests

@zadjii-msft commented on GitHub (Oct 19, 2020): Sure, though I doubt this will really result in a noticeable build time improvement, since like 45 seconds is spent restoring packages, and 30 minutes is spent building the code and running the tests
claunia commented 2026-01-31 02:37:57 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Oct 19, 2020):

Right now still testing how to keep linter happy and have it read correctly.

So it should download the deps to the repo wherever we tell it. The test will be when I submit the PR as I don't have Azure Pipeline setup for my fork. If build speeds don't go down by much we can ignore it. It's also set to trigger on push not pull request as that's what is shown in the example, probably switch that temporarily for test purposes.

@WSLUser commented on GitHub (Oct 19, 2020): Right now still testing how to keep linter happy and have it read correctly. So it should download the deps to the repo wherever we tell it. The test will be when I submit the PR as I don't have Azure Pipeline setup for my fork. If build speeds don't go down by much we can ignore it. It's also set to trigger on push not pull request as that's what is shown in the example, probably switch that temporarily for test purposes.
claunia commented 2026-01-31 02:37:57 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 19, 2020):

Thanks for the suggestion! We evaluated build caching[1] and found it to not amount to a reasonable time savings. Turns out that downloading and extracting the cache archive takes just as long on our build agents as downloading and extracting the original packages. This is no surprise: they're just static files.

If we were caching the output of some slow process (npm comes to mind) or something that is compiled, it would be more worth our while.

Right now, it's not.

[1] Additionally: Using a github caching action in our azure devops pipeline will almost certainly help nothing. What we tested was actual caching in the azure devops pipeline.

@DHowett commented on GitHub (Oct 19, 2020): Thanks for the suggestion! We evaluated build caching[1] and found it to not amount to a reasonable time savings. Turns out that _downloading and extracting the cache archive_ takes just as long on our build agents as _downloading and extracting the original packages_. This is no surprise: they're just static files. If we were caching the output of some slow process (`npm` comes to mind) or something that is compiled, it would be more worth our while. Right now, it's not. [1] _Additionally_: Using a github caching action in our _azure devops pipeline_ will almost certainly help nothing. What we tested was actual caching in the azure devops pipeline.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Help Wanted Issue-Task Product-Meta Resolution-Won't-Fix
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11072
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?