starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Optimize images across the repo #11084

New Issue
Closed
opened 2026-01-31 02:38:15 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 02:38:15 +00:00
Owner
Copy Link

Originally created by @WSLUser on GitHub (Oct 20, 2020).

Description of the new feature/enhancement

Optimize images added from PRs automatically to reduce image size while retaining image quality. (Looking at https://github.com/microsoft/terminal/pull/7971 in particular). This will help keep the disk size of Windows Terminal down when updating or adding new images.

Proposed technical implementation details (optional)

Add the yaml file. Also, if this is accepted, I have another image optimization PR I can do to optimize our current images (reducing the overall image size by 23% for this repo) which I'd prefer to do prior to adding this Action as the images were optimized from separate tooling and don't want any corruption added to the images (it does detect if an image doesn't require optimization).

Originally created by @WSLUser on GitHub (Oct 20, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> Optimize images added from PRs automatically to reduce image size while retaining image quality. (Looking at https://github.com/microsoft/terminal/pull/7971 in particular). This will help keep the disk size of Windows Terminal down when updating or adding new images. # Proposed technical implementation details (optional) Add the yaml file. Also, if this is accepted, I have another image optimization PR I can do to optimize our current images (reducing the overall image size by 23% for this repo) which I'd prefer to do prior to adding this Action as the images were optimized from separate tooling and don't want any corruption added to the images (it does detect if an image doesn't require optimization). <!-- A clear and concise description of what you want to happen. -->
claunia commented 2026-01-31 02:38:16 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 20, 2020):

I'm interested in optimizing the existing ones, but I don't think it's necessary to add another action that enforces it.

For the terminal app resource directories, it looks like we save a grand total of ~42kb/flavor or about 11%. Where are you seeing the greatest savings?

@DHowett commented on GitHub (Oct 20, 2020): I'm interested in optimizing the existing ones, but I don't think it's necessary to add another action that enforces it. For the terminal app resource directories, it looks like we save a grand total of ~42kb/flavor or about 11%. Where are you seeing the greatest savings?
claunia commented 2026-01-31 02:38:16 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Oct 20, 2020):

So the Action can't handle svg files so it skips those due to it's dependencies but using ImgBot, all png and svg files had a file reduction size. This is mostly to help reduce the footprint for hosts that don't have a bunch of storage available where even a few MB might matter. Compared to other things, it's probably not the biggest change that can help but it's a quick easy one. I did a visual inspection from several types of devices to verify the images looked the same.

@WSLUser commented on GitHub (Oct 20, 2020): So the Action can't handle svg files so it skips those due to it's dependencies but using ImgBot, all png and svg files had a file reduction size. This is mostly to help reduce the footprint for hosts that don't have a bunch of storage available where even a few MB might matter. Compared to other things, it's probably not the biggest change that can help but it's a quick easy one. I did a visual inspection from several types of devices to verify the images looked the same.
claunia commented 2026-01-31 02:38:16 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Oct 20, 2020):

If you're not interested in adding the Action, I can repurpose this issue for general image optimization and link the PR against it.

@WSLUser commented on GitHub (Oct 20, 2020): If you're not interested in adding the Action, I can repurpose this issue for general image optimization and link the PR against it.
claunia commented 2026-01-31 02:38:17 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 11, 2020):

:tada:This issue was addressed in #8169, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.🎉

Handy links:

@ghost commented on GitHub (Nov 11, 2020): :tada:This issue was addressed in #8169, which has now been successfully released as `Windows Terminal Preview v1.5.3142.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.5.3142.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Feature Needs-Attention Needs-Tag-Fix Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11084
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?