starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Context menu on tabs doesn't close when clicking in the title bar #11089

New Issue
Closed
opened 2026-01-31 02:38:20 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 02:38:20 +00:00
Owner
Copy Link

Originally created by @jroessel on GitHub (Oct 21, 2020).

Environment

PS> [System.Environment]::OSVersion

Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.19041.0 Microsoft Windows NT 10.0.19041.0

Windows Terminal
Version: 1.3.2651.0

Steps to reproduce

  1. Right click on a tab in Windows Terminal to open the context menu.
  2. Click somewhere else to close it again.

Expected behavior

The context menu closes, regardless of where the click in step 2 goes.

Actual behavior

The context menu closes in pretty much all places, even different applications (presumably because losing focus also closes it), but doesn't close when clicking the title bar of WIndows Terminal. It does close when clicking controls in the title bar, though, even the default window buttons in the upper right.

Originally created by @jroessel on GitHub (Oct 21, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none PS> [System.Environment]::OSVersion Platform ServicePack Version VersionString -------- ----------- ------- ------------- Win32NT 10.0.19041.0 Microsoft Windows NT 10.0.19041.0 Windows Terminal Version: 1.3.2651.0 ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> 1. Right click on a tab in Windows Terminal to open the context menu. 2. Click somewhere else to close it again. # Expected behavior The context menu closes, regardless of where the click in step 2 goes. <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior The context menu closes in pretty much all places, even different applications (presumably because losing focus also closes it), but doesn't close when clicking the title bar of WIndows Terminal. It does close when clicking controls in the title bar, though, even the default window buttons in the upper right. <!-- What's actually happening? -->
claunia commented 2026-01-31 02:38:22 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 21, 2020):

Well that's the darndest thing. I bet this is the same thing as #2028 (which was fixed in #2438), but with the tab context fylout menu, not the new tab flyout.

@zadjii-msft commented on GitHub (Oct 21, 2020): Well that's the darndest thing. I bet this is the same thing as #2028 (which was fixed in #2438), but with the tab context fylout menu, not the new tab flyout.
claunia commented 2026-01-31 02:38:22 +00:00
Author
Owner
Copy Link

@jroessel commented on GitHub (Oct 23, 2020):

Coming only from higher-level UI toolkits in managed code I always thought the popup was somewhat responsible for closing itself by getting mouse capture and reacting to clicks elsewhere and closing itself. But perhaps that's the more complicated or otherwise undesirable option in native Win32. No actual idea, though :)

@jroessel commented on GitHub (Oct 23, 2020): Coming only from higher-level UI toolkits in managed code I always thought the popup was somewhat responsible for closing itself by getting mouse capture and reacting to clicks elsewhere and closing itself. But perhaps that's the more complicated or otherwise undesirable option in native Win32. No actual idea, though :)
claunia commented 2026-01-31 02:38:22 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 27, 2020):

Coming only from higher-level UI toolkits in managed code I always thought the popup was somewhat responsible for closing itself by getting mouse capture and reacting to clicks elsewhere and closing itself. But perhaps that's the more complicated or otherwise undesirable option in native Win32. No actual idea, though :)

You're totally right, @jroessel! We're in the unfortunate position of using two different UI frameworks at the same time (XAML and Win32). To get our titlebar draggable while still being able to theme it like the rest of the application, we had to eat mouse clicks in a region at the top of the window. Doing that obscures the click target that would dismiss the flyout menu 😄

@DHowett commented on GitHub (Oct 27, 2020): > Coming only from higher-level UI toolkits in managed code I always thought the popup was somewhat responsible for closing itself by getting mouse capture and reacting to clicks elsewhere and closing itself. But perhaps that's the more complicated or otherwise undesirable option in native Win32. No actual idea, though :) You're totally right, @jroessel! We're in the unfortunate position of using two different UI frameworks at the same time (XAML and Win32). To get our titlebar draggable while still being able to theme it like the rest of the application, we had to eat mouse clicks in a region at the top of the window. Doing that obscures the click target that would dismiss the flyout menu :smile:
claunia commented 2026-01-31 02:38:22 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 11, 2020):

:tada:This issue was addressed in #8010, which has now been successfully released as Windows Terminal v1.4.3141.0.🎉

Handy links:

@ghost commented on GitHub (Nov 11, 2020): :tada:This issue was addressed in #8010, which has now been successfully released as `Windows Terminal v1.4.3141.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.4.3141.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 02:38:22 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 11, 2020):

:tada:This issue was addressed in #8010, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.🎉

Handy links:

@ghost commented on GitHub (Nov 11, 2020): :tada:This issue was addressed in #8010, which has now been successfully released as `Windows Terminal Preview v1.5.3142.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.5.3142.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11089
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?