starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

{ "type": null } in profiles.schema.json violates JSON Schema draft 2019-09 meta-schema #11138

New Issue
Open
opened 2026-01-31 02:39:37 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 02:39:37 +00:00
Owner
Copy Link

Originally created by @KalleOlaviNiemitalo on GitHub (Oct 23, 2020).

https://aka.ms/terminal-profiles-schema redirects to https://raw.githubusercontent.com/microsoft/terminal/release-1.3/doc/cascadia/profiles.schema.json, i.e. the raw view of https://github.com/microsoft/terminal/blob/release-1.3/doc/cascadia/profiles.schema.json. That schema uses the https://json-schema.org/draft/2019-09/schema# meta-schema:

https://github.com/microsoft/terminal/blob/327ddd702307952c315b07fc7a815d56fd68f7ba/doc/cascadia/profiles.schema.json#L3

The #/definitions/CloseOtherTabsAction and #/definitions/CloseTabsAfterAction schemas have a subschema { "type": null }:

https://github.com/microsoft/terminal/blob/327ddd702307952c315b07fc7a815d56fd68f7ba/doc/cascadia/profiles.schema.json#L401
https://github.com/microsoft/terminal/blob/327ddd702307952c315b07fc7a815d56fd68f7ba/doc/cascadia/profiles.schema.json#L420

That is not valid according to https://tools.ietf.org/html/draft-handrews-json-schema-validation-02#section-6.1.1, referenced by http://json-schema.org/specification-links.html#2019-09-formerly-known-as-draft-8. The value of type "MUST be either a string or an array"; null is neither.

{ "type": "null" } would be valid according to the meta-schema, but it would not match the documentation https://docs.microsoft.com/windows/terminal/customize-settings/actions#close-tabs-after-index, which says that the index property is optional but does not say that an explicit { "index": null } is allowed.

The null literals were added in https://github.com/microsoft/terminal/pull/7390. Meta-schemas were also discussed in https://github.com/microsoft/terminal/issues/7683.

Originally created by @KalleOlaviNiemitalo on GitHub (Oct 23, 2020). <https://aka.ms/terminal-profiles-schema> redirects to <https://raw.githubusercontent.com/microsoft/terminal/release-1.3/doc/cascadia/profiles.schema.json>, i.e. the raw view of <https://github.com/microsoft/terminal/blob/release-1.3/doc/cascadia/profiles.schema.json>. That schema uses the <https://json-schema.org/draft/2019-09/schema#> meta-schema: <https://github.com/microsoft/terminal/blob/327ddd702307952c315b07fc7a815d56fd68f7ba/doc/cascadia/profiles.schema.json#L3> The `#/definitions/CloseOtherTabsAction` and `#/definitions/CloseTabsAfterAction` schemas have a subschema ` { "type": null }`: <https://github.com/microsoft/terminal/blob/327ddd702307952c315b07fc7a815d56fd68f7ba/doc/cascadia/profiles.schema.json#L401> <https://github.com/microsoft/terminal/blob/327ddd702307952c315b07fc7a815d56fd68f7ba/doc/cascadia/profiles.schema.json#L420> That is not valid according to <https://tools.ietf.org/html/draft-handrews-json-schema-validation-02#section-6.1.1>, referenced by <http://json-schema.org/specification-links.html#2019-09-formerly-known-as-draft-8>. The value of **type** "MUST be either a string or an array"; `null` is neither. `{ "type": "null" }` would be valid according to the meta-schema, but it would not match the documentation <https://docs.microsoft.com/windows/terminal/customize-settings/actions#close-tabs-after-index>, which says that the `index` property is optional but does not say that an explicit `{ "index": null }` is allowed. The `null` literals were added in <https://github.com/microsoft/terminal/pull/7390>. Meta-schemas were also discussed in <https://github.com/microsoft/terminal/issues/7683>.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Schema Issue-Docs Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11138
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?