starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Close button doesn't use a tab's text color when hovered #11174

New Issue
Closed
opened 2026-01-31 02:40:34 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 02:40:34 +00:00
Owner
Copy Link

Originally created by @TylerEich on GitHub (Oct 26, 2020).

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 1.3.2651.0

Any other software?
No.

Steps to reproduce

Open a tab. Color it yellow. Hover over its close button.

47103599-d504-44ba-bc36-a39aa98ef7c4

Expected behavior

The × should be black, like it was before I hovered.

Actual behavior

The × is white, like the default text color.

Related to #5789

Originally created by @TylerEich on GitHub (Oct 26, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 10.0.18363.0 Windows Terminal version (if applicable): 1.3.2651.0 Any other software? No. ``` # Steps to reproduce Open a tab. Color it yellow. Hover over its close button. ![47103599-d504-44ba-bc36-a39aa98ef7c4](https://user-images.githubusercontent.com/3460063/97187427-cd21f080-1778-11eb-8d3d-4f391d4383e6.gif) # Expected behavior The × should be black, like it was before I hovered. # Actual behavior The × is white, like the default text color. Related to #5789
claunia commented 2026-01-31 02:40:36 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 27, 2020):

Wow yep, that's a real bug. Probably similar to #5780, but for the tab hover color.

@zadjii-msft commented on GitHub (Oct 27, 2020): Wow yep, that's a real bug. Probably similar to #5780, but for the tab hover color.
claunia commented 2026-01-31 02:40:36 +00:00
Author
Owner
Copy Link

@dcheatha commented on GitHub (Nov 10, 2020):

I fixed the tab text coloring issue, however this fix seems to introduce another problem.

Light theme white tab mouse hover effect:
Screenshot_2020-11-07_152110_3

Dark theme white tab mouse hover effect:
Screenshot_2020-11-07_153021_2

Should I calculate and set the button shadow manually here, or is there some way to set the button theme?

@dcheatha commented on GitHub (Nov 10, 2020): I fixed the tab text coloring issue, however this fix seems to introduce another problem. Light theme white tab mouse hover effect: ![Screenshot_2020-11-07_152110_3](https://user-images.githubusercontent.com/7143383/98625373-503c5e00-22c4-11eb-86f6-49bc0c18a3b4.png) Dark theme white tab mouse hover effect: ![Screenshot_2020-11-07_153021_2](https://user-images.githubusercontent.com/7143383/98625415-69dda580-22c4-11eb-80ec-094f249fae0f.png) Should I calculate and set the button shadow manually here, or is there some way to set the button theme?
claunia commented 2026-01-31 02:40:36 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 10, 2020):

@dcheatha - I think that the behavior you describe already exists prior to you fix. I checked this with vanilla, but please give it a try as well. (Hence I think your fix is already of high value 😊).

Regarding your question, I am not an author, but given that in the current implementation all brushes are computed manually, I guess the same should apply to the button shadow.

@Don-Vito commented on GitHub (Nov 10, 2020): @dcheatha - I think that the behavior you describe already exists prior to you fix. I checked this with vanilla, but please give it a try as well. (Hence I think your fix is already of high value 😊). Regarding your question, I am not an author, but given that in the current implementation all brushes are computed manually, I guess the same should apply to the button shadow.
claunia commented 2026-01-31 02:40:37 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8209, which has now been successfully released as Windows Terminal v1.5.10271.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8209, which has now been successfully released as `Windows Terminal v1.5.10271.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.5.10271.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 02:40:37 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8209, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8209, which has now been successfully released as `Windows Terminal Preview v1.6.10272.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10272.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface good first issue Help Wanted Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11174
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?