starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-10-01 11:22:33 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Implement inheritance/layering behavior for settings lists/maps #11218

New Issue
Open
opened 2026-01-31 02:41:48 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 02:41:48 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Oct 29, 2020).

Description of the new feature/enhancement

TSM Inheritance (Spec #7876 + Impl #7923 ) enabled an object model representation of layering JSON. Some settings that are saved to arrays/maps (i.e. actions, color schemes) still experience a special form of layering that is not represented in the object model.

Today, the object model std::moves the list of actions/schemes down child-by-child, and directly modifies those values. We need to restructure this system to...

  • track where an action/color scheme came from
  • layer actions over other actions

This blocks the following work items:

  • serialization for actions
  • Settings UI implementation for actions
  • serializing only new color schemes (ones not from defaults.json)

This also is partially related to...

Originally created by @carlos-zamora on GitHub (Oct 29, 2020). # Description of the new feature/enhancement TSM Inheritance (Spec #7876 + Impl #7923 ) enabled an object model representation of layering JSON. Some settings that are saved to arrays/maps (i.e. actions, color schemes) still experience a special form of layering that is not represented in the object model. Today, the object model `std::move`s the list of actions/schemes down child-by-child, and directly modifies those values. We need to restructure this system to... - track where an action/color scheme came from - layer actions over other actions This blocks the following work items: - serialization for actions - Settings UI implementation for actions - serializing only _new_ color schemes (ones not from defaults.json) This also is partially related to... - #7175 Action IDs
claunia added the Area-SettingsIssue-TaskProduct-Terminal labels 2026-01-31 02:41:48 +00:00
claunia commented 2026-01-31 02:41:49 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Feb 11, 2021):

Moved this to backlog because this is more related to #8991 and #6900. So it's not extremely urgent right now.

@carlos-zamora commented on GitHub (Feb 11, 2021): Moved this to backlog because this is more related to #8991 and #6900. So it's not extremely urgent right now.
claunia commented 2026-01-31 02:41:49 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (May 12, 2021):

#9621 solves most of the problem here.

The remaining work to be done is for color schemes.

@carlos-zamora commented on GitHub (May 12, 2021): #9621 solves most of the problem here. The remaining work to be done is for color schemes.
claunia commented 2026-01-31 02:41:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 27, 2024):

@DHowett So, I think #12800 closes out the last bit of this? This issue was written long before Leonard re-wrote the settings parser, so I don't think it's relevant anymore?

@zadjii-msft commented on GitHub (Feb 27, 2024): @DHowett So, I think #12800 closes out the last bit of this? This issue was written long before Leonard re-wrote the settings parser, so I don't think it's relevant anymore?
claunia commented 2026-01-31 02:41:50 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 27, 2024):

I'm still somewhat uncomfortable with this -- we are still doing flat mapping of things that come from different layers, we're just doing it more cleverly with 12800. Themes aren't touched at all, so they are still flat-mapped.

@DHowett commented on GitHub (Feb 27, 2024): I'm still somewhat uncomfortable with this -- we are still doing flat mapping of things that come from different layers, we're just doing it more _cleverly_ with 12800. Themes aren't touched at all, so they are still flat-mapped.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11218
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?