starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Only underline hyperlinks on hover #11247

New Issue
Closed
opened 2026-01-31 02:42:28 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 02:42:28 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Nov 1, 2020).

Originally assigned to: @DHowett on GitHub.

Description of the new feature/enhancement

I can understand that some people will feel differently about this, but could we at least have an option to underline the hyperlinks only when the mouse is hovered over them, instead of showing the underline all the time?

On explicit hyperlinks (via OSC 8) I feel it should really be up to the app generating the link to choose how it wants that rendered. For example, you might be trying to make a link look like a button, but then we add dashed underlines everywhere which totally mess up the effect.

In the case of the autodetected hyperlinks, it's already obvious when something is a link. And the annoying thing is the underline doesn't track very well when you scroll, so ends up lingering on areas of the page that don't even have a link. I don't know if that's something we can fix, but either way I'd rather it just didn't underline at all until you hovered.

And as a point of comparison, every terminal I've tried so far that autodetects links does so my showing the underline only when you hover over the link. This includes Gnome Terminal, Konsole, Alacritty, Kitty, Terminator, and Mintty - the latter only showing the underline when you're pressing Ctrl at the same time.

For OSC 8 links, Gnome Terminal displays a dotted underline without having to hover, but it's at least more subtle than our dashed underline. Mintty again only shows an underline when actually hovering over the link with the Ctrl key pressed.

Originally created by @j4james on GitHub (Nov 1, 2020). Originally assigned to: @DHowett on GitHub. # Description of the new feature/enhancement I can understand that some people will feel differently about this, but could we at least have an option to underline the hyperlinks only when the mouse is hovered over them, instead of showing the underline all the time? On explicit hyperlinks (via `OSC 8`) I feel it should really be up to the app generating the link to choose how it wants that rendered. For example, you might be trying to make a link look like a button, but then we add dashed underlines everywhere which totally mess up the effect. In the case of the autodetected hyperlinks, it's already obvious when something is a link. And the annoying thing is the underline doesn't track very well when you scroll, so ends up lingering on areas of the page that don't even have a link. I don't know if that's something we can fix, but either way I'd rather it just didn't underline at all until you hovered. And as a point of comparison, every terminal I've tried so far that autodetects links does so my showing the underline only when you hover over the link. This includes Gnome Terminal, Konsole, Alacritty, Kitty, Terminator, and Mintty - the latter only showing the underline when you're pressing `Ctrl` at the same time. For `OSC 8` links, Gnome Terminal displays a dotted underline without having to hover, but it's at least more subtle than our dashed underline. Mintty again only shows an underline when actually hovering over the link with the `Ctrl` key pressed.
claunia commented 2026-01-31 02:42:31 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 2, 2020):

Yeah, I’m actually totally in support of this. It hides a chosen deficiency (scanning for URLs on a delay) and makes the screen less cluttered.

How about:

  • we use a less obtrusive dotted line, eventually configurable, for OSC 8
  • that dotted line becomes a solid line on hover
  • for detected URLs, we use no treatment but offer a solid line on hover

Eventually, we can add configuration for different treatments for both types of link.

@DHowett commented on GitHub (Nov 2, 2020): Yeah, I’m actually totally in support of this. It hides a chosen deficiency (scanning for URLs on a delay) and makes the screen less cluttered. How about: * we use a less obtrusive dotted line, eventually configurable, for OSC 8 * that dotted line becomes a solid line on hover * for detected URLs, we use no treatment but offer a solid line on hover Eventually, we can add configuration for different treatments for both types of link.
claunia commented 2026-01-31 02:42:31 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 3, 2020):

This is now in PR in #8148.

@DHowett commented on GitHub (Nov 3, 2020): This is now in PR in #8148.
claunia commented 2026-01-31 02:42:32 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 11, 2020):

:tada:This issue was addressed in #8148, which has now been successfully released as Windows Terminal v1.4.3141.0.🎉

Handy links:

@ghost commented on GitHub (Nov 11, 2020): :tada:This issue was addressed in #8148, which has now been successfully released as `Windows Terminal v1.4.3141.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.4.3141.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 02:42:32 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 11, 2020):

:tada:This issue was addressed in #8148, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.🎉

Handy links:

@ghost commented on GitHub (Nov 11, 2020): :tada:This issue was addressed in #8148, which has now been successfully released as `Windows Terminal Preview v1.5.3142.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.5.3142.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Task Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11247
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?